You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/10/26 05:32:23 UTC
[GitHub] [incubator-nuttx-apps] xiaoxiang781216 opened a new pull request, #1386: Fix Error: ftpd.c:1773:9: error: variable 'pos' set but not used [-Werror,-Wunused-but-set-variable]
xiaoxiang781216 opened a new pull request, #1386:
URL: https://github.com/apache/incubator-nuttx-apps/pull/1386
## Summary
Report by: https://github.com/apache/incubator-nuttx/actions/runs/3318241409/jobs/5482179373
## Impact
Fix warning
## Testing
Pass CI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] hartmannathan commented on pull request #1386: Fix Error: ftpd.c:1773:9: error: variable 'pos' set but not used [-Werror,-Wunused-but-set-variable]
Posted by GitBox <gi...@apache.org>.
hartmannathan commented on PR #1386:
URL: https://github.com/apache/incubator-nuttx-apps/pull/1386#issuecomment-1291916161
> @xiaoxiang781216 seems it is not always unused, or the analyser tool reports wrongly
>
> ```
> 2022-10-26T05:52:17.9833033Z ftpd.c: In function 'ftpd_stream':
> 2022-10-26T05:52:17.9863517Z ##[error]ftpd.c:1902:7: error: 'pos' undeclared (first use in this function)
> 2022-10-26T05:52:17.9874208Z 1902 | pos += (off_t)seekoffs;
> 2022-10-26T05:52:17.9874489Z | ^~~
> ```
It is a dead store. It is assigned and incremented, but never read.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] pkarashchenko commented on pull request #1386: Fix Error: ftpd.c:1773:9: error: variable 'pos' set but not used [-Werror,-Wunused-but-set-variable]
Posted by GitBox <gi...@apache.org>.
pkarashchenko commented on PR #1386:
URL: https://github.com/apache/incubator-nuttx-apps/pull/1386#issuecomment-1291812548
@xiaoxiang781216 seems it is not always unused, or the analyser tool reports wrongly
```
2022-10-26T05:52:17.9833033Z ftpd.c: In function 'ftpd_stream':
2022-10-26T05:52:17.9863517Z ##[error]ftpd.c:1902:7: error: 'pos' undeclared (first use in this function)
2022-10-26T05:52:17.9874208Z 1902 | pos += (off_t)seekoffs;
2022-10-26T05:52:17.9874489Z | ^~~
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] pkarashchenko merged pull request #1386: Fix Error: ftpd.c:1773:9: error: variable 'pos' set but not used [-Werror,-Wunused-but-set-variable]
Posted by GitBox <gi...@apache.org>.
pkarashchenko merged PR #1386:
URL: https://github.com/apache/incubator-nuttx-apps/pull/1386
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] pkarashchenko commented on pull request #1386: Fix Error: ftpd.c:1773:9: error: variable 'pos' set but not used [-Werror,-Wunused-but-set-variable]
Posted by GitBox <gi...@apache.org>.
pkarashchenko commented on PR #1386:
URL: https://github.com/apache/incubator-nuttx-apps/pull/1386#issuecomment-1291814552
Maybe we need to remove `pos += ...` line as well
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org