You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@brooklyn.apache.org by aledsage <gi...@git.apache.org> on 2017/06/09 17:27:27 UTC
[GitHub] brooklyn-server pull request #726: Add ConfigKey builders
GitHub user aledsage opened a pull request:
https://github.com/apache/brooklyn-server/pull/726
Add ConfigKey builders
This change is motivated by (and is is preparation for) supporting deprecated names for`ConfigKey`s.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/aledsage/brooklyn-server add-ConfigKey-builders
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/brooklyn-server/pull/726.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #726
----
commit 9eda68af87226920cc3310821b2e66ec7eefca3b
Author: Aled Sage <al...@gmail.com>
Date: 2017-06-08T13:56:25Z
Add ConfigKey builders
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] brooklyn-server issue #726: Add ConfigKey builders
Posted by aledsage <gi...@git.apache.org>.
Github user aledsage commented on the issue:
https://github.com/apache/brooklyn-server/pull/726
The jenkins build failed with what looks like an unrelated error (which we should investigate separately):
```
java.lang.AssertionError: entity=MyServiceWithFeedsImpl{id=ghzmpwboh4}; attribute=Sensor: service.process.isRunning (java.lang.Boolean) expected [true] but found [null]
at org.apache.brooklyn.entity.software.base.SoftwareProcessEntityFeedRebindTest.runFeedsDoNotPollUntilManaged(SoftwareProcessEntityFeedRebindTest.java:110)
at org.apache.brooklyn.entity.software.base.SoftwareProcessEntityFeedRebindTest.testFeedsDoNotPollUntilManaged(SoftwareProcessEntityFeedRebindTest.java:68)
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] brooklyn-server issue #726: Add ConfigKey builders
Posted by aledsage <gi...@git.apache.org>.
Github user aledsage commented on the issue:
https://github.com/apache/brooklyn-server/pull/726
retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] brooklyn-server issue #726: Add ConfigKey builders
Posted by neykov <gi...@git.apache.org>.
Github user neykov commented on the issue:
https://github.com/apache/brooklyn-server/pull/726
The jenkins PR builder is currently building master without the PR changes. Don't rely on the result for merging.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] brooklyn-server pull request #726: Add ConfigKey builders
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/brooklyn-server/pull/726
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---