You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nifi.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2016/04/14 15:30:25 UTC
[jira] [Commented] (NIFI-1762) Simplify revision management that
happens in StandardNiFiServiceFacade
[ https://issues.apache.org/jira/browse/NIFI-1762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15241148#comment-15241148 ]
ASF GitHub Bot commented on NIFI-1762:
--------------------------------------
GitHub user markap14 opened a pull request:
https://github.com/apache/nifi/pull/352
NIFI-1762: Use Lambda Expressions in StandardNiFIServiceFacade to simplify codebase
Changed Java dependency to 1.8 instead of 1.7 and refactored StandardNiFiServiceFacade to make use of Lambda expressions to simplify code base. Also had to address a unit test because changing to Java 8 results in calls to assertEquals to become ambiguous
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/markap14/nifi NIFI-1762
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/352.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #352
----
commit 31097e82cef5dc0614cffe826e417f39bda4fb69
Author: Mark Payne <ma...@hotmail.com>
Date: 2016-04-14T13:28:25Z
NIFI-1762: Changed Java dependency to 1.8 instead of 1.7 and refactored StandardNiFiServiceFacade to make use of Lambda expressions to simplify code base. Also had to address a unit test because changing to Java 8 results in calls to assertEquals to become ambiguous
----
> Simplify revision management that happens in StandardNiFiServiceFacade
> ----------------------------------------------------------------------
>
> Key: NIFI-1762
> URL: https://issues.apache.org/jira/browse/NIFI-1762
> Project: Apache NiFi
> Issue Type: Improvement
> Components: Core Framework
> Reporter: Mark Payne
> Assignee: Mark Payne
> Fix For: 1.0.0
>
>
> Currently, StandardNiFiServiceFacade has a huge amount of repetitive code to ensure that changes to the flow occur always with the appropriate revision and that the revision is updated appropriately.
> However, this is very tedious and prone to copy/paste errors and requires updating the code in many places if something changes.
> With NiFi 1.0 depending on Java 8, we can make use of Java's Lambda functions in order to dramatically simplify the code.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)