You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficcontrol.apache.org by "gokulakrishnansvm (via GitHub)" <gi...@apache.org> on 2023/04/17 16:37:14 UTC

[GitHub] [trafficcontrol] gokulakrishnansvm opened a new pull request, #7449: Added Api contract test case for tenants endpoint

gokulakrishnansvm opened a new pull request, #7449:
URL: https://github.com/apache/trafficcontrol/pull/7449

   <!--
   Thank you for contributing! Please be sure to read our contribution guidelines: https://github.com/apache/trafficcontrol/blob/master/CONTRIBUTING.md
   If this closes or relates to an existing issue, please reference it using one of the following:
   
   Closes: #ISSUE
   Related: #ISSUE
   
   If this PR fixes a security vulnerability, DO NOT submit! Instead, contact
   the Apache Traffic Control Security Team at security@trafficcontrol.apache.org and follow the
   guidelines at https://apache.org/security regarding vulnerability disclosure.
   -->
   
   Adding API Contract Test Case for profiles endpoint.
   <!-- **^ Add meaningful description above** --><hr/>
   
   
   ## Which Traffic Control components are affected by this PR?
   <!-- Please delete all components from this list that are NOT affected by this PR.
   Feel free to add the name of a tool or script that is affected but not on the list.
   -->
   - Traffic Ops Test
   
   
   ## What is the best way to verify this PR?
   
   Step 1 : Install requirements
   pip install -r requirements.txt
   
   Step 2 : To execute profiles API Contract Testcase , navigate to traffic_ops/testing/api_contract/v4
   pytest --to-user Username --to-password Password --to-url URL --config Config Path --request-template Request template --response-template Response template test_tenants.py
   
   Note: Config, Request template and response template paths are optional. 
   
   ## PR submission checklist
   - [x] This PR has tests <!-- If not, please delete this text and explain why this PR does not need tests. -->
   - [x] This PR **DOES NOT FIX A SERIOUS SECURITY VULNERABILITY** (see [the Apache Software Foundation's security guidelines](https://apache.org/security) for details)
   
   <!--
   Licensed to the Apache Software Foundation (ASF) under one
   or more contributor license agreements.  See the NOTICE file
   distributed with this work for additional information
   regarding copyright ownership.  The ASF licenses this file
   to you under the Apache License, Version 2.0 (the
   "License"); you may not use this file except in compliance
   with the License.  You may obtain a copy of the License at
   
       http://www.apache.org/licenses/LICENSE-2.0
   
   Unless required by applicable law or agreed to in writing,
   software distributed under the License is distributed on an
   "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
   KIND, either express or implied.  See the License for the
   specific language governing permissions and limitations
   under the License.
   -->
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [trafficcontrol] gokulakrishnansvm commented on a diff in pull request #7449: Added Api contract test case for tenants endpoint

Posted by "gokulakrishnansvm (via GitHub)" <gi...@apache.org>.
gokulakrishnansvm commented on code in PR #7449:
URL: https://github.com/apache/trafficcontrol/pull/7449#discussion_r1172078836


##########
traffic_ops/testing/api_contract/v4/request_template.json:
##########
@@ -43,5 +43,12 @@
 			"type": "UNK_PROFILE",
 			"routingDisabled": true
 		}
+	],
+	"tenants": [
+		{
+			"active": true,
+			"name": "test",
+			"parentId": 1
+		}
 	]
-}
+}

Review Comment:
   Added!



##########
traffic_ops/testing/api_contract/v4/response_template.json:
##########
@@ -149,5 +149,28 @@
                 "type": "str"
             }
         }
+    },
+    "tenants": {
+        "type": "object",
+        "properties": {
+            "id": {
+                "type": "int"
+            },
+            "name": {
+                "type": "str"
+            },
+            "active": {
+                "type": "bool"
+            },
+            "parentId": {
+                "type": "int"
+            },
+            "lastUpdated": {
+                "type": "str"
+            },
+            "parentName": {
+                "type": "str"
+            }
+        }
     }
-}
+}

Review Comment:
   Added!



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [trafficcontrol] TerekhovaKate commented on a diff in pull request #7449: Added Api contract test case for tenants endpoint

Posted by "TerekhovaKate (via GitHub)" <gi...@apache.org>.
TerekhovaKate commented on code in PR #7449:
URL: https://github.com/apache/trafficcontrol/pull/7449#discussion_r1171832721


##########
traffic_ops/testing/api_contract/v4/request_template.json:
##########
@@ -43,5 +43,12 @@
 			"type": "UNK_PROFILE",
 			"routingDisabled": true
 		}
+	],
+	"tenants": [
+		{
+			"active": true,
+			"name": "test",
+			"parentId": 1
+		}
 	]
-}
+}

Review Comment:
   not newline at the end of file



##########
traffic_ops/testing/api_contract/v4/response_template.json:
##########
@@ -149,5 +149,28 @@
                 "type": "str"
             }
         }
+    },
+    "tenants": {
+        "type": "object",
+        "properties": {
+            "id": {
+                "type": "int"
+            },
+            "name": {
+                "type": "str"
+            },
+            "active": {
+                "type": "bool"
+            },
+            "parentId": {
+                "type": "int"
+            },
+            "lastUpdated": {
+                "type": "str"
+            },
+            "parentName": {
+                "type": "str"
+            }
+        }
     }
-}
+}

Review Comment:
   no newline at the and of file



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [trafficcontrol] rimashah25 merged pull request #7449: Added Api contract test case for tenants endpoint

Posted by "rimashah25 (via GitHub)" <gi...@apache.org>.
rimashah25 merged PR #7449:
URL: https://github.com/apache/trafficcontrol/pull/7449


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [trafficcontrol] rimashah25 commented on pull request #7449: Added Api contract test case for tenants endpoint

Posted by "rimashah25 (via GitHub)" <gi...@apache.org>.
rimashah25 commented on PR #7449:
URL: https://github.com/apache/trafficcontrol/pull/7449#issuecomment-1521945684

   CIAB-Build tests are failing but are not related to this PR. Merging the PR.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org