[camel] branch master updated: CAMEL-14312: Fix issues reported by lgtm

[oa...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

oalsafi pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/camel.git


The following commit(s) were added to refs/heads/master by this push:
     new a112f3b  CAMEL-14312: Fix issues reported by lgtm
     new 1b6022d  Merge pull request #3424 from omarsmak/CAMEL-14312
a112f3b is described below

commit a112f3b6dd7bff78cf230da5913f0992c063d2ce
Author: Omar Al-Safi <om...@gmail.com>
AuthorDate: Thu Dec 19 11:38:49 2019 +0100

    CAMEL-14312: Fix issues reported by lgtm
---
 .../src/main/java/org/apache/camel/component/hbase/HBaseProducer.java | 2 --
 .../src/main/java/org/apache/camel/swagger/RestSwaggerReader.java     | 4 ----
 .../src/main/java/org/apache/camel/component/xslt/XsltBuilder.java    | 2 +-
 .../java/org/apache/camel/tools/apt/EndpointAnnotationProcessor.java  | 2 +-
 4 files changed, 2 insertions(+), 8 deletions(-)

diff --git a/components/camel-hbase/src/main/java/org/apache/camel/component/hbase/HBaseProducer.java b/components/camel-hbase/src/main/java/org/apache/camel/component/hbase/HBaseProducer.java
index dd99703..4fd8209 100644
--- a/components/camel-hbase/src/main/java/org/apache/camel/component/hbase/HBaseProducer.java
+++ b/components/camel-hbase/src/main/java/org/apache/camel/component/hbase/HBaseProducer.java
@@ -136,7 +136,6 @@ public class HBaseProducer extends DefaultProducer {
      */
     private HBaseRow getCells(Table table, HBaseRow hRow) throws Exception {
         HBaseRow resultRow = new HBaseRow();
-        List<HBaseCell> resultCells = new LinkedList<>();
         ObjectHelper.notNull(hRow, "HBase row");
         ObjectHelper.notNull(hRow.getId(), "HBase row id");
         ObjectHelper.notNull(hRow.getCells(), "HBase cells");
@@ -172,7 +171,6 @@ public class HBaseProducer extends DefaultProducer {
                 resultCell.setValue(endpoint.getCamelContext().getTypeConverter().convertTo(cellModel.getValueType(), CellUtil.cloneValue(kvs.get(0))));
                 resultCell.setTimestamp(kvs.get(0).getTimestamp());
             }
-            resultCells.add(resultCell);
             resultRow.getCells().add(resultCell);
         }
         return resultRow;
diff --git a/components/camel-swagger-java/src/main/java/org/apache/camel/swagger/RestSwaggerReader.java b/components/camel-swagger-java/src/main/java/org/apache/camel/swagger/RestSwaggerReader.java
index 68c4ea6..2897ac4 100644
--- a/components/camel-swagger-java/src/main/java/org/apache/camel/swagger/RestSwaggerReader.java
+++ b/components/camel-swagger-java/src/main/java/org/apache/camel/swagger/RestSwaggerReader.java
@@ -230,9 +230,6 @@ public class RestSwaggerReader {
     }
 
     private void doParseVerbs(Swagger swagger, RestDefinition rest, String camelContextId, List<VerbDefinition> verbs, String pathAsTag) {
-        // used during gathering of apis
-        List<Path> paths = new ArrayList<>();
-
         String basePath = rest.getPath();
 
         for (VerbDefinition verb : verbs) {
@@ -269,7 +266,6 @@ public class RestSwaggerReader {
             Path path = swagger.getPath(opPath);
             if (path == null) {
                 path = new Path();
-                paths.add(path);
             }
             path = path.set(method, op);
 
diff --git a/components/camel-xslt/src/main/java/org/apache/camel/component/xslt/XsltBuilder.java b/components/camel-xslt/src/main/java/org/apache/camel/component/xslt/XsltBuilder.java
index 48454d3..2eaabcb 100644
--- a/components/camel-xslt/src/main/java/org/apache/camel/component/xslt/XsltBuilder.java
+++ b/components/camel-xslt/src/main/java/org/apache/camel/component/xslt/XsltBuilder.java
@@ -66,7 +66,7 @@ public class XsltBuilder implements Processor {
     private XMLConverterHelper converter = new XMLConverterHelper();
     private Templates template;
     private volatile BlockingQueue<Transformer> transformers;
-    private SourceHandlerFactory sourceHandlerFactory;
+    private volatile SourceHandlerFactory sourceHandlerFactory;
     private ResultHandlerFactory resultHandlerFactory = new StringResultHandlerFactory();
     private boolean failOnNullBody = true;
     private URIResolver uriResolver;
diff --git a/tooling/apt/src/main/java/org/apache/camel/tools/apt/EndpointAnnotationProcessor.java b/tooling/apt/src/main/java/org/apache/camel/tools/apt/EndpointAnnotationProcessor.java
index ca103e0..3df14a6 100644
--- a/tooling/apt/src/main/java/org/apache/camel/tools/apt/EndpointAnnotationProcessor.java
+++ b/tooling/apt/src/main/java/org/apache/camel/tools/apt/EndpointAnnotationProcessor.java
@@ -941,7 +941,7 @@ public class EndpointAnnotationProcessor extends AbstractCamelAnnotationProcesso
         if (method.getReturnType() instanceof DeclaredType) {
             final DeclaredType returnType = (DeclaredType) method.getReturnType();
 
-            return "groovy.lang.MetaClass".equals(returnType.asElement().getSimpleName());
+            return "groovy.lang.MetaClass".equals(returnType.asElement().getSimpleName().toString());
         } else {
             // Eclipse (Groovy?) compiler returns javax.lang.model.type.NoType, no other way to check but to look at toString output
             return method.toString().contains("(groovy.lang.MetaClass)");