[GitHub] [cassandra] jacek-lewandowski commented on a diff in pull request #2149: Cassandra 18211 4.1

["jacek-lewandowski (via GitHub)" <gi...@apache.org>]

jacek-lewandowski commented on code in PR #2149:
URL: https://github.com/apache/cassandra/pull/2149#discussion_r1102879393


##########
src/java/org/apache/cassandra/service/snapshot/SnapshotManager.java:
##########
@@ -106,22 +109,21 @@ public synchronized void addSnapshot(TableSnapshot snapshot)
         }
     }
 
-    @VisibleForTesting
-    protected synchronized void loadSnapshots()
+    public Set<TableSnapshot> loadSnapshots()

Review Comment:
   why is it not synchronized anymore?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org