You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Todd Lipcon (Code Review)" <ge...@cloudera.org> on 2019/03/16 06:07:09 UTC
[native-toolchain-CR] IMPALA-8316. Update re2 to latest version
Hello Lars Volker,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/12771
to review the following change.
Change subject: IMPALA-8316. Update re2 to latest version
......................................................................
IMPALA-8316. Update re2 to latest version
Change-Id: I41f749500fb5e86d3c46621177d2ed256b8a4130
---
M buildall.sh
1 file changed, 2 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/native-toolchain refs/changes/71/12771/1
--
To view, visit http://gerrit.cloudera.org:8080/12771
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I41f749500fb5e86d3c46621177d2ed256b8a4130
Gerrit-Change-Number: 12771
Gerrit-PatchSet: 1
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
[native-toolchain-CR] IMPALA-8316. Update re2 to latest version
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12771 )
Change subject: IMPALA-8316. Update re2 to latest version
......................................................................
IMPALA-8316. Update re2 to latest version
Change-Id: I41f749500fb5e86d3c46621177d2ed256b8a4130
Reviewed-on: http://gerrit.cloudera.org:8080/12771
Reviewed-by: Lars Volker <lv...@cloudera.com>
Tested-by: Todd Lipcon <to...@apache.org>
---
M buildall.sh
1 file changed, 2 insertions(+), 1 deletion(-)
Approvals:
Lars Volker: Looks good to me, approved
Todd Lipcon: Verified
--
To view, visit http://gerrit.cloudera.org:8080/12771
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I41f749500fb5e86d3c46621177d2ed256b8a4130
Gerrit-Change-Number: 12771
Gerrit-PatchSet: 2
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[native-toolchain-CR] IMPALA-8316. Update re2 to latest version
Posted by "Lars Volker (Code Review)" <ge...@cloudera.org>.
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/12771 )
Change subject: IMPALA-8316. Update re2 to latest version
......................................................................
Patch Set 1: Code-Review+2
I'll reach out to you in person to point you to the right Jenkins jobs to publish the build artifacts.
--
To view, visit http://gerrit.cloudera.org:8080/12771
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I41f749500fb5e86d3c46621177d2ed256b8a4130
Gerrit-Change-Number: 12771
Gerrit-PatchSet: 1
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Mon, 18 Mar 2019 01:39:57 +0000
Gerrit-HasComments: No
[native-toolchain-CR] IMPALA-8316. Update re2 to latest version
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/12771 )
Change subject: IMPALA-8316. Update re2 to latest version
......................................................................
Patch Set 1: Verified+1
Build ran and artifacts are now on S3 with id 255-58192fb6bc
--
To view, visit http://gerrit.cloudera.org:8080/12771
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I41f749500fb5e86d3c46621177d2ed256b8a4130
Gerrit-Change-Number: 12771
Gerrit-PatchSet: 1
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Mon, 18 Mar 2019 17:07:09 +0000
Gerrit-HasComments: No
[native-toolchain-CR] IMPALA-8316. Update re2 to latest version
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/12771 )
Change subject: IMPALA-8316. Update re2 to latest version
......................................................................
Patch Set 1:
Not sure how to kick off appropriate Jenkins stuff for a native-toolchain build, but I built this locally and pointed Impala at it, verified that it still built OK and improved perf
--
To view, visit http://gerrit.cloudera.org:8080/12771
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I41f749500fb5e86d3c46621177d2ed256b8a4130
Gerrit-Change-Number: 12771
Gerrit-PatchSet: 1
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Sat, 16 Mar 2019 06:07:50 +0000
Gerrit-HasComments: No