You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2022/10/16 12:58:00 UTC
[GitHub] [dolphinscheduler] fbjoker opened a new pull request, #12390: [Improvement-5918]Remove the code logger.isDebugEnabled()
fbjoker opened a new pull request, #12390:
URL: https://github.com/apache/dolphinscheduler/pull/12390
<!--Thanks very much for contributing to Apache DolphinScheduler. Please review https://dolphinscheduler.apache.org/en-us/community/development/pull-request.html before opening a pull request.-->
## Purpose of the pull request
Remove the code logger.isDebugEnabled() in module reomte
## Brief change log
remove the code logger.isDebugEnabled()
## Verify this pull request
<!--*(Please pick either of the following options)*-->
This pull request is code cleanup without any test coverage.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] fbjoker commented on pull request #12390: [Improvement-5918]Remove the code logger.isDebugEnabled()
Posted by GitBox <gi...@apache.org>.
fbjoker commented on PR #12390:
URL: https://github.com/apache/dolphinscheduler/pull/12390#issuecomment-1280334085
> PR:#12389 ?
> > yes, I don't know how to pass milestone-label-check, so I modified commite meage and resubmitted it，bug its also check fail. Can I cancel the submission
>
> Sure, u can close one. And commiter will add mileston-label.
> [9](https://github.com/apache/dolphinscheduler/pull/12389) ?
> > yes, I don't know how to pass milestone-label-check, so I modified commite meage and resubmitted it，bug its also check fail. Can I cancel the submission
>
> Sure, u can close one. And commiter will add mileston-label.
thanks, i close PR #12389
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] ruanwenjun commented on pull request #12390: [Improvement-5918]Remove the code logger.isDebugEnabled()
Posted by GitBox <gi...@apache.org>.
ruanwenjun commented on PR #12390:
URL: https://github.com/apache/dolphinscheduler/pull/12390#issuecomment-1282017609
I don't think this PR is needed, if no other concern, I will close this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] DarkAssassinator commented on pull request #12390: [Improvement-5918]Remove the code logger.isDebugEnabled()
Posted by GitBox <gi...@apache.org>.
DarkAssassinator commented on PR #12390:
URL: https://github.com/apache/dolphinscheduler/pull/12390#issuecomment-1280279333
> yes, I don't know how to pass milestone-label-check, so I modified commite meage and resubmitted it，bug its also check fail. Can I cancel the submission
Sure, u can close one. And commiter will add mileston-label.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] DarkAssassinator commented on pull request #12390: [Improvement-5918]Remove the code logger.isDebugEnabled()
Posted by GitBox <gi...@apache.org>.
DarkAssassinator commented on PR #12390:
URL: https://github.com/apache/dolphinscheduler/pull/12390#issuecomment-1279967475
same as PR:https://github.com/apache/dolphinscheduler/pull/12389 ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] ruanwenjun closed pull request #12390: [Improvement-5918]Remove the code logger.isDebugEnabled()
Posted by GitBox <gi...@apache.org>.
ruanwenjun closed pull request #12390: [Improvement-5918]Remove the code logger.isDebugEnabled()
URL: https://github.com/apache/dolphinscheduler/pull/12390
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] fuchanghai commented on pull request #12390: [Improvement-5918]Remove the code logger.isDebugEnabled()
Posted by GitBox <gi...@apache.org>.
fuchanghai commented on PR #12390:
URL: https://github.com/apache/dolphinscheduler/pull/12390#issuecomment-1280128817
> same as PR:#12389 ?
it looks like same as this PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] ruanwenjun commented on a diff in pull request #12390: [Improvement-5918]Remove the code logger.isDebugEnabled()
Posted by GitBox <gi...@apache.org>.
ruanwenjun commented on code in PR #12390:
URL: https://github.com/apache/dolphinscheduler/pull/12390#discussion_r997895787
##########
dolphinscheduler-remote/src/main/java/org/apache/dolphinscheduler/remote/handler/NettyClientHandler.java:
##########
@@ -187,9 +187,7 @@ public void userEventTriggered(ChannelHandlerContext ctx, Object evt) throws Exc
heartBeat.setBody(heartBeatData);
ctx.channel().writeAndFlush(heartBeat)
.addListener(ChannelFutureListener.CLOSE_ON_FAILURE);
- if (logger.isDebugEnabled()) {
- logger.debug("Client send heart beat to: {}", ChannelUtils.getRemoteAddress(ctx.channel()));
- }
+ logger.debug("Client send heart beat to: {}", ChannelUtils.getRemoteAddress(ctx.channel()));
Review Comment:
In fact, I don't agree with remove `logger.isDebugEnabled` here, use `logger.debug` will need to calculate `ChannelUtils.getRemoteAddress(ctx.channel())` in each log, but in most of times we don't open debug, we don't need to calculate this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] fbjoker commented on pull request #12390: [Improvement-5918]Remove the code logger.isDebugEnabled()
Posted by GitBox <gi...@apache.org>.
fbjoker commented on PR #12390:
URL: https://github.com/apache/dolphinscheduler/pull/12390#issuecomment-1280117518
I don't know how to pass milestone-label-check
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] fuchanghai commented on pull request #12390: [Improvement-5918]Remove the code logger.isDebugEnabled()
Posted by GitBox <gi...@apache.org>.
fuchanghai commented on PR #12390:
URL: https://github.com/apache/dolphinscheduler/pull/12390#issuecomment-1280508301
please relation with issue
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] fbjoker commented on pull request #12390: [Improvement-5918]Remove the code logger.isDebugEnabled()
Posted by GitBox <gi...@apache.org>.
fbjoker commented on PR #12390:
URL: https://github.com/apache/dolphinscheduler/pull/12390#issuecomment-1280245889
yes, I don't know how to pass milestone-label-check, so I modified commite meage and resubmitted it，bug its also check fail. Can I cancel the submission
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org