You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2020/09/11 21:44:39 UTC
[GitHub] [beam] TheNeuralBit opened a new pull request #12830: [BEAM-10716] TestPubsub deletes subscriptions created in the same project
TheNeuralBit opened a new pull request #12830:
URL: https://github.com/apache/beam/pull/12830
Post-Commit Tests Status (on master branch)
------------------------------------------------------------------------------------------------
Lang | SDK | Dataflow | Flink | Samza | Spark | Twister2
--- | --- | --- | --- | --- | --- | ---
Go | [](https://ci-beam.apache.org/job/beam_PostCommit_Go/lastCompletedBuild/) | --- | [](https://ci-beam.apache.org/job/beam_PostCommit_Go_VR_Flink/lastCompletedBuild/) | --- | [](https://ci-beam.apache.org/job/beam_PostCommit_Go_VR_Spark/lastCompletedBuild/) | ---
Java | [](https://ci-beam.apache.org/job/beam_PostCommit_Java/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow_Java11/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink_Java11/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Java_PVR_Flink_Batch/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Java_PVR_Flink_Streaming/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Samza/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Spark/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Java_PVR_Spark_Batch/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_SparkStructuredStreaming/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Twister2/lastCompletedBuild/)
Python | [](https://ci-beam.apache.org/job/beam_PostCommit_Python2/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Python35/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Python36/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Python37/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Python38/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PostCommit_Py_VR_Dataflow/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Py_VR_Dataflow_V2/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Py_ValCont/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PreCommit_Python2_PVR_Flink_Cron/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Python35_VR_Flink/lastCompletedBuild/) | --- | [](https://ci-beam.apache.org/job/beam_PostCommit_Python_VR_Spark/lastCompletedBuild/) | ---
XLang | [](https://ci-beam.apache.org/job/beam_PostCommit_XVR_Direct/lastCompletedBuild/) | --- | [](https://ci-beam.apache.org/job/beam_PostCommit_XVR_Flink/lastCompletedBuild/) | --- | [](https://ci-beam.apache.org/job/beam_PostCommit_XVR_Spark/lastCompletedBuild/) | ---
Pre-Commit Tests Status (on master branch)
------------------------------------------------------------------------------------------------
--- |Java | Python | Go | Website | Whitespace | Typescript
--- | --- | --- | --- | --- | --- | ---
Non-portable | [](https://ci-beam.apache.org/job/beam_PreCommit_Java_Cron/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PreCommit_Python_Cron/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PreCommit_PythonLint_Cron/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PreCommit_PythonDocker_Cron/lastCompletedBuild/) <br>[](https://ci-beam.apache.org/job/beam_PreCommit_PythonDocs_Cron/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PreCommit_Go_Cron/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PreCommit_Website_Cron/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PreCommit_Whitespace_Cron/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PreCommit_Typescript_Cron/lastCompletedBuild/)
Portable | --- | [](https://ci-beam.apache.org/job/beam_PreCommit_Portable_Python_Cron/lastCompletedBuild/) | --- | --- | --- | ---
See [.test-infra/jenkins/README](https://github.com/apache/beam/blob/master/.test-infra/jenkins/README.md) for trigger phrase, status and link of all Jenkins jobs.
GitHub Actions Tests Status (on master branch)
------------------------------------------------------------------------------------------------
[](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] amaliujia commented on a change in pull request #12830: [BEAM-10716] TestPubsub/TestPubsubSignal clean up subscriptions
Posted by GitBox <gi...@apache.org>.
amaliujia commented on a change in pull request #12830:
URL: https://github.com/apache/beam/pull/12830#discussion_r492300048
##########
File path: sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/pubsub/TestPubsubSignal.java
##########
@@ -239,6 +245,12 @@ public void waitForSuccess(Duration duration) throws IOException {
String result = pollForResultForDuration(resultSubscriptionPath, duration);
+ try {
+ pubsub.deleteSubscription(resultSubscriptionPath);
+ } catch (IOException e) {
+ LOG.warn(String.format("Leaked PubSub subscription '%s'", resultSubscriptionPath));
Review comment:
nit: Will LOG.error make it easier to be discovered?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] TheNeuralBit commented on pull request #12830: [BEAM-10716] TestPubsub/TestPubsubSignal clean up subscriptions
Posted by GitBox <gi...@apache.org>.
TheNeuralBit commented on pull request #12830:
URL: https://github.com/apache/beam/pull/12830#issuecomment-696799563
Run Java PostCommit
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] TheNeuralBit merged pull request #12830: [BEAM-10716] TestPubsub/TestPubsubSignal clean up subscriptions
Posted by GitBox <gi...@apache.org>.
TheNeuralBit merged pull request #12830:
URL: https://github.com/apache/beam/pull/12830
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] TheNeuralBit commented on a change in pull request #12830: [BEAM-10716] TestPubsub/TestPubsubSignal clean up subscriptions
Posted by GitBox <gi...@apache.org>.
TheNeuralBit commented on a change in pull request #12830:
URL: https://github.com/apache/beam/pull/12830#discussion_r492339081
##########
File path: sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/pubsub/TestPubsubSignal.java
##########
@@ -239,6 +245,12 @@ public void waitForSuccess(Duration duration) throws IOException {
String result = pollForResultForDuration(resultSubscriptionPath, duration);
+ try {
+ pubsub.deleteSubscription(resultSubscriptionPath);
+ } catch (IOException e) {
+ LOG.warn(String.format("Leaked PubSub subscription '%s'", resultSubscriptionPath));
Review comment:
Good idea, done
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] TheNeuralBit commented on pull request #12830: [BEAM-10716] TestPubsub/TestPubsubSignal clean up subscriptions
Posted by GitBox <gi...@apache.org>.
TheNeuralBit commented on pull request #12830:
URL: https://github.com/apache/beam/pull/12830#issuecomment-697055532
Failure is an unrelated flake, discussed in BEAM-10871. There's a proposed fix in https://github.com/apache/beam/pull/12908. I'll go ahead and merge this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] TheNeuralBit commented on pull request #12830: [BEAM-10716] TestPubsub/TestPubsubSignal clean up subscriptions
Posted by GitBox <gi...@apache.org>.
TheNeuralBit commented on pull request #12830:
URL: https://github.com/apache/beam/pull/12830#issuecomment-691345067
Run SQL PostCommit
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] amaliujia commented on a change in pull request #12830: [BEAM-10716] TestPubsub/TestPubsubSignal clean up subscriptions
Posted by GitBox <gi...@apache.org>.
amaliujia commented on a change in pull request #12830:
URL: https://github.com/apache/beam/pull/12830#discussion_r492300048
##########
File path: sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/pubsub/TestPubsubSignal.java
##########
@@ -239,6 +245,12 @@ public void waitForSuccess(Duration duration) throws IOException {
String result = pollForResultForDuration(resultSubscriptionPath, duration);
+ try {
+ pubsub.deleteSubscription(resultSubscriptionPath);
+ } catch (IOException e) {
+ LOG.warn(String.format("Leaked PubSub subscription '%s'", resultSubscriptionPath));
Review comment:
nit: make error will make it easier to be discovered.
##########
File path: sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/pubsub/TestPubsubSignal.java
##########
@@ -239,6 +245,12 @@ public void waitForSuccess(Duration duration) throws IOException {
String result = pollForResultForDuration(resultSubscriptionPath, duration);
+ try {
+ pubsub.deleteSubscription(resultSubscriptionPath);
+ } catch (IOException e) {
+ LOG.warn(String.format("Leaked PubSub subscription '%s'", resultSubscriptionPath));
Review comment:
nit: Will LOG.error make it easier to be discovered?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] TheNeuralBit commented on pull request #12830: [BEAM-10716] TestPubsub/TestPubsubSignal clean up subscriptions
Posted by GitBox <gi...@apache.org>.
TheNeuralBit commented on pull request #12830:
URL: https://github.com/apache/beam/pull/12830#issuecomment-696369596
Run SQL PostCommit
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] amaliujia commented on a change in pull request #12830: [BEAM-10716] TestPubsub/TestPubsubSignal clean up subscriptions
Posted by GitBox <gi...@apache.org>.
amaliujia commented on a change in pull request #12830:
URL: https://github.com/apache/beam/pull/12830#discussion_r492300048
##########
File path: sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/pubsub/TestPubsubSignal.java
##########
@@ -239,6 +245,12 @@ public void waitForSuccess(Duration duration) throws IOException {
String result = pollForResultForDuration(resultSubscriptionPath, duration);
+ try {
+ pubsub.deleteSubscription(resultSubscriptionPath);
+ } catch (IOException e) {
+ LOG.warn(String.format("Leaked PubSub subscription '%s'", resultSubscriptionPath));
Review comment:
nit: make error will make it easier to be discovered.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] TheNeuralBit commented on a change in pull request #12830: [BEAM-10716] TestPubsub/TestPubsubSignal clean up subscriptions
Posted by GitBox <gi...@apache.org>.
TheNeuralBit commented on a change in pull request #12830:
URL: https://github.com/apache/beam/pull/12830#discussion_r492339081
##########
File path: sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/pubsub/TestPubsubSignal.java
##########
@@ -239,6 +245,12 @@ public void waitForSuccess(Duration duration) throws IOException {
String result = pollForResultForDuration(resultSubscriptionPath, duration);
+ try {
+ pubsub.deleteSubscription(resultSubscriptionPath);
+ } catch (IOException e) {
+ LOG.warn(String.format("Leaked PubSub subscription '%s'", resultSubscriptionPath));
Review comment:
Good idea, done
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] TheNeuralBit commented on pull request #12830: [BEAM-10716] TestPubsub/TestPubsubSignal clean up subscriptions
Posted by GitBox <gi...@apache.org>.
TheNeuralBit commented on pull request #12830:
URL: https://github.com/apache/beam/pull/12830#issuecomment-696369596
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] TheNeuralBit commented on pull request #12830: [BEAM-10716] TestPubsub/TestPubsubSignal clean up subscriptions
Posted by GitBox <gi...@apache.org>.
TheNeuralBit commented on pull request #12830:
URL: https://github.com/apache/beam/pull/12830#issuecomment-691345043
Run Java PostCommit
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] TheNeuralBit commented on pull request #12830: [BEAM-10716] TestPubsub/TestPubsubSignal clean up subscriptions
Posted by GitBox <gi...@apache.org>.
TheNeuralBit commented on pull request #12830:
URL: https://github.com/apache/beam/pull/12830#issuecomment-696369691
Run Java PostCommit
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] TheNeuralBit merged pull request #12830: [BEAM-10716] TestPubsub/TestPubsubSignal clean up subscriptions
Posted by GitBox <gi...@apache.org>.
TheNeuralBit merged pull request #12830:
URL: https://github.com/apache/beam/pull/12830
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] TheNeuralBit commented on pull request #12830: [BEAM-10716] TestPubsub/TestPubsubSignal clean up subscriptions
Posted by GitBox <gi...@apache.org>.
TheNeuralBit commented on pull request #12830:
URL: https://github.com/apache/beam/pull/12830#issuecomment-691345043
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] TheNeuralBit commented on pull request #12830: [BEAM-10716] TestPubsub/TestPubsubSignal clean up subscriptions
Posted by GitBox <gi...@apache.org>.
TheNeuralBit commented on pull request #12830:
URL: https://github.com/apache/beam/pull/12830#issuecomment-696999669
Run Java PostCommit
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] TheNeuralBit commented on a change in pull request #12830: [BEAM-10716] TestPubsub/TestPubsubSignal clean up subscriptions
Posted by GitBox <gi...@apache.org>.
TheNeuralBit commented on a change in pull request #12830:
URL: https://github.com/apache/beam/pull/12830#discussion_r492339081
##########
File path: sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/pubsub/TestPubsubSignal.java
##########
@@ -239,6 +245,12 @@ public void waitForSuccess(Duration duration) throws IOException {
String result = pollForResultForDuration(resultSubscriptionPath, duration);
+ try {
+ pubsub.deleteSubscription(resultSubscriptionPath);
+ } catch (IOException e) {
+ LOG.warn(String.format("Leaked PubSub subscription '%s'", resultSubscriptionPath));
Review comment:
Good idea, done
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] TheNeuralBit commented on pull request #12830: [BEAM-10716] TestPubsub/TestPubsubSignal clean up subscriptions
Posted by GitBox <gi...@apache.org>.
TheNeuralBit commented on pull request #12830:
URL: https://github.com/apache/beam/pull/12830#issuecomment-696369596
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] TheNeuralBit commented on pull request #12830: [BEAM-10716] TestPubsub/TestPubsubSignal clean up subscriptions
Posted by GitBox <gi...@apache.org>.
TheNeuralBit commented on pull request #12830:
URL: https://github.com/apache/beam/pull/12830#issuecomment-691345043
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org