[GitHub] [pulsar-client-reactive] cbornet commented on a diff in pull request #116: Add stopOnError option to ReactiveMessageSenderBuilder

["cbornet (via GitHub)" <gi...@apache.org>]

cbornet commented on code in PR #116:
URL: https://github.com/apache/pulsar-client-reactive/pull/116#discussion_r1089829526


##########
pulsar-client-reactive-api/src/main/java/org/apache/pulsar/reactive/client/api/ReactiveMessageSenderBuilder.java:
##########
@@ -71,6 +72,18 @@
 	 */
 	ReactiveMessageSenderBuilder<T> maxConcurrentSenderSubscriptions(int maxConcurrentSenderSubscriptions);
 
+	/**
+	 * Sets whether an error when sending an individual message of the
+	 * {@link ReactiveMessageSender#sendMany(Publisher)} operation should stop the full
+	 * stream or not. (default: false). If true, the original error is wrapped in a
+	 * {@link ReactiveMessageSendingException} and propagated downstream. If false, a
+	 * {@link MessageSendResult} is returned with the exception put in the
+	 * {@code Exception} field and a {@code null} {@link MessageId} field.
+	 * @param stopOnError true if the send stream should stop on error, false otherwise.
+	 * @return the sender builder instance
+	 */
+	ReactiveMessageSenderBuilder<T> stopOnError(boolean stopOnError);

Review Comment:
   Should this setting go in `ReactiveMessageSenderSpec` ?
   Same question about `cache`, `maxInflight`, `maxConcurrentSenderSubscriptions`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org