You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cordova.apache.org by "Shazron Abdullah (JIRA)" <ji...@apache.org> on 2015/11/26 22:45:11 UTC
[jira] [Comment Edited] (CB-10088) filetransfer spec.10 and spec.11
test is faulty
[ https://issues.apache.org/jira/browse/CB-10088?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15029262#comment-15029262 ]
Shazron Abdullah edited comment on CB-10088 at 11/26/15 9:44 PM:
-----------------------------------------------------------------
spec.11 is affected by this as well (when I fixed spec.10, the error because of the cache popped up for spec.11)
was (Author: shazron):
spec.11 is affected by this as well.
> filetransfer spec.10 and spec.11 test is faulty
> -----------------------------------------------
>
> Key: CB-10088
> URL: https://issues.apache.org/jira/browse/CB-10088
> Project: Apache Cordova
> Issue Type: Bug
> Components: Plugin File Transfer
> Environment: Xcode 7.1
> iOS 9.1 iPhone 6s
> Reporter: Shazron Abdullah
> Assignee: Shazron Abdullah
> Labels: iOS
>
> Copied from:
> https://issues.apache.org/jira/browse/CB-10082?focusedCommentId=15028283&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15028283
> This is within the context of mobile-spec's autotests.
> I added some logs in the native code, and cordova-filetransfer.tests spec.10's file "downloaded" within 30ms (probably because of caching). When calling abort, there is no active file transfer so the failure callback is not called back to JavaScript:
> https://github.com/apache/cordova-plugin-file-transfer/blob/887c91750a28d077976bd5340f9002ab2b569da6/src/ios/CDVFileTransfer.m#L380
> Since the failure callback is never called (the abort), and the the unexpected download success was called, the test fails.
> The test is faulty and needs to be reworked to take into account this case, where the download finished before the file could be aborted (the test delays the abort call).
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org