You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@yunikorn.apache.org by GitBox <gi...@apache.org> on 2021/09/13 21:20:21 UTC

[GitHub] [incubator-yunikorn-k8shim] yangwwei commented on a change in pull request #277: [YUNIKORN-641]: Add events for placeholder timeout to pod

yangwwei commented on a change in pull request #277:
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/277#discussion_r707689385



##########
File path: pkg/cache/application.go
##########
@@ -58,6 +58,7 @@ type Application struct {
 	placeholderAsk             *si.Resource // total placeholder request for the app (all task groups)
 	placeholderTimeoutInSec    int64
 	schedulingStyle            string
+	requestOriginatingPod      *v1.Pod // Original Pod which creates the requests

Review comment:
       Sorry, I do not agree to add this.
   My concern is such events may not help and even worse they may confuse users. 
   I prefer not to add this now until we have a better solution.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org