[GitHub] [spark] yaooqinn commented on a change in pull request #28165: [SPARK-31392][SQL] Support CalendarInterval to be reflect to CalendarntervalType

[GitBox <gi...@apache.org>]

yaooqinn commented on a change in pull request #28165: [SPARK-31392][SQL] Support CalendarInterval to be reflect to CalendarntervalType
URL: https://github.com/apache/spark/pull/28165#discussion_r406110875
 
 

 ##########
 File path: sql/core/src/test/scala/org/apache/spark/sql/execution/arrow/ArrowConvertersSuite.scala
 ##########
 @@ -1208,15 +1208,13 @@ class ArrowConvertersSuite extends SharedSparkSession {
     spark.conf.unset(SQLConf.ARROW_EXECUTION_MAX_RECORDS_PER_BATCH.key)
   }
 
-  testQuietly("unsupported types") {
 
 Review comment:
   This test case is modified because:
   1. the original test case did not match the intention which was to test `ArrowConverter` with calling and failing `ArrowUtils.toArrowType` but failed earlier in `SchemaReflection` actually.
   2. interval is the only type that is unsupported by arrow
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org