You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Csaba Ringhofer (Code Review)" <ge...@cloudera.org> on 2019/07/25 19:13:46 UTC
[Impala-ASF-CR] IMPALA-8585: Skip most ACID EE tests in non-HDFS builds
Csaba Ringhofer has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13921
Change subject: IMPALA-8585: Skip most ACID EE tests in non-HDFS builds
......................................................................
IMPALA-8585: Skip most ACID EE tests in non-HDFS builds
Currently these tests rely on Hive to insert data into ACID tables (+ also compaction
in some cases), which fails on non-HDFS filesystems (e.g. S3).
Change-Id: I5f67654805b770d86090b0d1015e144147d73f40
---
M tests/query_test/test_acid.py
1 file changed, 22 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/21/13921/1
--
To view, visit http://gerrit.cloudera.org:8080/13921
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I5f67654805b770d86090b0d1015e144147d73f40
Gerrit-Change-Number: 13921
Gerrit-PatchSet: 1
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
[Impala-ASF-CR] IMPALA-8585: Skip most ACID EE tests in non-HDFS builds
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13921 )
Change subject: IMPALA-8585: Skip most ACID EE tests in non-HDFS builds
......................................................................
Patch Set 3: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/13921
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5f67654805b770d86090b0d1015e144147d73f40
Gerrit-Change-Number: 13921
Gerrit-PatchSet: 3
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Fri, 26 Jul 2019 16:19:26 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8585: Skip most ACID EE tests in non-HDFS builds
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13921 )
Change subject: IMPALA-8585: Skip most ACID EE tests in non-HDFS builds
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/4002/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/13921
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5f67654805b770d86090b0d1015e144147d73f40
Gerrit-Change-Number: 13921
Gerrit-PatchSet: 1
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Thu, 25 Jul 2019 19:56:05 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8585: Skip most ACID EE tests in non-HDFS builds
Posted by "Csaba Ringhofer (Code Review)" <ge...@cloudera.org>.
Hello Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/13921
to look at the new patch set (#2).
Change subject: IMPALA-8585: Skip most ACID EE tests in non-HDFS builds
......................................................................
IMPALA-8585: Skip most ACID EE tests in non-HDFS builds
Currently these tests rely on Hive to insert data into ACID tables
(+ also compaction in some cases), which fails on non-HDFS filesystems
(e.g. S3).
Change-Id: I5f67654805b770d86090b0d1015e144147d73f40
---
M tests/query_test/test_acid.py
1 file changed, 22 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/21/13921/2
--
To view, visit http://gerrit.cloudera.org:8080/13921
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I5f67654805b770d86090b0d1015e144147d73f40
Gerrit-Change-Number: 13921
Gerrit-PatchSet: 2
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
[Impala-ASF-CR] IMPALA-8585: Skip most ACID EE tests in non-HDFS builds
Posted by "Gabor Kaszab (Code Review)" <ge...@cloudera.org>.
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/13921 )
Change subject: IMPALA-8585: Skip most ACID EE tests in non-HDFS builds
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/13921
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5f67654805b770d86090b0d1015e144147d73f40
Gerrit-Change-Number: 13921
Gerrit-PatchSet: 2
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Fri, 26 Jul 2019 06:36:27 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8585: Skip most ACID EE tests in non-HDFS builds
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13921 )
Change subject: IMPALA-8585: Skip most ACID EE tests in non-HDFS builds
......................................................................
Patch Set 3:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/4662/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/13921
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5f67654805b770d86090b0d1015e144147d73f40
Gerrit-Change-Number: 13921
Gerrit-PatchSet: 3
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Fri, 26 Jul 2019 09:50:38 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8585: Skip most ACID EE tests in non-HDFS builds
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13921 )
Change subject: IMPALA-8585: Skip most ACID EE tests in non-HDFS builds
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/13921
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5f67654805b770d86090b0d1015e144147d73f40
Gerrit-Change-Number: 13921
Gerrit-PatchSet: 3
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Fri, 26 Jul 2019 09:50:37 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8585: Skip most ACID EE tests in non-HDFS builds
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13921 )
Change subject: IMPALA-8585: Skip most ACID EE tests in non-HDFS builds
......................................................................
IMPALA-8585: Skip most ACID EE tests in non-HDFS builds
Currently these tests rely on Hive to insert data into ACID tables
(+ also compaction in some cases), which fails on non-HDFS filesystems
(e.g. S3).
Change-Id: I5f67654805b770d86090b0d1015e144147d73f40
Reviewed-on: http://gerrit.cloudera.org:8080/13921
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M tests/query_test/test_acid.py
1 file changed, 22 insertions(+), 1 deletion(-)
Approvals:
Impala Public Jenkins: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/13921
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I5f67654805b770d86090b0d1015e144147d73f40
Gerrit-Change-Number: 13921
Gerrit-PatchSet: 4
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>