You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/12/31 02:06:13 UTC

[GitHub] [spark] brucezhao11 commented on issue #21929: [SPARK-24970][Kinesis] Create WriteAheadLogBackedBlockRDD for Kinesis Streaming if WAL is enabled.

brucezhao11 commented on issue #21929: [SPARK-24970][Kinesis] Create WriteAheadLogBackedBlockRDD for Kinesis Streaming if WAL is enabled.
URL: https://github.com/apache/spark/pull/21929#issuecomment-569847863
 
 
   I'd like to CLOSE this pull request as it's there for a long long time. Conclusions as below.
   
   1. We checked in Spark 2.2 and 2.3, this fix works smoothly in production. 
   2. One side effect we confirmed is this fix will cause graceful shutdown invalid. Because WAL manager is stopped before JobGenerator exits in graceful shutdown. In our case, we use blue-green deployment instead of graceful shutdown. 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org