You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2021/11/17 08:55:02 UTC

[GitHub] [beam] mosche edited a comment on pull request #15955: [BEAM-13236] Properly close kinesis producer on teardown

mosche edited a comment on pull request #15955:
URL: https://github.com/apache/beam/pull/15955#issuecomment-971364866


   Actually, this is more broken than I thought. Closing the PR for now.
   
   Per JVM a producer is shared among all `KinesisWriterFn`s. Sharing producers absolutely makes sense, nevertheless this absolutely leaks. On teardown the shared(!) producer reference is unset, though it might still be required by another unfinished bundle running on the same JVM.
   
   Also, if the static instance is reused, producer properties might be silently dropped without notice.
   ```
         private static transient IKinesisProducer producer;
   ```
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org