You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jackrabbit.apache.org by "Julian Reschke (JIRA)" <ji...@apache.org> on 2008/03/25 17:01:26 UTC
[jira] Created: (JCR-1500) removing properties through SPI: two
ways to do it
removing properties through SPI: two ways to do it
--------------------------------------------------
Key: JCR-1500
URL: https://issues.apache.org/jira/browse/JCR-1500
Project: Jackrabbit
Issue Type: Improvement
Components: jackrabbit-spi
Reporter: Julian Reschke
Priority: Minor
Batch currently provides two ways to delete a property, similarly to JCR:
- Batch.remove()
- Batch.setValue(..., null)
JCR2SPI currently uses (AFAIK) Batch.remove().
Proposal:
- clarify that the QValue argument in setValue must be non-null (same for setValues)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (JCR-1500) removing properties through SPI: two
ways to do it
Posted by "Jukka Zitting (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JCR-1500?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jukka Zitting updated JCR-1500:
-------------------------------
Fix Version/s: 1.5.0
> removing properties through SPI: two ways to do it
> --------------------------------------------------
>
> Key: JCR-1500
> URL: https://issues.apache.org/jira/browse/JCR-1500
> Project: Jackrabbit
> Issue Type: Improvement
> Components: jackrabbit-spi
> Reporter: Julian Reschke
> Assignee: angela
> Priority: Minor
> Fix For: 1.5.0
>
>
> Batch currently provides two ways to delete a property, similarly to JCR:
> - Batch.remove()
> - Batch.setValue(..., null)
> JCR2SPI currently uses (AFAIK) Batch.remove().
> Proposal:
> - clarify that the QValue argument in setValue must be non-null (same for setValues)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (JCR-1500) removing properties through SPI: two
ways to do it
Posted by "angela (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JCR-1500?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
angela resolved JCR-1500.
-------------------------
Resolution: Fixed
Assignee: angela
extended javadoc explicitly stating that setValue/setValues differs from the corresponding
jcr-calls and are only intended for modification of a property. Batch#remove is to be used for removal.
completed at revision: 649419
> removing properties through SPI: two ways to do it
> --------------------------------------------------
>
> Key: JCR-1500
> URL: https://issues.apache.org/jira/browse/JCR-1500
> Project: Jackrabbit
> Issue Type: Improvement
> Components: jackrabbit-spi
> Reporter: Julian Reschke
> Assignee: angela
> Priority: Minor
>
> Batch currently provides two ways to delete a property, similarly to JCR:
> - Batch.remove()
> - Batch.setValue(..., null)
> JCR2SPI currently uses (AFAIK) Batch.remove().
> Proposal:
> - clarify that the QValue argument in setValue must be non-null (same for setValues)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (JCR-1500) removing properties through SPI: two
ways to do it
Posted by "Marcel Reutegger (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JCR-1500?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12582194#action_12582194 ]
Marcel Reutegger commented on JCR-1500:
---------------------------------------
I agree, there should only be one way of doing this.
> removing properties through SPI: two ways to do it
> --------------------------------------------------
>
> Key: JCR-1500
> URL: https://issues.apache.org/jira/browse/JCR-1500
> Project: Jackrabbit
> Issue Type: Improvement
> Components: jackrabbit-spi
> Reporter: Julian Reschke
> Priority: Minor
>
> Batch currently provides two ways to delete a property, similarly to JCR:
> - Batch.remove()
> - Batch.setValue(..., null)
> JCR2SPI currently uses (AFAIK) Batch.remove().
> Proposal:
> - clarify that the QValue argument in setValue must be non-null (same for setValues)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (JCR-1500) removing properties through SPI: two
ways to do it
Posted by "angela (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JCR-1500?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12582204#action_12582204 ]
angela commented on JCR-1500:
-----------------------------
and so do I.
the Batch currently does not specify that there a multiple ways to remove a property... but it insinuates this usage by not explicitely mentioning the expected behaviour and by refering to the corresponding jcr methods.
Let's clarify that in the javadoc and adjust the current implementations if necessary.
> removing properties through SPI: two ways to do it
> --------------------------------------------------
>
> Key: JCR-1500
> URL: https://issues.apache.org/jira/browse/JCR-1500
> Project: Jackrabbit
> Issue Type: Improvement
> Components: jackrabbit-spi
> Reporter: Julian Reschke
> Priority: Minor
>
> Batch currently provides two ways to delete a property, similarly to JCR:
> - Batch.remove()
> - Batch.setValue(..., null)
> JCR2SPI currently uses (AFAIK) Batch.remove().
> Proposal:
> - clarify that the QValue argument in setValue must be non-null (same for setValues)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.