[GitHub] [hadoop] goiri commented on a diff in pull request #5181: HDFS-16859. RBF: Move LOG.debug into if condition acquirePermit

[GitBox <gi...@apache.org>]

goiri commented on code in PR #5181:
URL: https://github.com/apache/hadoop/pull/5181#discussion_r1038436246


##########
hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/fairness/AbstractRouterRpcFairnessPolicyController.java:
##########
@@ -63,10 +63,14 @@ public void init(Configuration conf) {
   @Override
   public boolean acquirePermit(String nsId) {
     try {
-      LOG.debug("Taking lock for nameservice {}", nsId);
+      if (LOG.isDebugEnabled()) {
+        LOG.debug("Taking lock for nameservice {}", nsId);

Review Comment:
   We have gone through this in the past.
   LOG.debug with {} should already be equivalent to adding the safeguard.
   
   Do you have some instrumentation showing that `LOG.isDebugEnabled()` is cheaper than just calling `LOG.debug()`?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org