[GitHub] khos2ow commented on a change in pull request #2628: Create upgrade path from 4.9.3.1 to 4.11.1.0

[GitBox <gi...@apache.org>]

khos2ow commented on a change in pull request #2628: Create upgrade path from 4.9.3.1 to 4.11.1.0
URL: https://github.com/apache/cloudstack/pull/2628#discussion_r186452180
 
 

 ##########
 File path: engine/schema/src/com/cloud/upgrade/DatabaseUpgradeChecker.java
 ##########
 @@ -408,6 +408,9 @@ public DatabaseUpgradeChecker() {
         _upgradeMap.put(CloudStackVersion.parse("4.9.3.0"),
             new DbUpgrade[] {new Upgrade4930to41000(), new Upgrade41000to41100(), new Upgrade41100to41110()});
 
+        _upgradeMap.put(CloudStackVersion.parse("4.9.3.1"),
+                new DbUpgrade[] {new Upgrade4930to41000(), new Upgrade41000to41100(), new Upgrade41100to41110()});
 
 Review comment:
   It might not be needed, but it would surely help reading the code and understanding upgrade path easier, specially when we move forward with #2584 , then we wouldn't see duplicate (and redundant) upgrade path. I would suggest to rename java and sql `4930to49100` files to `4930to4931` and create new/empty `4931to49100`.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services