You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@weex.apache.org by erha19 <gi...@git.apache.org> on 2017/06/30 08:43:55 UTC
[GitHub] incubator-weex pull request #484: [html5] Improve the unit test case
GitHub user erha19 opened a pull request:
https://github.com/apache/incubator-weex/pull/484
[html5] Improve the unit test case
Changes：
- Increased webSocket unit test coverage.
- Add unit test for modal module.
- Edit karma.vue.config.js to suit the test scenario.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/erha19/incubator-weex 0.15-dev
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-weex/pull/484.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #484
----
commit d804e1f6f2653f3299cbc00c5a883acc3048833f
Author: erha19 <fa...@gmail.com>
Date: 2017-06-27T08:17:50Z
* [html5] while url argument equal false websocket instance need set to be null
commit 7bfa9438f7fb0d967ffb9871151565d6a0ecfc3b
Author: erha19 <fa...@gmail.com>
Date: 2017-06-27T08:18:24Z
* [html5] modify websocket unit test code.
commit b92bc68834b8dd1b1dc3cd836a4cb786bbc44468
Author: erha19 <fa...@gmail.com>
Date: 2017-06-28T09:03:24Z
* [html5] fix websocket unit test.
commit 9fe6eb0b7a9ea61dbf75adcbc86634fd11d11057
Author: erha19 <fa...@gmail.com>
Date: 2017-06-28T09:04:27Z
+ [html5] add nodeListToArray method for transform domlist to array list
commit 8295abc94790661918945784de828ce1bf60cd3e
Author: erha19 <fa...@gmail.com>
Date: 2017-06-28T09:04:52Z
+ [html5] add modal module unit test
commit 60f9c1d25bbbabf17ec76f9d4d12fcf72ebc0827
Author: erha19 <fa...@gmail.com>
Date: 2017-06-29T09:09:20Z
* [html5] fix webSocket unit test code
commit 3fe2ff050b1e04bd40bae1c8be2c6fb618ad045c
Author: erha19 <fa...@gmail.com>
Date: 2017-06-30T08:11:43Z
* [html5] change karma config to suit the test scenario
commit da75a60fa7e96fcedf88860d567fd4768721018d
Author: erha19 <fa...@gmail.com>
Date: 2017-06-30T08:31:49Z
Merge branch '0.14-dev' of https://github.com/apache/incubator-weex into 0.14-dev
commit 68875def1daf0083f4f09bcaa75c1522de093bab
Author: erha19 <fa...@gmail.com>
Date: 2017-06-30T08:38:55Z
Merge branch '0.15-dev' of https://github.com/apache/incubator-weex into 0.15-dev
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-weex issue #484: [html5] Improve the unit test case
Posted by weex-bot <gi...@git.apache.org>.
Github user weex-bot commented on the issue:
https://github.com/apache/incubator-weex/pull/484
<!--
0 failure:
3 warning: No Changelog chan..., These new JS file..., This PR should up...
1 messages
-->
<table>
<thead>
<tr>
<th width="50"></th>
<th width="100%" data-danger-table="true">Warnings</th>
</tr>
</thead>
<tbody><tr>
<td>:warning:</td>
<td>No Changelog changes!</td>
</tr>
<tr>
<td>:warning:</td>
<td>These new JS files do not have Flow enabled: html5/test/render/vue/modules/modal.js</td>
</tr>
<tr>
<td>:warning:</td>
<td>This PR should update related documents as well. </td>
</tr>
</tbody>
</table>
<table>
<thead>
<tr>
<th width="50"></th>
<th width="100%" data-danger-table="true">Messages</th>
</tr>
</thead>
<tbody><tr>
<td>:book:</td>
<td>According to the blame info, we recommended @MrRaindrop , @Hanks10100 to be the reviewers.</td>
</tr>
</tbody>
</table>
<p align="right">
Generated by :no_entry_sign: <a href="http://github.com/danger/danger-js/">dangerJS</a>
</p>
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-weex pull request #484: [html5] Improve the unit test case
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-weex/pull/484
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---