[jira] Commented: (HAMA-169) The start location can be different between the two vectors

["Hudson (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HAMA-169?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12681228#action_12681228 ] 

Hudson commented on HAMA-169:
-----------------------------

+1 overall.  Here are the results of testing the latest attachment 
http://issues.apache.org/jira/secure/attachment/12402024/HAMA-169.patch
against trunk revision 752381.

    @author +1.  The patch does not contain any @author tags.

    tests included +1.  The patch appears to include 3 new or modified tests.

    javadoc +1.  The javadoc tool did not generate any warning messages.

    javac +1.  The applied patch does not generate any new javac compiler warnings.

    release audit +1.  The applied patch does not generate any new release audit warnings.

    findbugs +1.  The patch does not introduce any new Findbugs warnings.

    core tests +1.  The patch passed core unit tests.

Test results: http://hudson.zones.apache.org/hudson/job/Hama-Patch/165/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hama-Patch/165/artifact/trunk/build/reports/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hama-Patch/165/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hama-Patch/165/console

This message is automatically generated.

> The start location can be different between the two vectors
> -----------------------------------------------------------
>
>                 Key: HAMA-169
>                 URL: https://issues.apache.org/jira/browse/HAMA-169
>             Project: Hama
>          Issue Type: Bug
>          Components: implementation
>    Affects Versions: 0.1.0
>            Reporter: Edward J. Yoon
>            Assignee: Edward J. Yoon
>            Priority: Critical
>             Fix For: 0.1.0
>
>         Attachments: HAMA-169.patch
>
>
> The start location can be different between the two vectors.
> Then, 
> DenseVector add(double alpha, Vector v)
>     for (int i = 0; i < this.size(); i++) {
>       set(i, alpha * v.get(i) + get(i));
>     }
> This code will do not anything.
> DenseMatrix.setColumn(Vector v) also should be fixed.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.