You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/08/18 19:11:09 UTC
[GitHub] [arrow-datafusion] alamb opened a new pull request, #3196: Clean up CI workflows by removing "matrix" strategy, simplifying names
alamb opened a new pull request, #3196:
URL: https://github.com/apache/arrow-datafusion/pull/3196
# Which issue does this PR close?
Next installment of https://github.com/apache/arrow-datafusion/issues/3045
# Rationale for this change
The CI checks make use of the 'matrix' strategy (see [docs](https://docs.github.com/en/actions/using-jobs/using-a-matrix-for-your-jobs)) but have only one matrix combination. This makes them overly confusing.
As part of cleaning up the DataFusion CI I am first pruning out unnecessary complexity first
# What changes are included in this PR?
1. Remove matrix strategy config for jobs that have a single combination
2. Rename the jobs to be consistent
# Are there any user-facing changes?
No
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb commented on a diff in pull request #3196: Clean up CI workflows by removing "matrix" strategy, simplifying names
Posted by GitBox <gi...@apache.org>.
alamb commented on code in PR #3196:
URL: https://github.com/apache/arrow-datafusion/pull/3196#discussion_r950707687
##########
.github/workflows/rust.yml:
##########
@@ -395,8 +364,8 @@ jobs:
key: ${{ runner.os }}-cargo-miri-${{ hashFiles('**/Cargo.lock') }}
- name: Setup Rust toolchain
run: |
- rustup toolchain install ${{ matrix.rust }}
- rustup default ${{ matrix.rust }}
+ rustup toolchain install nightly-2022-01-17
Review Comment:
I think we probably pinned the version a while ago when some nightly had issues. I think updating it would be a great idea (and as you say a good follow on PR)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] jackwener commented on a diff in pull request #3196: Clean up CI workflows by removing "matrix" strategy, simplifying names
Posted by GitBox <gi...@apache.org>.
jackwener commented on code in PR #3196:
URL: https://github.com/apache/arrow-datafusion/pull/3196#discussion_r950701600
##########
.github/workflows/rust.yml:
##########
@@ -395,8 +364,8 @@ jobs:
key: ${{ runner.os }}-cargo-miri-${{ hashFiles('**/Cargo.lock') }}
- name: Setup Rust toolchain
run: |
- rustup toolchain install ${{ matrix.rust }}
- rustup default ${{ matrix.rust }}
+ rustup toolchain install nightly-2022-01-17
Review Comment:
why use this version？
Is there a possibility that this version needs to be updated later?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] ursabot commented on pull request #3196: Clean up CI workflows by removing "matrix" strategy, simplifying names
Posted by GitBox <gi...@apache.org>.
ursabot commented on PR #3196:
URL: https://github.com/apache/arrow-datafusion/pull/3196#issuecomment-1221522681
Benchmark runs are scheduled for baseline = 72487cfb0305f1d3c40d179ba963d73d57a79d48 and contender = 4838564d868243567df6b4ed19751a3da287e777. 4838564d868243567df6b4ed19751a3da287e777 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on ec2-t3-xlarge-us-east-2] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/09be4a014c234d8183b7cbf359b588be...693b88434c4744b18e9d365747fabe0c/)
[Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on test-mac-arm] [test-mac-arm](https://conbench.ursa.dev/compare/runs/12230b8214844b9693adddd21f0e6b3c...c7cda64ab60740cbb7f83b066437838e/)
[Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on ursa-i9-9960x] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/338595a854604979ab21b72d0dfb87cb...1e75fd027c184743846cde4d704926c0/)
[Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on ursa-thinkcentre-m75q] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/d13456bdd2cd47f7a15d5592862c8281...04ded4b7b80a40b383cfc429cc65962f/)
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] codecov-commenter commented on pull request #3196: Clean up CI workflows by removing "matrix" strategy, simplifying names
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #3196:
URL: https://github.com/apache/arrow-datafusion/pull/3196#issuecomment-1220021406
# [Codecov](https://codecov.io/gh/apache/arrow-datafusion/pull/3196?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#3196](https://codecov.io/gh/apache/arrow-datafusion/pull/3196?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (5d11f51) into [master](https://codecov.io/gh/apache/arrow-datafusion/commit/929eb6d860fb60ba994b24397ad3c3eb7d839cdf?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (929eb6d) will **decrease** coverage by `0.00%`.
> The diff coverage is `n/a`.
> :exclamation: Current head 5d11f51 differs from pull request most recent head ca349a4. Consider uploading reports for the commit ca349a4 to get more accurate results
```diff
@@ Coverage Diff @@
## master #3196 +/- ##
==========================================
- Coverage 85.87% 85.87% -0.01%
==========================================
Files 291 291
Lines 52885 52885
==========================================
- Hits 45415 45414 -1
- Misses 7470 7471 +1
```
| [Impacted Files](https://codecov.io/gh/apache/arrow-datafusion/pull/3196?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [datafusion/expr/src/logical\_plan/plan.rs](https://codecov.io/gh/apache/arrow-datafusion/pull/3196/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGF0YWZ1c2lvbi9leHByL3NyYy9sb2dpY2FsX3BsYW4vcGxhbi5ycw==) | `77.60% <0.00%> (-0.18%)` | :arrow_down: |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb commented on a diff in pull request #3196: Clean up CI workflows by removing "matrix" strategy, simplifying names
Posted by GitBox <gi...@apache.org>.
alamb commented on code in PR #3196:
URL: https://github.com/apache/arrow-datafusion/pull/3196#discussion_r950826777
##########
.github/workflows/rust.yml:
##########
@@ -395,8 +364,8 @@ jobs:
key: ${{ runner.os }}-cargo-miri-${{ hashFiles('**/Cargo.lock') }}
- name: Setup Rust toolchain
run: |
- rustup toolchain install ${{ matrix.rust }}
- rustup default ${{ matrix.rust }}
+ rustup toolchain install nightly-2022-01-17
Review Comment:
Follow on PR: https://github.com/apache/arrow-datafusion/pull/3215 (will need some work)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb merged pull request #3196: Clean up CI workflows by removing "matrix" strategy, simplifying names
Posted by GitBox <gi...@apache.org>.
alamb merged PR #3196:
URL: https://github.com/apache/arrow-datafusion/pull/3196
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org