You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@karaf.apache.org by GitBox <gi...@apache.org> on 2022/10/12 14:40:49 UTC
[GitHub] [karaf] tapiiron opened a new pull request, #1648: Commonly used com.sun.jndi.ldap into exports
tapiiron opened a new pull request, #1648:
URL: https://github.com/apache/karaf/pull/1648
When using javax.naming we commonly use com.sun.jndi.ldap and it should be in add-exports by default
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@karaf.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [karaf] tapiiron commented on a diff in pull request #1648: Commonly used com.sun.jndi.ldap into exports
Posted by GitBox <gi...@apache.org>.
tapiiron commented on code in PR #1648:
URL: https://github.com/apache/karaf/pull/1648#discussion_r994158091
##########
assemblies/features/base/src/main/filtered-resources/resources/bin/karaf:
##########
@@ -322,6 +322,7 @@ run() {
--add-exports=jdk.naming.rmi/com.sun.jndi.url.rmi=ALL-UNNAMED \
--add-exports=java.rmi/sun.rmi.registry=ALL-UNNAMED \
--add-exports=java.security.sasl/com.sun.security.sasl=ALL-UNNAMED \
+ --add-exports=java.naming/com.sun.jndi.ldap=ALL-UNNAMED \
Review Comment:
Oh, misunderstood. OpenJDK is JDK provider. Background: upgrade from java11 to java17 created an issue with camel-ldap -component in karaf container. Found out that com.sun.jndi.ldap was not exported by default.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@karaf.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [karaf] tapiiron commented on a diff in pull request #1648: Commonly used com.sun.jndi.ldap into exports
Posted by GitBox <gi...@apache.org>.
tapiiron commented on code in PR #1648:
URL: https://github.com/apache/karaf/pull/1648#discussion_r993596014
##########
assemblies/features/base/src/main/filtered-resources/resources/bin/karaf:
##########
@@ -322,6 +322,7 @@ run() {
--add-exports=jdk.naming.rmi/com.sun.jndi.url.rmi=ALL-UNNAMED \
--add-exports=java.rmi/sun.rmi.registry=ALL-UNNAMED \
--add-exports=java.security.sasl/com.sun.security.sasl=ALL-UNNAMED \
+ --add-exports=java.naming/com.sun.jndi.ldap=ALL-UNNAMED \
Review Comment:
This is related on java 9 above
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@karaf.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [karaf] jbonofre commented on a diff in pull request #1648: Commonly used com.sun.jndi.ldap into exports
Posted by GitBox <gi...@apache.org>.
jbonofre commented on code in PR #1648:
URL: https://github.com/apache/karaf/pull/1648#discussion_r994208150
##########
assemblies/features/base/src/main/filtered-resources/resources/bin/karaf:
##########
@@ -322,6 +322,7 @@ run() {
--add-exports=jdk.naming.rmi/com.sun.jndi.url.rmi=ALL-UNNAMED \
--add-exports=java.rmi/sun.rmi.registry=ALL-UNNAMED \
--add-exports=java.security.sasl/com.sun.security.sasl=ALL-UNNAMED \
+ --add-exports=java.naming/com.sun.jndi.ldap=ALL-UNNAMED \
Review Comment:
OK, fair enough. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@karaf.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [karaf] tapiiron commented on pull request #1648: Commonly used com.sun.jndi.ldap into exports
Posted by GitBox <gi...@apache.org>.
tapiiron commented on PR #1648:
URL: https://github.com/apache/karaf/pull/1648#issuecomment-1276339345
This is related on java 9 above
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@karaf.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [karaf] jbonofre commented on a diff in pull request #1648: Commonly used com.sun.jndi.ldap into exports
Posted by GitBox <gi...@apache.org>.
jbonofre commented on code in PR #1648:
URL: https://github.com/apache/karaf/pull/1648#discussion_r993674413
##########
assemblies/features/base/src/main/filtered-resources/resources/bin/karaf:
##########
@@ -322,6 +322,7 @@ run() {
--add-exports=jdk.naming.rmi/com.sun.jndi.url.rmi=ALL-UNNAMED \
--add-exports=java.rmi/sun.rmi.registry=ALL-UNNAMED \
--add-exports=java.security.sasl/com.sun.security.sasl=ALL-UNNAMED \
+ --add-exports=java.naming/com.sun.jndi.ldap=ALL-UNNAMED \
Review Comment:
This change should be added to the wrapper configuration as well. Can you please include it ? I can do it for you if you prefer.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@karaf.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [karaf] jbonofre commented on a diff in pull request #1648: Commonly used com.sun.jndi.ldap into exports
Posted by GitBox <gi...@apache.org>.
jbonofre commented on code in PR #1648:
URL: https://github.com/apache/karaf/pull/1648#discussion_r994208376
##########
assemblies/features/base/src/main/filtered-resources/resources/bin/karaf:
##########
@@ -322,6 +322,7 @@ run() {
--add-exports=jdk.naming.rmi/com.sun.jndi.url.rmi=ALL-UNNAMED \
--add-exports=java.rmi/sun.rmi.registry=ALL-UNNAMED \
--add-exports=java.security.sasl/com.sun.security.sasl=ALL-UNNAMED \
+ --add-exports=java.naming/com.sun.jndi.ldap=ALL-UNNAMED \
Review Comment:
Awesome, thanks ! I will review, squash and merge.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@karaf.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [karaf] tapiiron commented on a diff in pull request #1648: Commonly used com.sun.jndi.ldap into exports
Posted by GitBox <gi...@apache.org>.
tapiiron commented on code in PR #1648:
URL: https://github.com/apache/karaf/pull/1648#discussion_r994158300
##########
assemblies/features/base/src/main/filtered-resources/resources/bin/karaf:
##########
@@ -322,6 +322,7 @@ run() {
--add-exports=jdk.naming.rmi/com.sun.jndi.url.rmi=ALL-UNNAMED \
--add-exports=java.rmi/sun.rmi.registry=ALL-UNNAMED \
--add-exports=java.security.sasl/com.sun.security.sasl=ALL-UNNAMED \
+ --add-exports=java.naming/com.sun.jndi.ldap=ALL-UNNAMED \
Review Comment:
added to windows and windows64 wrappers also + karaf.bat
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@karaf.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [karaf] jbonofre commented on pull request #1648: Commonly used com.sun.jndi.ldap into exports
Posted by GitBox <gi...@apache.org>.
jbonofre commented on PR #1648:
URL: https://github.com/apache/karaf/pull/1648#issuecomment-1276424892
@tapiiron my point is not about JDK version, it's more the JDK provider, between Adoptium/OpenJDK/Oracle/IBM.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@karaf.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [karaf] tapiiron commented on a diff in pull request #1648: Commonly used com.sun.jndi.ldap into exports
Posted by GitBox <gi...@apache.org>.
tapiiron commented on code in PR #1648:
URL: https://github.com/apache/karaf/pull/1648#discussion_r993739162
##########
assemblies/features/base/src/main/filtered-resources/resources/bin/karaf:
##########
@@ -322,6 +322,7 @@ run() {
--add-exports=jdk.naming.rmi/com.sun.jndi.url.rmi=ALL-UNNAMED \
--add-exports=java.rmi/sun.rmi.registry=ALL-UNNAMED \
--add-exports=java.security.sasl/com.sun.security.sasl=ALL-UNNAMED \
+ --add-exports=java.naming/com.sun.jndi.ldap=ALL-UNNAMED \
Review Comment:
Added this to unix wrapper configuration.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@karaf.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [karaf] jbonofre commented on a diff in pull request #1648: Commonly used com.sun.jndi.ldap into exports
Posted by GitBox <gi...@apache.org>.
jbonofre commented on code in PR #1648:
URL: https://github.com/apache/karaf/pull/1648#discussion_r993586196
##########
assemblies/features/base/src/main/filtered-resources/resources/bin/karaf:
##########
@@ -322,6 +322,7 @@ run() {
--add-exports=jdk.naming.rmi/com.sun.jndi.url.rmi=ALL-UNNAMED \
--add-exports=java.rmi/sun.rmi.registry=ALL-UNNAMED \
--add-exports=java.security.sasl/com.sun.security.sasl=ALL-UNNAMED \
+ --add-exports=java.naming/com.sun.jndi.ldap=ALL-UNNAMED \
Review Comment:
Is it valid for any JDK ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@karaf.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [karaf] jbonofre commented on a diff in pull request #1648: Commonly used com.sun.jndi.ldap into exports
Posted by GitBox <gi...@apache.org>.
jbonofre commented on code in PR #1648:
URL: https://github.com/apache/karaf/pull/1648#discussion_r993673852
##########
assemblies/features/base/src/main/filtered-resources/resources/bin/karaf:
##########
@@ -322,6 +322,7 @@ run() {
--add-exports=jdk.naming.rmi/com.sun.jndi.url.rmi=ALL-UNNAMED \
--add-exports=java.rmi/sun.rmi.registry=ALL-UNNAMED \
--add-exports=java.security.sasl/com.sun.security.sasl=ALL-UNNAMED \
+ --add-exports=java.naming/com.sun.jndi.ldap=ALL-UNNAMED \
Review Comment:
my point is not about JDK version, it's more the JDK provider, between Adoptium/OpenJDK/Oracle/IBM. As it's command line argument, it's OK, just wondering ;)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@karaf.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [karaf] asfgit closed pull request #1648: Commonly used com.sun.jndi.ldap into exports
Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #1648: Commonly used com.sun.jndi.ldap into exports
URL: https://github.com/apache/karaf/pull/1648
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@karaf.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org