You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@dubbo.apache.org by "codecov-io (GitHub)" <gi...@apache.org> on 2019/11/26 14:07:39 UTC

[GitHub] [dubbo-go] codecov-io commented on issue #266: should return error when `NewURL` failed.

# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/266?src=pr&el=h1) Report
> Merging [#266](https://codecov.io/gh/apache/dubbo-go/pull/266?src=pr&el=desc) into [master](https://codecov.io/gh/apache/dubbo-go/commit/d77b772afb74d7fbeeeef27d6d149cfd5c351d3e?src=pr&el=desc) will **increase** coverage by `0.05%`.
> The diff coverage is `0%`.

[![Impacted file tree graph](https://codecov.io/gh/apache/dubbo-go/pull/266/graphs/tree.svg?width=650&token=dcPE6RyFAL&height=150&src=pr)](https://codecov.io/gh/apache/dubbo-go/pull/266?src=pr&el=tree)

```diff
@@            Coverage Diff             @@
##           master     #266      +/-   ##
==========================================
+ Coverage      65%   65.06%   +0.05%     
==========================================
  Files         105      105              
  Lines        6792     6792              
==========================================
+ Hits         4415     4419       +4     
+ Misses       1932     1928       -4     
  Partials      445      445
```


| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/266?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [config\_center/parser/configuration\_parser.go](https://codecov.io/gh/apache/dubbo-go/pull/266/diff?src=pr&el=tree#diff-Y29uZmlnX2NlbnRlci9wYXJzZXIvY29uZmlndXJhdGlvbl9wYXJzZXIuZ28=) | `2.14% <0%> (ø)` | :arrow_up: |
| [remoting/zookeeper/client.go](https://codecov.io/gh/apache/dubbo-go/pull/266/diff?src=pr&el=tree#diff-cmVtb3Rpbmcvem9va2VlcGVyL2NsaWVudC5nbw==) | `64.45% <0%> (+0.57%)` | :arrow_up: |
| [remoting/zookeeper/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/266/diff?src=pr&el=tree#diff-cmVtb3Rpbmcvem9va2VlcGVyL2xpc3RlbmVyLmdv) | `47.93% <0%> (+1.03%)` | :arrow_up: |

------

[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/266?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/266?src=pr&el=footer). Last update [d77b772...e4561b6](https://codecov.io/gh/apache/dubbo-go/pull/266?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).


[ Full content available at: https://github.com/apache/dubbo-go/pull/266 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org