[GitHub] [superset] zhaoyongjie commented on a change in pull request #18195: fix: should commit after importing dataset

[GitBox <gi...@apache.org>]

zhaoyongjie commented on a change in pull request #18195:
URL: https://github.com/apache/superset/pull/18195#discussion_r794231971



##########
File path: superset/datasets/commands/importers/v0.py
##########
@@ -316,6 +316,7 @@ def run(self) -> None:
                     )
                     dataset["database_id"] = database.id
                     SqlaTable.import_from_dict(db.session, dataset, sync=self.sync)
+                db.session.commit()

Review comment:
       seems that `if` expression can't commit as well. This change should add more unit test.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org