You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2022/11/14 09:35:14 UTC

[GitHub] [ozone] ChenSammi opened a new pull request, #3954: HDDS-7487. Support fine grained certificate lifetime for efficient test.

ChenSammi opened a new pull request, #3954:
URL: https://github.com/apache/ozone/pull/3954

   https://issues.apache.org/jira/browse/HDDS-7487 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org


[GitHub] [ozone] ChenSammi merged pull request #3954: HDDS-7487. Support fine grained certificate lifetime for efficient test.

Posted by GitBox <gi...@apache.org>.
ChenSammi merged PR #3954:
URL: https://github.com/apache/ozone/pull/3954


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org


[GitHub] [ozone] ChenSammi commented on pull request #3954: HDDS-7487. Support fine grained certificate lifetime for efficient test.

Posted by GitBox <gi...@apache.org>.
ChenSammi commented on PR #3954:
URL: https://github.com/apache/ozone/pull/3954#issuecomment-1318250942

   Thanks @Galsza @fapifta  for the code review. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org


[GitHub] [ozone] ChenSammi commented on pull request #3954: HDDS-7487. Support fine grained certificate lifetime for efficient test.

Posted by GitBox <gi...@apache.org>.
ChenSammi commented on PR #3954:
URL: https://github.com/apache/ozone/pull/3954#issuecomment-1315378375

   Hi @fapifta , would like to take another look? 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org


[GitHub] [ozone] ChenSammi commented on pull request #3954: HDDS-7487. Support fine grained certificate lifetime for efficient test.

Posted by GitBox <gi...@apache.org>.
ChenSammi commented on PR #3954:
URL: https://github.com/apache/ozone/pull/3954#issuecomment-1318003749

   > I did, one question popped up in my mind while looking at the changes again, why we change the test from BlockTokenSecretManager to ContainerTokenSecretManager?
   
   Because it's container creation operation in the test, which requires a container token, not a block token.  BlockTokenSecretManager is misused here. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org


[GitHub] [ozone] fapifta commented on pull request #3954: HDDS-7487. Support fine grained certificate lifetime for efficient test.

Posted by GitBox <gi...@apache.org>.
fapifta commented on PR #3954:
URL: https://github.com/apache/ozone/pull/3954#issuecomment-1317358645

   I did, one question popped up in my mind while looking at the changes again, why we change the test from BlockTokenSecretManager to ContainerTokenSecretManager?
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org