You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mesos.apache.org by dl...@apache.org on 2015/03/11 02:39:53 UTC
svn commit: r1665754 [1/3] - in /mesos/site:
publish/documentation/latest/mesos-developers-guide/index.html
publish/documentation/mesos-developers-guide/index.html publish/sitemap.xml
source/documentation/latest/mesos-developers-guide.md
Author: dlester
Date: Wed Mar 11 01:39:53 2015
New Revision: 1665754
URL: http://svn.apache.org/r1665754
Log:
Updates documentation.
Modified:
mesos/site/publish/documentation/latest/mesos-developers-guide/index.html
mesos/site/publish/documentation/mesos-developers-guide/index.html
mesos/site/publish/sitemap.xml
mesos/site/source/documentation/latest/mesos-developers-guide.md
Modified: mesos/site/publish/documentation/latest/mesos-developers-guide/index.html
URL: http://svn.apache.org/viewvc/mesos/site/publish/documentation/latest/mesos-developers-guide/index.html?rev=1665754&r1=1665753&r2=1665754&view=diff
==============================================================================
--- mesos/site/publish/documentation/latest/mesos-developers-guide/index.html (original)
+++ mesos/site/publish/documentation/latest/mesos-developers-guide/index.html Wed Mar 11 01:39:53 2015
@@ -149,8 +149,8 @@
<ol>
<li><code>git checkout master</code></li>
<li><code>git pull</code></li>
-<li><code>git co my_branch</code></li>
-<li>Check the output of <code>git diff master</code> and make sure it lists only your changes. If other changes you did not make are listed, try a rebase to bring your branch up to date with master.</li>
+<li><code>git checkout my_branch</code></li>
+<li>Check the output of <code>git diff master</code> and make sure it lists only your changes. If other changes you did not make are listed, try <code>git rebase master</code> to bring your branch up to date with master.</li>
</ol>
</li>
</ol>
@@ -166,10 +166,11 @@
<li>The easiest (and recommended) way to submit reviews is through <code>post-reviews.py</code> a wrapper around post-review.</li>
<li>First, install post-review. <a href="http://www.reviewboard.org/docs/manual/dev/users/tools/post-review/">See Instructions</a></li>
<li>Configure post-review. The easiest method is to symlink to the sample config: ln -s support/reviewboardrc .reviewboardrc</li>
+<li>Log into Review Board from the command line: run <code>rbt status</code></li>
<li>From your local branch run <code>support/post-reviews.py</code>.</li>
<li>Note that <code>post-reviews.py</code> creates a new review for every commit on your branch that is different from the <code>master</code>.</li>
<li>Be sure to add your JIRA issue id (e.g. MESOS-01) to the field labeled “Bugs” (this will automatically link)</li>
-<li>Under “Description” in addition to details about your changes, include a description of any wiki documentation pages need to be added, or are affected by your changes (e.g. did you change or add any configuration options/flags? Did you add a new binary?)</li>
+<li>Under “Description” in addition to details about your changes, include a description of any documentation pages that need to be added, or are affected by your changes (e.g. did you change or add any configuration options/flags? Did you add a new binary?)</li>
</ol>
</li>
<li><p>Wait for a code review from another Mesos developer via Review Board, address their feedback and upload updated patches until you receive a “Ship It” from a Mesos committer.</p>
Modified: mesos/site/publish/documentation/mesos-developers-guide/index.html
URL: http://svn.apache.org/viewvc/mesos/site/publish/documentation/mesos-developers-guide/index.html?rev=1665754&r1=1665753&r2=1665754&view=diff
==============================================================================
--- mesos/site/publish/documentation/mesos-developers-guide/index.html (original)
+++ mesos/site/publish/documentation/mesos-developers-guide/index.html Wed Mar 11 01:39:53 2015
@@ -149,8 +149,8 @@
<ol>
<li><code>git checkout master</code></li>
<li><code>git pull</code></li>
-<li><code>git co my_branch</code></li>
-<li>Check the output of <code>git diff master</code> and make sure it lists only your changes. If other changes you did not make are listed, try a rebase to bring your branch up to date with master.</li>
+<li><code>git checkout my_branch</code></li>
+<li>Check the output of <code>git diff master</code> and make sure it lists only your changes. If other changes you did not make are listed, try <code>git rebase master</code> to bring your branch up to date with master.</li>
</ol>
</li>
</ol>
@@ -166,10 +166,11 @@
<li>The easiest (and recommended) way to submit reviews is through <code>post-reviews.py</code> a wrapper around post-review.</li>
<li>First, install post-review. <a href="http://www.reviewboard.org/docs/manual/dev/users/tools/post-review/">See Instructions</a></li>
<li>Configure post-review. The easiest method is to symlink to the sample config: ln -s support/reviewboardrc .reviewboardrc</li>
+<li>Log into Review Board from the command line: run <code>rbt status</code></li>
<li>From your local branch run <code>support/post-reviews.py</code>.</li>
<li>Note that <code>post-reviews.py</code> creates a new review for every commit on your branch that is different from the <code>master</code>.</li>
<li>Be sure to add your JIRA issue id (e.g. MESOS-01) to the field labeled “Bugs” (this will automatically link)</li>
-<li>Under “Description” in addition to details about your changes, include a description of any wiki documentation pages need to be added, or are affected by your changes (e.g. did you change or add any configuration options/flags? Did you add a new binary?)</li>
+<li>Under “Description” in addition to details about your changes, include a description of any documentation pages that need to be added, or are affected by your changes (e.g. did you change or add any configuration options/flags? Did you add a new binary?)</li>
</ol>
</li>
<li><p>Wait for a code review from another Mesos developer via Review Board, address their feedback and upload updated patches until you receive a “Ship It” from a Mesos committer.</p>