You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/10/10 09:13:59 UTC

[GitHub] [spark] LuciferYang commented on a diff in pull request #38185: [SPARK-40718][BUILD][CONNECT][FOLLOWUP] Explicitly add Netty related dependencies for the `connect` module

LuciferYang commented on code in PR #38185:
URL: https://github.com/apache/spark/pull/38185#discussion_r991072118


##########
dev/deps/spark-deps-hadoop-3-hive-2.3:
##########
@@ -187,8 +187,12 @@ metrics-jvm/4.2.10//metrics-jvm-4.2.10.jar
 minlog/1.3.0//minlog-1.3.0.jar
 netty-all/4.1.80.Final//netty-all-4.1.80.Final.jar
 netty-buffer/4.1.80.Final//netty-buffer-4.1.80.Final.jar
+netty-codec-http/4.1.80.Final//netty-codec-http-4.1.80.Final.jar

Review Comment:
   the new 4 jar about 1232KB



##########
dev/deps/spark-deps-hadoop-3-hive-2.3:
##########
@@ -187,8 +187,12 @@ metrics-jvm/4.2.10//metrics-jvm-4.2.10.jar
 minlog/1.3.0//minlog-1.3.0.jar
 netty-all/4.1.80.Final//netty-all-4.1.80.Final.jar
 netty-buffer/4.1.80.Final//netty-buffer-4.1.80.Final.jar
+netty-codec-http/4.1.80.Final//netty-codec-http-4.1.80.Final.jar

Review Comment:
   the new 4 jars about 1232KB



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org