You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2021/01/18 05:15:17 UTC

[GitHub] [rocketmq] xxd763795151 opened a new issue #2607: Set benchmark`s consumer isSuffixEnable defautl false and update help info

xxd763795151 opened a new issue #2607:
URL: https://github.com/apache/rocketmq/issues/2607


   **BUG REPORT**
   
   class: org.apache.rocketmq.example.benchmark.Consumer
   
   question 1: the default value of isSuffixEnable should be false, then it is more friendly. But it`s true now.
   question 2: the help info about isSuffixEnable is wrong, as follow:
   ```
   "group prefix enable", true, "Consumer group name, Default: false"
   ```


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [rocketmq] duhenglucky closed issue #2607: Set benchmark`s consumer isSuffixEnable defautl false and update help info

Posted by GitBox <gi...@apache.org>.
duhenglucky closed issue #2607:
URL: https://github.com/apache/rocketmq/issues/2607


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [rocketmq] xxd763795151 commented on issue #2607: Set benchmark`s consumer isSuffixEnable defautl false and update help info

Posted by GitBox <gi...@apache.org>.
xxd763795151 commented on issue #2607:
URL: https://github.com/apache/rocketmq/issues/2607#issuecomment-762005044


   > @xxd763795151 would you like submit a PR to fix it?
   
   @duhenglucky Yeah. I just submitted it.   https://github.com/apache/rocketmq/pull/2608 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [rocketmq] jack5505 commented on issue #2607: Set benchmark`s consumer isSuffixEnable defautl false and update help info

Posted by GitBox <gi...@apache.org>.
jack5505 commented on issue #2607:
URL: https://github.com/apache/rocketmq/issues/2607#issuecomment-768924082


   Hello guys I'm new in this project. I want to be contributor of thi project very interesting


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [rocketmq] duhenglucky commented on issue #2607: Set benchmark`s consumer isSuffixEnable defautl false and update help info

Posted by GitBox <gi...@apache.org>.
duhenglucky commented on issue #2607:
URL: https://github.com/apache/rocketmq/issues/2607#issuecomment-762002405


   @xxd763795151 would you like submit a PR to fix it?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [rocketmq] duhenglucky commented on issue #2607: Set benchmark`s consumer isSuffixEnable defautl false and update help info

Posted by GitBox <gi...@apache.org>.
duhenglucky commented on issue #2607:
URL: https://github.com/apache/rocketmq/issues/2607#issuecomment-845592230


   @jack5505 thanks for your contribution, this PR merged, hope to see more contributions from you:)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org