karaf-maven-plugin work

[Brian Topping <to...@codehaus.org>]

Hi all,

I've submitted https://issues.apache.org/jira/browse/KARAF-1530 and am about to start on some more changes, but wanted to get preferences from the team on which direction I go first.  

End result should be a plugin with complete integration tests for every feature, both to provide documentation and ensure against regressions.

Option 1: Attack warts first, add tests when they are cleared.  This is the path of least overall work, but creates more of a burden for team members accepting patches to get to the end result.  

Option 2: Create comprehensive tests first against current behavior, then fix both plugin and tests.  This is more work, but may be faster from a calendar perspective because it reduces the effort for patches to be approved and applied. 

What do you guys think?  What's the team's preference?

Cheers, Brian

Re: karaf-maven-plugin work

[Ioannis Canellos <io...@gmail.com>]

Hi Brian,

thanks for the contribution. Whatever, option you choose it will be highly
appreciated :-)

I'll try to find some cycles and review your patch.

Keep it up!

-- 
*Ioannis Canellos*
*
FuseSource <http://fusesource.com>

**
Blog: http://iocanel.blogspot.com
**
Twitter: iocanel
*

Re: karaf-maven-plugin work

[Brian Topping <to...@codehaus.org>]

Apologies if this was confusing or whatnot, it's kind of hard to contribute like this.  Please don't hesitate to ask for clarification here or in channel.

Thanks, Brian

On Jun 10, 2012, at 4:04 PM, Brian Topping wrote:

> Hi all,
> 
> I've submitted https://issues.apache.org/jira/browse/KARAF-1530 and am about to start on some more changes, but wanted to get preferences from the team on which direction I go first.  
> 
> End result should be a plugin with complete integration tests for every feature, both to provide documentation and ensure against regressions.
> 
> Option 1: Attack warts first, add tests when they are cleared.  This is the path of least overall work, but creates more of a burden for team members accepting patches to get to the end result.  
> 
> Option 2: Create comprehensive tests first against current behavior, then fix both plugin and tests.  This is more work, but may be faster from a calendar perspective because it reduces the effort for patches to be approved and applied. 
> 
> What do you guys think?  What's the team's preference?
> 
> Cheers, Brian

Re: karaf-maven-plugin work

[Jean-Baptiste Onofré <jb...@nanthrax.net>]

Hi Brian,

again, thanks for the patch. I will review it and apply.

Regards
JB

On 06/10/2012 10:04 PM, Brian Topping wrote:
> Hi all,
>
> I've submitted https://issues.apache.org/jira/browse/KARAF-1530 and am about to start on some more changes, but wanted to get preferences from the team on which direction I go first.
>
> End result should be a plugin with complete integration tests for every feature, both to provide documentation and ensure against regressions.
>
> Option 1: Attack warts first, add tests when they are cleared.  This is the path of least overall work, but creates more of a burden for team members accepting patches to get to the end result.
>
> Option 2: Create comprehensive tests first against current behavior, then fix both plugin and tests.  This is more work, but may be faster from a calendar perspective because it reduces the effort for patches to be approved and applied.
>
> What do you guys think?  What's the team's preference?
>
> Cheers, Brian

-- 
Jean-Baptiste Onofré
jbonofre@apache.org
http://blog.nanthrax.net
Talend - http://www.talend.com