You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2018/12/03 09:00:17 UTC

[GitHub] zhijiangW commented on a change in pull request #7186: [FLINK-10941] Keep slots which contain unconsumed result partitions

zhijiangW commented on a change in pull request #7186: [FLINK-10941] Keep slots which contain unconsumed result partitions
URL: https://github.com/apache/flink/pull/7186#discussion_r238184515
 
 

 ##########
 File path: flink-runtime/src/main/java/org/apache/flink/runtime/taskmanager/Task.java
 ##########
 @@ -869,6 +869,20 @@ else if (transitionState(current, ExecutionState.FAILED, t)) {
 		}
 	}
 
+	/**
+	 * This task can only be safely released after all produced partitions are consumed.
+	 */
+	public boolean canBeReleased() {
+		for (ResultPartition producedPartition : producedPartitions) {
+			if (!producedPartition.isReleased()) {
+				LOG.debug("Task can NOT be released, execution ID {}", this.getExecutionId());
 
 Review comment:
   remove this

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services