You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@tomcat.apache.org by GitBox <gi...@apache.org> on 2022/10/24 07:54:47 UTC

[GitHub] [tomcat-jakartaee-migration] aooohan commented on pull request #36: Improve composability when using from other tools

aooohan commented on PR #36:
URL: https://github.com/apache/tomcat-jakartaee-migration/pull/36#issuecomment-1288571178

   I like this PR, but I don't like the change of the Migration class as this change made a bit numerous and a bit hassle. I think we could add a field to identify whether has been converted, like this`migration.hasConverted()`, which requires only minor changes to the implementation of the` Migration#migrateStream` method.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org