You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/10/14 11:38:42 UTC

[GitHub] [airflow] uranusjr commented on a change in pull request #18979: Fixes #18943 null execution date on insert to task_fail violating NOT NULL

uranusjr commented on a change in pull request #18979:
URL: https://github.com/apache/airflow/pull/18979#discussion_r728895491



##########
File path: airflow/models/taskinstance.py
##########
@@ -1702,7 +1702,8 @@ def handle_failure(
             session.add(Log(State.FAILED, self))
 
             # Log failure duration
-            session.add(TaskFail(task, self.execution_date, self.start_date, self.end_date))
+            dag_run = self.get_dagrun()  # self.dag_run not populated by refresh_from_db

Review comment:
       `self.get_dagrun()` already considers `self.run_id` so I don't think this is needed.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org