You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Hao Hao (Code Review)" <ge...@cloudera.org> on 2018/09/06 22:35:56 UTC
[kudu-CR] [thirdparty] minor refactor in build-if-necessary
Hao Hao has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11397
Change subject: [thirdparty] minor refactor in build-if-necessary
......................................................................
[thirdparty] minor refactor in build-if-necessary
This commit does a minor refactor in build-if-necessary.sh to always
display informing message when not rebuilding thirdparty.
Change-Id: I2ca2d8907061c1a4ace06a9f624262313a62f700
---
M thirdparty/build-if-necessary.sh
1 file changed, 1 insertion(+), 3 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/97/11397/1
--
To view, visit http://gerrit.cloudera.org:8080/11397
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I2ca2d8907061c1a4ace06a9f624262313a62f700
Gerrit-Change-Number: 11397
Gerrit-PatchSet: 1
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
[kudu-CR] [thirdparty] minor refactor in build-if-necessary
Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/11397 )
Change subject: [thirdparty] minor refactor in build-if-necessary
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/11397
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2ca2d8907061c1a4ace06a9f624262313a62f700
Gerrit-Change-Number: 11397
Gerrit-PatchSet: 1
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Thu, 06 Sep 2018 22:59:35 +0000
Gerrit-HasComments: No
[kudu-CR] [thirdparty] minor refactor in build-if-necessary
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/11397 )
Change subject: [thirdparty] minor refactor in build-if-necessary
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/11397
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2ca2d8907061c1a4ace06a9f624262313a62f700
Gerrit-Change-Number: 11397
Gerrit-PatchSet: 1
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Thu, 06 Sep 2018 22:42:48 +0000
Gerrit-HasComments: No
[kudu-CR] [thirdparty] minor refactor in build-if-necessary
Posted by "Hao Hao (Code Review)" <ge...@cloudera.org>.
Hao Hao has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11397 )
Change subject: [thirdparty] minor refactor in build-if-necessary
......................................................................
[thirdparty] minor refactor in build-if-necessary
This commit does a minor refactor in build-if-necessary.sh to always
display informing message when not rebuilding thirdparty.
Change-Id: I2ca2d8907061c1a4ace06a9f624262313a62f700
Reviewed-on: http://gerrit.cloudera.org:8080/11397
Reviewed-by: Adar Dembo <ad...@cloudera.com>
Reviewed-by: Dan Burkert <da...@apache.org>
Tested-by: Kudu Jenkins
---
M thirdparty/build-if-necessary.sh
1 file changed, 1 insertion(+), 3 deletions(-)
Approvals:
Adar Dembo: Looks good to me, approved
Dan Burkert: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/11397
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I2ca2d8907061c1a4ace06a9f624262313a62f700
Gerrit-Change-Number: 11397
Gerrit-PatchSet: 2
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins