You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/02/12 16:24:14 UTC
[GitHub] [spark] kiszk commented on issue #27543: [SQL][SPARK-30793] Fix
truncations of timestamps before the epoch to minutes and seconds
kiszk commented on issue #27543: [SQL][SPARK-30793] Fix truncations of timestamps before the epoch to minutes and seconds
URL: https://github.com/apache/spark/pull/27543#issuecomment-585288829
This change looks good. In addition, I think that this function has the similar problems in `TRUNC_TO_HOUR` and `TRUNC_TO_DAY`, too.
How about the results with `val df = Seq("1961-04-12 03:01:02.345")...`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org