You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2020/08/09 14:32:30 UTC
[GitHub] [pulsar] rudy2steiner opened a new pull request #7786: Redirect Get message by id request when broker not serve for the topic
rudy2steiner opened a new pull request #7786:
URL: https://github.com/apache/pulsar/pull/7786
<!--
### Contribution Checklist
- Name the pull request in the form "[Issue XYZ][component] Title of the pull request", where *XYZ* should be replaced by the actual issue number.
Skip *Issue XYZ* if there is no associated github issue for this pull request.
Skip *component* if you are unsure about which is the best component. E.g. `[docs] Fix typo in produce method`.
- Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.
- Each pull request should address only one issue, not mix up code from multiple issues.
- Each commit in the pull request has a meaningful commit message
- Once all items of the checklist are addressed, remove the above text and this checklist, leaving only the filled out template below.
**(The sections below can be removed for hotfixes of typos)**
-->
*(If this PR fixes a github issue, please add `Fixes #<xyz>`.)*
Fixes #7604
Master Issue: #7604
### Motivation
We should redirect Get message by id request when a broker doesn't serve for the topic
### Modifications
* Redirect Get message by id request when a broker doesn't serve for the topic
* Test log config use log4j2.xml not logback.xml
config by parent pom: -Dlog4j.configurationFile=log4j2.xml
### Verifying this change
This change is a trivial changes without any test coverage.
### Does this pull request potentially affect one of the following parts:
*If `yes` was chosen, please highlight the changes*
- Dependencies (does it add or upgrade a dependency): ( no)
- The public API: (yes )
- The schema: (no)
- The default values of configurations: (no)
- The wire protocol: (no)
- The rest endpoints: ( no)
- The admin cli options: (no)
- Anything that affects deployment: (no)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] sijie merged pull request #7786: Redirect Get message by id request when broker not serve for the topic
Posted by GitBox <gi...@apache.org>.
sijie merged pull request #7786:
URL: https://github.com/apache/pulsar/pull/7786
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] rudy2steiner commented on pull request #7786: Redirect Get message by id request when broker not serve for the topic
Posted by GitBox <gi...@apache.org>.
rudy2steiner commented on pull request #7786:
URL: https://github.com/apache/pulsar/pull/7786#issuecomment-671800745
I will check the unit test exception,seem like not cause by this changes:
```
org.testng.internal.thread.ThreadTimeoutException: Method org.apache.pulsar.client.api.SimpleProducerConsumerTest.testSharedSamePriorityConsumer() didn't finish within the time-out 5000
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] rudy2steiner commented on pull request #7786: Redirect Get message by id request when broker not serve for the topic
Posted by GitBox <gi...@apache.org>.
rudy2steiner commented on pull request #7786:
URL: https://github.com/apache/pulsar/pull/7786#issuecomment-674390090
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] rudy2steiner commented on a change in pull request #7786: Redirect Get message by id request when broker not serve for the topic
Posted by GitBox <gi...@apache.org>.
rudy2steiner commented on a change in pull request #7786:
URL: https://github.com/apache/pulsar/pull/7786#discussion_r467660972
##########
File path: pulsar-broker/src/test/resources/log4j2.xml
##########
@@ -19,18 +19,16 @@
-->
<configuration scan="true">
-<!--
Review comment:
When I try to debug the API, using LoadBalancerTest to launch a multi nodes cluster and trying to change the debug level, such as org.apache.pulsar.broker.admin. but logback.xml configuration doesn't work and found that we actually using log4j2.xml which is configured in parent pom.
I just change the log config file by the way, it's ok if you still think we shouldn't change this
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] rudy2steiner commented on pull request #7786: Redirect Get message by id request when broker not serve for the topic
Posted by GitBox <gi...@apache.org>.
rudy2steiner commented on pull request #7786:
URL: https://github.com/apache/pulsar/pull/7786#issuecomment-674410641
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] rudy2steiner commented on pull request #7786: Redirect Get message by id request when broker not serve for the topic
Posted by GitBox <gi...@apache.org>.
rudy2steiner commented on pull request #7786:
URL: https://github.com/apache/pulsar/pull/7786#issuecomment-674394216
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] rudy2steiner removed a comment on pull request #7786: Redirect Get message by id request when broker not serve for the topic
Posted by GitBox <gi...@apache.org>.
rudy2steiner removed a comment on pull request #7786:
URL: https://github.com/apache/pulsar/pull/7786#issuecomment-674394216
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] rudy2steiner commented on pull request #7786: Redirect Get message by id request when broker not serve for the topic
Posted by GitBox <gi...@apache.org>.
rudy2steiner commented on pull request #7786:
URL: https://github.com/apache/pulsar/pull/7786#issuecomment-671282527
@sijie please help review !
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] rudy2steiner commented on pull request #7786: Redirect Get message by id request when broker not serve for the topic
Posted by GitBox <gi...@apache.org>.
rudy2steiner commented on pull request #7786:
URL: https://github.com/apache/pulsar/pull/7786#issuecomment-674403420
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] sijie commented on a change in pull request #7786: Redirect Get message by id request when broker not serve for the topic
Posted by GitBox <gi...@apache.org>.
sijie commented on a change in pull request #7786:
URL: https://github.com/apache/pulsar/pull/7786#discussion_r467654200
##########
File path: pulsar-broker/src/test/resources/log4j2.xml
##########
@@ -19,18 +19,16 @@
-->
<configuration scan="true">
-<!--
Review comment:
The change doesn't seem to be related.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] sijie commented on pull request #7786: Redirect Get message by id request when broker not serve for the topic
Posted by GitBox <gi...@apache.org>.
sijie commented on pull request #7786:
URL: https://github.com/apache/pulsar/pull/7786#issuecomment-671756576
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] rudy2steiner commented on pull request #7786: Redirect Get message by id request when broker not serve for the topic
Posted by GitBox <gi...@apache.org>.
rudy2steiner commented on pull request #7786:
URL: https://github.com/apache/pulsar/pull/7786#issuecomment-674414727
I try to run the same unit test command on local
```
./build/retry.sh mvn -B -ntp test -pl pulsar-broker -Dinclude='org/apache/pulsar/broker/**/*.java' -Dexclude='org/apache/pulsar/broker/zookeeper/**/*.java,org/apache/pulsar/broker/loadbalance/**/*.java,org/apache/pulsar/broker/service/**/*.java,**/AdminApiOffloadTest.java'
```
without any failed test case.
But online test failed after retry 3 times and each time failed with different test cases:
```
[ERROR] Failures:
[ERROR] org.apache.pulsar.broker.transaction.coordinator.TransactionMetaStoreAssignmentTest.testTransactionMetaStoreAssignAndFailover(org.apache.pulsar.broker.transaction.coordinator.TransactionMetaStoreAssignmentTest)
[INFO] Run 1: PASS
[ERROR] Run 2: TransactionMetaStoreAssignmentTest.testTransactionMetaStoreAssignAndFailover:45 expected [16] but found [0]
[INFO]
[INFO]
-----------
[ERROR] Failures:
[ERROR] org.apache.pulsar.broker.admin.IncrementPartitionsTest.testIncrementPartitionsWithNoSubscriptions(org.apache.pulsar.broker.admin.IncrementPartitionsTest)
[INFO] Run 1: PASS
[ERROR] Run 2: IncrementPartitionsTest.testIncrementPartitionsWithNoSubscriptions:130 expected [20] but found [10]
[INFO]
[ERROR] TransactionProduceTest.setup ? PulsarAdmin java.util.concurrent.CompletionExce...
[INFO]
[ERROR] Tests run: 417, Failures: 2, Errors: 0, Skipped: 2
-----
[ERROR] Failures:
[ERROR] org.apache.pulsar.broker.admin.IncrementPartitionsTest.testIncrementPartitionsWithNoSubscriptions(org.apache.pulsar.broker.admin.IncrementPartitionsTest)
[INFO] Run 1: PASS
[ERROR] Run 2: IncrementPartitionsTest.testIncrementPartitionsWithNoSubscriptions:127 expected [10] but found [2]
[INFO]
[ERROR] org.apache.pulsar.broker.admin.MaxUnackedMessagesTest.testMaxUnackedMessagesOnSubscriptionApi(org.apache.pulsar.broker.admin.MaxUnackedMessagesTest)
[INFO] Run 1: PASS
[ERROR] Run 2: MaxUnackedMessagesTest.testMaxUnackedMessagesOnSubscriptionApi ? ServerSideError
[INFO]
[ERROR] org.apache.pulsar.broker.transaction.coordinator.TransactionMetaStoreAssignmentTest.testTransactionMetaStoreAssignAndFailover(org.apache.pulsar.broker.transaction.coordinator.TransactionMetaStoreAssignmentTest)
[INFO] Run 1: PASS
[ERROR] Run 2: TransactionMetaStoreAssignmentTest.testTransactionMetaStoreAssignAndFailover:45 expected [16] but found [0]
[INFO]
[INFO]
[ERROR] Tests run: 415, Failures: 3, Errors: 0, Skipped: 0
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] codelipenghui commented on pull request #7786: Redirect Get message by id request when broker not serve for the topic
Posted by GitBox <gi...@apache.org>.
codelipenghui commented on pull request #7786:
URL: https://github.com/apache/pulsar/pull/7786#issuecomment-674111828
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] rudy2steiner commented on a change in pull request #7786: Redirect Get message by id request when broker not serve for the topic
Posted by GitBox <gi...@apache.org>.
rudy2steiner commented on a change in pull request #7786:
URL: https://github.com/apache/pulsar/pull/7786#discussion_r467819497
##########
File path: pulsar-broker/src/test/resources/log4j2.xml
##########
@@ -19,18 +19,16 @@
-->
<configuration scan="true">
-<!--
Review comment:
revert
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org