You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2023/01/17 21:54:57 UTC
[GitHub] [ozone] GeorgeJahad opened a new pull request, #4185: HDDS-7765. [Snapshot] Handle OzoneManager#getKeyInfo with OmMetadataReader.
GeorgeJahad opened a new pull request, #4185:
URL: https://github.com/apache/ozone/pull/4185
## What changes were proposed in this pull request?
Merge from master was incomplete in that it did not move the new getKeyInfo() method from OzoneManager to the OmMetadataReader,( and OmMetadataReaderMetrics).
This PR rectifies that.
It also modifies the OmMetadataManagerImpl to not use the unneeded tableCacheMetrics on snapshots. (These were added by the merge.)
## What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-7765
## How was this patch tested?
Tested against the acceptance test for this PR: https://github.com/apache/ozone/pull/4134
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] GeorgeJahad commented on a diff in pull request #4185: HDDS-7765. [Snapshot] Handle OzoneManager#getKeyInfo with OmMetadataReader.
Posted by GitBox <gi...@apache.org>.
GeorgeJahad commented on code in PR #4185:
URL: https://github.com/apache/ozone/pull/4185#discussion_r1081700698
##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OmSnapshot.java:
##########
@@ -215,6 +225,12 @@ private OzoneFileStatus denormalizeOzoneFileStatus(
omKeyInfo, fileStatus.getBlockSize(), fileStatus.isDirectory());
}
+ private KeyInfoWithVolumeContext denormalizeKeyInfoWithVolumeContext(
+ KeyInfoWithVolumeContext k) {
+ return new KeyInfoWithVolumeContext(k.getVolumeArgs().orElse(null),
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] GeorgeJahad commented on pull request #4185: HDDS-7765. [Snapshot] Handle OzoneManager#getKeyInfo with OmMetadataReader.
Posted by GitBox <gi...@apache.org>.
GeorgeJahad commented on PR #4185:
URL: https://github.com/apache/ozone/pull/4185#issuecomment-1397740709
FYI: it did solve the hanging problem for me, so it should solve the others unless they are significantly different. Thanks for the review @smengcl !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] smengcl commented on a diff in pull request #4185: HDDS-7765. [Snapshot] Handle OzoneManager#getKeyInfo with OmMetadataReader.
Posted by GitBox <gi...@apache.org>.
smengcl commented on code in PR #4185:
URL: https://github.com/apache/ozone/pull/4185#discussion_r1080669196
##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OmSnapshot.java:
##########
@@ -215,6 +225,12 @@ private OzoneFileStatus denormalizeOzoneFileStatus(
omKeyInfo, fileStatus.getBlockSize(), fileStatus.isDirectory());
}
+ private KeyInfoWithVolumeContext denormalizeKeyInfoWithVolumeContext(
+ KeyInfoWithVolumeContext k) {
+ return new KeyInfoWithVolumeContext(k.getVolumeArgs().orElse(null),
+ k.getUserPrincipal().orElse(null),
+ denormalizeOmKeyInfo(k.getKeyInfo()));
+ }
Review Comment:
nit
```suggestion
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] smengcl commented on pull request #4185: HDDS-7765. [Snapshot] Handle OzoneManager#getKeyInfo with OmMetadataReader.
Posted by GitBox <gi...@apache.org>.
smengcl commented on PR #4185:
URL: https://github.com/apache/ozone/pull/4185#issuecomment-1397736964
Thanks @GeorgeJahad for taking care of this.
@xBis7 @aswinshakil @swamirishi You may rebased your patches on to the latest snapshot feature to see if that solves the (hanging) issues.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] smengcl commented on a diff in pull request #4185: HDDS-7765. [Snapshot] Handle OzoneManager#getKeyInfo with OmMetadataReader.
Posted by GitBox <gi...@apache.org>.
smengcl commented on code in PR #4185:
URL: https://github.com/apache/ozone/pull/4185#discussion_r1080672782
##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OmSnapshot.java:
##########
@@ -215,6 +225,12 @@ private OzoneFileStatus denormalizeOzoneFileStatus(
omKeyInfo, fileStatus.getBlockSize(), fileStatus.isDirectory());
}
+ private KeyInfoWithVolumeContext denormalizeKeyInfoWithVolumeContext(
+ KeyInfoWithVolumeContext k) {
+ return new KeyInfoWithVolumeContext(k.getVolumeArgs().orElse(null),
Review Comment:
Would using its `Builder` be better than calling the constructor directly?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] smengcl merged pull request #4185: HDDS-7765. [Snapshot] Handle OzoneManager#getKeyInfo with OmMetadataReader.
Posted by GitBox <gi...@apache.org>.
smengcl merged PR #4185:
URL: https://github.com/apache/ozone/pull/4185
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org