You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@avro.apache.org by "zcsizmadia (via GitHub)" <gi...@apache.org> on 2023/09/18 13:38:29 UTC

[GitHub] [avro] zcsizmadia opened a new pull request, #2500: AE-3859: build.sh clean fails to remove some C# files

zcsizmadia opened a new pull request, #2500:
URL: https://github.com/apache/avro/pull/2500

   ## What is the purpose of the change
   
   * Make sure that `build.sh clean` removes all bin and obj folders (AVRO-3859)
   
   
   ## Verifying this change
   
   This change is a trivial rework / code cleanup without any test coverage.
   
   ## Documentation
   
   - Does this pull request introduce a new feature? (no)
   - If yes, how is the feature documented? (not applicable)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@avro.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [avro] RyanSkraba commented on pull request #2500: AVRO-3859: build.sh clean fails to remove some C# files

Posted by "RyanSkraba (via GitHub)" <gi...@apache.org>.
RyanSkraba commented on PR #2500:
URL: https://github.com/apache/avro/pull/2500#issuecomment-1728050747

   :exploding_head: Today I learned!! Thanks for this! https://issues.apache.org/jira/browse/AVRO-3864
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [avro] zcsizmadia commented on pull request #2500: AVRO-3859: build.sh clean fails to remove some C# files

Posted by "zcsizmadia (via GitHub)" <gi...@apache.org>.
zcsizmadia commented on PR #2500:
URL: https://github.com/apache/avro/pull/2500#issuecomment-1724133031

   `git clean -dXf`
   
   Note the capital `X`


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [avro] zcsizmadia commented on pull request #2500: AE-3859: build.sh clean fails to remove some C# files

Posted by "zcsizmadia (via GitHub)" <gi...@apache.org>.
zcsizmadia commented on PR #2500:
URL: https://github.com/apache/avro/pull/2500#issuecomment-1723439053

   @RyanSkraba Quick fix for AVRO-3859. I followed the pattern which is already in the clean step. Personally I like using `git clean -dfx` for such cleanings. It deletes all untracked and unwanted files, and by honoring the .gitignore file(s).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [avro] zcsizmadia merged pull request #2500: AVRO-3859: build.sh clean fails to remove some C# files

Posted by "zcsizmadia (via GitHub)" <gi...@apache.org>.
zcsizmadia merged PR #2500:
URL: https://github.com/apache/avro/pull/2500


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@avro.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org