You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kafka.apache.org by Jakob Homan <jg...@apache.org> on 2014/06/20 07:27:52 UTC

Review Request 22802: KAFKA-1308, publish test jars

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22802/
-----------------------------------------------------------

Review request for kafka.


Repository: kafka


Description
-------

Publish test jars


Diffs
-----

  build.gradle 2f4167f 

Diff: https://reviews.apache.org/r/22802/diff/


Testing
-------

locally.


Thanks,

Jakob Homan


Re: Review Request 22802: KAFKA-1308, publish test jars

Posted by Neha Narkhede <ne...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22802/#review46258
-----------------------------------------------------------

Ship it!


Ship It!

- Neha Narkhede


On June 20, 2014, 5:27 a.m., Jakob Homan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22802/
> -----------------------------------------------------------
> 
> (Updated June 20, 2014, 5:27 a.m.)
> 
> 
> Review request for kafka.
> 
> 
> Repository: kafka
> 
> 
> Description
> -------
> 
> Publish test jars
> 
> 
> Diffs
> -----
> 
>   build.gradle 2f4167f 
> 
> Diff: https://reviews.apache.org/r/22802/diff/
> 
> 
> Testing
> -------
> 
> locally.
> 
> 
> Thanks,
> 
> Jakob Homan
> 
>


Re: Review Request 22802: KAFKA-1308, publish test jars

Posted by Neha Narkhede <ne...@gmail.com>.

> On June 20, 2014, 3:11 p.m., Jun Rao wrote:
> > Hmm, I ran ./gradlew uploadArchivesAll locally, but don't see any test jar created for publish.

hmmm... I think my test jar was lying around from a previous manual build. See the same issue after clearing it and using ./gradlew uploadArchivesAll


- Neha


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22802/#review46277
-----------------------------------------------------------


On June 20, 2014, 5:27 a.m., Jakob Homan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22802/
> -----------------------------------------------------------
> 
> (Updated June 20, 2014, 5:27 a.m.)
> 
> 
> Review request for kafka.
> 
> 
> Repository: kafka
> 
> 
> Description
> -------
> 
> Publish test jars
> 
> 
> Diffs
> -----
> 
>   build.gradle 2f4167f 
> 
> Diff: https://reviews.apache.org/r/22802/diff/
> 
> 
> Testing
> -------
> 
> locally.
> 
> 
> Thanks,
> 
> Jakob Homan
> 
>


Re: Review Request 22802: KAFKA-1308, publish test jars

Posted by Jun Rao <ju...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22802/#review46277
-----------------------------------------------------------


Hmm, I ran ./gradlew uploadArchivesAll locally, but don't see any test jar created for publish.

- Jun Rao


On June 20, 2014, 5:27 a.m., Jakob Homan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22802/
> -----------------------------------------------------------
> 
> (Updated June 20, 2014, 5:27 a.m.)
> 
> 
> Review request for kafka.
> 
> 
> Repository: kafka
> 
> 
> Description
> -------
> 
> Publish test jars
> 
> 
> Diffs
> -----
> 
>   build.gradle 2f4167f 
> 
> Diff: https://reviews.apache.org/r/22802/diff/
> 
> 
> Testing
> -------
> 
> locally.
> 
> 
> Thanks,
> 
> Jakob Homan
> 
>