You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Bharath Vissapragada (Code Review)" <ge...@cloudera.org> on 2017/02/24 05:18:31 UTC
[Impala-ASF-CR] IMPALA-4955: Fix integer overflow in hdfs table size accounting
Bharath Vissapragada has uploaded a new change for review.
http://gerrit.cloudera.org:8080/6133
Change subject: IMPALA-4955: Fix integer overflow in hdfs table size accounting
......................................................................
IMPALA-4955: Fix integer overflow in hdfs table size accounting
We incorrectly use integer type instead of a long for a variable
that tracks the partition data size and that is overflowing.
Testing: Couldn't reproduce it locally but the perf build that
was hitting this over TPCDS scale 1000 dataset is green with this
fix.
Change-Id: I8ee568a72ac038464cfb3e4c225f130770dd8d0f
---
M fe/src/main/java/org/apache/impala/catalog/HdfsTable.java
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/33/6133/1
--
To view, visit http://gerrit.cloudera.org:8080/6133
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I8ee568a72ac038464cfb3e4c225f130770dd8d0f
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Bharath Vissapragada <bh...@cloudera.com>
[Impala-ASF-CR] IMPALA-4955: Fix integer overflow in hdfs table size accounting
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change.
Change subject: IMPALA-4955: Fix integer overflow in hdfs table size accounting
......................................................................
Patch Set 1: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/6133
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8ee568a72ac038464cfb3e4c225f130770dd8d0f
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-4955: Fix integer overflow in hdfs table size accounting
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change.
Change subject: IMPALA-4955: Fix integer overflow in hdfs table size accounting
......................................................................
Patch Set 1:
Build started: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/300/
--
To view, visit http://gerrit.cloudera.org:8080/6133
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8ee568a72ac038464cfb3e4c225f130770dd8d0f
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-4955: Fix integer overflow in hdfs table size accounting
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged.
Change subject: IMPALA-4955: Fix integer overflow in hdfs table size accounting
......................................................................
IMPALA-4955: Fix integer overflow in hdfs table size accounting
We incorrectly use integer type instead of a long for a variable
that tracks the partition data size and that is overflowing.
Testing: Couldn't reproduce it locally but the perf build that
was hitting this over TPCDS scale 1000 dataset is green with this
fix.
Change-Id: I8ee568a72ac038464cfb3e4c225f130770dd8d0f
Reviewed-on: http://gerrit.cloudera.org:8080/6133
Reviewed-by: Alex Behm <al...@cloudera.com>
Tested-by: Impala Public Jenkins
---
M fe/src/main/java/org/apache/impala/catalog/HdfsTable.java
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Impala Public Jenkins: Verified
Alex Behm: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/6133
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I8ee568a72ac038464cfb3e4c225f130770dd8d0f
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
[Impala-ASF-CR] IMPALA-4955: Fix integer overflow in hdfs table size accounting
Posted by "Alex Behm (Code Review)" <ge...@cloudera.org>.
Alex Behm has posted comments on this change.
Change subject: IMPALA-4955: Fix integer overflow in hdfs table size accounting
......................................................................
Patch Set 1: Code-Review+2
Actually, I'll give +2. It's a very simple fix.
--
To view, visit http://gerrit.cloudera.org:8080/6133
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8ee568a72ac038464cfb3e4c225f130770dd8d0f
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-4955: Fix integer overflow in hdfs table size accounting
Posted by "Alex Behm (Code Review)" <ge...@cloudera.org>.
Alex Behm has posted comments on this change.
Change subject: IMPALA-4955: Fix integer overflow in hdfs table size accounting
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/6133
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8ee568a72ac038464cfb3e4c225f130770dd8d0f
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-HasComments: No