You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@drill.apache.org by ad...@apache.org on 2014/10/10 07:47:32 UTC
[03/10] git commit: DRILL-1495: Test cases should log relevant
message in case of expected failures
DRILL-1495: Test cases should log relevant message in case of expected failures
Project: http://git-wip-us.apache.org/repos/asf/incubator-drill/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-drill/commit/d752487a
Tree: http://git-wip-us.apache.org/repos/asf/incubator-drill/tree/d752487a
Diff: http://git-wip-us.apache.org/repos/asf/incubator-drill/diff/d752487a
Branch: refs/heads/master
Commit: d752487a8298c7a2afda45392246829f97a6e57c
Parents: 919baa0
Author: Aditya Kishore <ad...@maprtech.com>
Authored: Fri Oct 3 15:42:26 2014 -0700
Committer: Aditya Kishore <ad...@maprtech.com>
Committed: Thu Oct 9 13:59:13 2014 -0700
----------------------------------------------------------------------
.../src/test/java/org/apache/drill/TestBugFixes.java | 7 ++++++-
.../src/test/java/org/apache/drill/TestExampleQueries.java | 7 ++++++-
2 files changed, 12 insertions(+), 2 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/incubator-drill/blob/d752487a/exec/java-exec/src/test/java/org/apache/drill/TestBugFixes.java
----------------------------------------------------------------------
diff --git a/exec/java-exec/src/test/java/org/apache/drill/TestBugFixes.java b/exec/java-exec/src/test/java/org/apache/drill/TestBugFixes.java
index 743aeae..bfa97d1 100644
--- a/exec/java-exec/src/test/java/org/apache/drill/TestBugFixes.java
+++ b/exec/java-exec/src/test/java/org/apache/drill/TestBugFixes.java
@@ -67,7 +67,12 @@ public class TestBugFixes extends BaseTestQuery {
// Should be "Failure while parsing sql. Node [rel#26:Subset#6.LOGICAL.ANY([]).[]] could not be implemented;".
// Drill will hit CanNotPlan, until we add code fix to transform the local LHS filter in left outer join properly.
public void testDRILL1337_LocalLeftFilterLeftOutJoin() throws Exception {
- test("select count(*) from cp.`tpch/nation.parquet` n left outer join cp.`tpch/region.parquet` r on n.n_regionkey = r.r_regionkey and n.n_nationkey > 10;");
+ try {
+ test("select count(*) from cp.`tpch/nation.parquet` n left outer join cp.`tpch/region.parquet` r on n.n_regionkey = r.r_regionkey and n.n_nationkey > 10;");
+ } catch (RpcException e) {
+ logger.info("***** Test resulted in expected failure: " + e.getMessage());
+ throw e;
+ }
}
@Test
http://git-wip-us.apache.org/repos/asf/incubator-drill/blob/d752487a/exec/java-exec/src/test/java/org/apache/drill/TestExampleQueries.java
----------------------------------------------------------------------
diff --git a/exec/java-exec/src/test/java/org/apache/drill/TestExampleQueries.java b/exec/java-exec/src/test/java/org/apache/drill/TestExampleQueries.java
index 8ac7c7d..8efd6bd 100644
--- a/exec/java-exec/src/test/java/org/apache/drill/TestExampleQueries.java
+++ b/exec/java-exec/src/test/java/org/apache/drill/TestExampleQueries.java
@@ -457,7 +457,12 @@ public class TestExampleQueries extends BaseTestQuery{
@Test(expected = RpcException.class) // Should get "At line 1, column 8: Column 'n_nationkey' is ambiguous"
public void testSelStarAmbiguousJoin() throws Exception {
- test("select x.n_nationkey, x.n_name, x.n_regionkey, x.r_name from (select * from cp.`tpch/nation.parquet` n, cp.`tpch/region.parquet` r where n.n_regionkey = r.r_regionkey) x " ) ;
+ try {
+ test("select x.n_nationkey, x.n_name, x.n_regionkey, x.r_name from (select * from cp.`tpch/nation.parquet` n, cp.`tpch/region.parquet` r where n.n_regionkey = r.r_regionkey) x " ) ;
+ } catch (RpcException e) {
+ logger.info("***** Test resulted in expected failure: " + e.getMessage());
+ throw e;
+ }
}
@Test // select star for a SchemaTable.