You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@nifi.apache.org by markAcomm <gi...@git.apache.org> on 2018/11/12 15:36:02 UTC

[GitHub] nifi issue #2901: NIFI-4246 - Client Credentials Grant based OAuth2 Controll...

Github user markAcomm commented on the issue:

    https://github.com/apache/nifi/pull/2901
  
    @jasonrogena,
    
    Thanks for moving this forward. Good to see this PR is keeping up with 1.8
    
    I noticed a small bug. In AbstractOAuthControllerService.java the property names look like they have a cut-and-paste error. Look for multiple properties with the line: 
    .Builder().name("JSON_response_access_token_name")
     
    At lines 91, 103 and 114. I am pretty sure those need different names. 
     
    Also, kudos for adding the scope property as this is pretty critical to using this against Google APIs. I am not sure how all OAuth services work when accepting scope, but in the case of Google, would it be best to use the new StandardValidators.URI_LIST_VALIDATOR ?



---