You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sling.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2015/05/14 14:13:00 UTC
[jira] [Commented] (SLING-4715) Event filter in
ResourceEventDistributionTrigger is wrongly configured
[ https://issues.apache.org/jira/browse/SLING-4715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14543550#comment-14543550 ]
ASF GitHub Bot commented on SLING-4715:
---------------------------------------
GitHub user maciusio opened a pull request:
https://github.com/apache/sling/pull/90
SLING-4715 - Event filter in ResourceEventDistributionTrigger is wrongly configured
You are setting event filter first to a given path and then to not handle events from other sling instances. But actually the path filter has been overriden. Probbaly you meant to have this filter configured like this.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/maciusio/sling trunk
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/sling/pull/90.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #90
----
commit 514ce5913ccbad9e1fdd1010a392f904806cb64b
Author: Maciej Dybek <ma...@cognifide.com>
Date: 2015-05-14T12:04:16Z
SLING-4715 - Event filter in ResourceEventDistributionTrigger is wrongly configured
----
> Event filter in ResourceEventDistributionTrigger is wrongly configured
> ----------------------------------------------------------------------
>
> Key: SLING-4715
> URL: https://issues.apache.org/jira/browse/SLING-4715
> Project: Sling
> Issue Type: Bug
> Components: Distribution
> Affects Versions: Content Distribution Core 0.1.1
> Reporter: Maciej Dybek
>
> In line 88 and 89 of [ResourceEventDistributionTrigger|https://github.com/apache/sling/blob/trunk/contrib/extensions/distribution/core/src/main/java/org/apache/sling/distribution/trigger/impl/ResourceEventDistributionTrigger.java] class we have:
> {code}
> properties.put(EventConstants.EVENT_FILTER, "(path=" + path + "/*)");
> properties.put(EventConstants.EVENT_FILTER, "(!(" + DEAConstants.PROPERTY_APPLICATION + "=*))");
> {code}
> That way the event filter for a specifi path (line 88) is overriden by a filter from line 99. Hence trigger is distributing too many distribution requests. They of course are skipped by allowedRoots property in SimpleDistributionAgent but nevertheless it's an issue.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)