You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@phoenix.apache.org by GitBox <gi...@apache.org> on 2021/11/03 21:25:45 UTC

[GitHub] [phoenix] ramatronics commented on pull request #1280: PHOENIX-6523: Support for HRpc connection protocol through JDBC URL

ramatronics commented on pull request #1280:
URL: https://github.com/apache/phoenix/pull/1280#issuecomment-960105984


   I moved Registry context to a separate package. I think it covers @joshelser's ask of starting to clean up the `PhoenixEmbeddedDriver`. It's an in-between to where we want to be ideally (@stoty as you pointed [out here](https://github.com/apache/phoenix/pull/1280#discussion_r698995791)) vs what we can do now realistically. 
   
   Created a class called `EmbeddedDriverContext` to pass between the EmbeddedDriver and the Registry classes. I tagged in comments with the 🥴 emoji places where the context is passed back and forth (unnecessarily perhaps) - so let me know if we should make any changes there.
   
   I think an integration test would really help here so I'm going to get started on that.
   
   CC: @dbwong @yanxinyi @virajjasani @apurtell 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@phoenix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org