You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by GitBox <gi...@apache.org> on 2020/07/18 18:33:19 UTC
[GitHub] [hadoop] surajj-naik opened a new pull request #2151: HDFS-15476: Make AsyncStream executor private
surajj-naik opened a new pull request #2151:
URL: https://github.com/apache/hadoop/pull/2151
The executor_ member of the AsyncStream class is public, but there is a getter get_executor() that returns this executor_ member. This member should be private.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org
[GitHub] [hadoop] hadoop-yetus commented on pull request #2151: HDFS-15476 Make AsyncStream executor private
Posted by GitBox <gi...@apache.org>.
hadoop-yetus commented on pull request #2151:
URL: https://github.com/apache/hadoop/pull/2151#issuecomment-660535309
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 1m 5s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
| -1 :x: | test4tests | 0m 0s | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. |
||| _ trunk Compile Tests _ |
| +1 :green_heart: | mvninstall | 24m 8s | trunk passed |
| +1 :green_heart: | compile | 2m 13s | trunk passed with JDK Ubuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04 |
| +1 :green_heart: | compile | 2m 6s | trunk passed with JDK Private Build-1.8.0_252-8u252-b09-1~18.04-b09 |
| +1 :green_heart: | mvnsite | 0m 20s | trunk passed |
| +1 :green_heart: | shadedclient | 44m 44s | branch has no errors when building and testing our client artifacts. |
||| _ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 0m 15s | the patch passed |
| -1 :x: | compile | 1m 28s | hadoop-hdfs-native-client in the patch failed with JDK Ubuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04. |
| -1 :x: | cc | 1m 28s | hadoop-hdfs-native-client in the patch failed with JDK Ubuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04. |
| -1 :x: | golang | 1m 28s | hadoop-hdfs-native-client in the patch failed with JDK Ubuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04. |
| -1 :x: | javac | 1m 28s | hadoop-hdfs-native-client in the patch failed with JDK Ubuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04. |
| -1 :x: | compile | 1m 31s | hadoop-hdfs-native-client in the patch failed with JDK Private Build-1.8.0_252-8u252-b09-1~18.04-b09. |
| -1 :x: | cc | 1m 31s | hadoop-hdfs-native-client in the patch failed with JDK Private Build-1.8.0_252-8u252-b09-1~18.04-b09. |
| -1 :x: | golang | 1m 31s | hadoop-hdfs-native-client in the patch failed with JDK Private Build-1.8.0_252-8u252-b09-1~18.04-b09. |
| -1 :x: | javac | 1m 31s | hadoop-hdfs-native-client in the patch failed with JDK Private Build-1.8.0_252-8u252-b09-1~18.04-b09. |
| +1 :green_heart: | mvnsite | 0m 14s | the patch passed |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
| +1 :green_heart: | shadedclient | 16m 34s | patch has no errors when building and testing our client artifacts. |
||| _ Other Tests _ |
| -1 :x: | unit | 1m 58s | hadoop-hdfs-native-client in the patch failed. |
| +1 :green_heart: | asflicense | 0m 38s | The patch does not generate ASF License warnings. |
| | | 71m 28s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.40 ServerAPI=1.40 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-2151/1/artifact/out/Dockerfile |
| GITHUB PR | https://github.com/apache/hadoop/pull/2151 |
| Optional Tests | dupname asflicense compile cc mvnsite javac unit golang |
| uname | Linux f0eb833aec8f 4.15.0-101-generic #102-Ubuntu SMP Mon May 11 10:07:26 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | personality/hadoop.sh |
| git revision | trunk / 99655167f30 |
| Default Java | Private Build-1.8.0_252-8u252-b09-1~18.04-b09 |
| Multi-JDK versions | /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_252-8u252-b09-1~18.04-b09 |
| compile | https://builds.apache.org/job/hadoop-multibranch/job/PR-2151/1/artifact/out/patch-compile-hadoop-hdfs-project_hadoop-hdfs-native-client-jdkUbuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04.txt |
| cc | https://builds.apache.org/job/hadoop-multibranch/job/PR-2151/1/artifact/out/patch-compile-hadoop-hdfs-project_hadoop-hdfs-native-client-jdkUbuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04.txt |
| golang | https://builds.apache.org/job/hadoop-multibranch/job/PR-2151/1/artifact/out/patch-compile-hadoop-hdfs-project_hadoop-hdfs-native-client-jdkUbuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04.txt |
| javac | https://builds.apache.org/job/hadoop-multibranch/job/PR-2151/1/artifact/out/patch-compile-hadoop-hdfs-project_hadoop-hdfs-native-client-jdkUbuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04.txt |
| compile | https://builds.apache.org/job/hadoop-multibranch/job/PR-2151/1/artifact/out/patch-compile-hadoop-hdfs-project_hadoop-hdfs-native-client-jdkPrivateBuild-1.8.0_252-8u252-b09-1~18.04-b09.txt |
| cc | https://builds.apache.org/job/hadoop-multibranch/job/PR-2151/1/artifact/out/patch-compile-hadoop-hdfs-project_hadoop-hdfs-native-client-jdkPrivateBuild-1.8.0_252-8u252-b09-1~18.04-b09.txt |
| golang | https://builds.apache.org/job/hadoop-multibranch/job/PR-2151/1/artifact/out/patch-compile-hadoop-hdfs-project_hadoop-hdfs-native-client-jdkPrivateBuild-1.8.0_252-8u252-b09-1~18.04-b09.txt |
| javac | https://builds.apache.org/job/hadoop-multibranch/job/PR-2151/1/artifact/out/patch-compile-hadoop-hdfs-project_hadoop-hdfs-native-client-jdkPrivateBuild-1.8.0_252-8u252-b09-1~18.04-b09.txt |
| unit | https://builds.apache.org/job/hadoop-multibranch/job/PR-2151/1/artifact/out/patch-unit-hadoop-hdfs-project_hadoop-hdfs-native-client.txt |
| Test Results | https://builds.apache.org/job/hadoop-multibranch/job/PR-2151/1/testReport/ |
| Max. process+thread count | 334 (vs. ulimit of 5500) |
| modules | C: hadoop-hdfs-project/hadoop-hdfs-native-client U: hadoop-hdfs-project/hadoop-hdfs-native-client |
| Console output | https://builds.apache.org/job/hadoop-multibranch/job/PR-2151/1/console |
| versions | git=2.17.1 maven=3.6.0 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org
[GitHub] [hadoop] GauthamBanasandra commented on a change in pull request #2151: HDFS-15476 Make AsyncStream executor private
Posted by GitBox <gi...@apache.org>.
GauthamBanasandra commented on a change in pull request #2151:
URL: https://github.com/apache/hadoop/pull/2151#discussion_r456912037
##########
File path: hadoop-hdfs-project/hadoop-hdfs-native-client/src/main/native/libhdfspp/lib/common/async_stream.h
##########
@@ -41,7 +41,6 @@ typedef boost::asio::const_buffers_1 ConstBuffer;
class AsyncStream {
public:
using executor_type = boost::asio::system_executor;
Review comment:
Could you try making this type alias private as well?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org
[GitHub] [hadoop] surajj-naik commented on a change in pull request #2151: HDFS-15476 Make AsyncStream executor private
Posted by GitBox <gi...@apache.org>.
surajj-naik commented on a change in pull request #2151:
URL: https://github.com/apache/hadoop/pull/2151#discussion_r456913663
##########
File path: hadoop-hdfs-project/hadoop-hdfs-native-client/src/main/native/libhdfspp/lib/common/async_stream.h
##########
@@ -41,7 +41,6 @@ typedef boost::asio::const_buffers_1 ConstBuffer;
class AsyncStream {
public:
using executor_type = boost::asio::system_executor;
Review comment:
I tried that, but it seems to be referred by block_reader and datatransfer in lib/reader
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org
[GitHub] [hadoop] GauthamBanasandra commented on a change in pull request #2151: HDFS-15476 Make AsyncStream executor private
Posted by GitBox <gi...@apache.org>.
GauthamBanasandra commented on a change in pull request #2151:
URL: https://github.com/apache/hadoop/pull/2151#discussion_r456919384
##########
File path: hadoop-hdfs-project/hadoop-hdfs-native-client/src/main/native/libhdfspp/lib/common/async_stream.h
##########
@@ -41,7 +41,6 @@ typedef boost::asio::const_buffers_1 ConstBuffer;
class AsyncStream {
public:
using executor_type = boost::asio::system_executor;
Review comment:
Ok. Thanks Suraj. You may resolve my comment.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org
[GitHub] [hadoop] hadoop-yetus commented on pull request #2151: HDFS-15476 Make AsyncStream executor private
Posted by GitBox <gi...@apache.org>.
hadoop-yetus commented on pull request #2151:
URL: https://github.com/apache/hadoop/pull/2151#issuecomment-660621755
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 1m 14s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
| -1 :x: | test4tests | 0m 0s | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. |
||| _ trunk Compile Tests _ |
| +1 :green_heart: | mvninstall | 25m 25s | trunk passed |
| +1 :green_heart: | compile | 2m 49s | trunk passed with JDK Ubuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04 |
| +1 :green_heart: | compile | 2m 36s | trunk passed with JDK Private Build-1.8.0_252-8u252-b09-1~18.04-b09 |
| +1 :green_heart: | mvnsite | 0m 22s | trunk passed |
| +1 :green_heart: | shadedclient | 49m 48s | branch has no errors when building and testing our client artifacts. |
||| _ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 0m 17s | the patch passed |
| +1 :green_heart: | compile | 2m 26s | the patch passed with JDK Ubuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04 |
| +1 :green_heart: | cc | 2m 26s | the patch passed |
| +1 :green_heart: | golang | 2m 26s | the patch passed |
| +1 :green_heart: | javac | 2m 26s | the patch passed |
| +1 :green_heart: | compile | 2m 25s | the patch passed with JDK Private Build-1.8.0_252-8u252-b09-1~18.04-b09 |
| +1 :green_heart: | cc | 2m 25s | the patch passed |
| +1 :green_heart: | golang | 2m 25s | the patch passed |
| +1 :green_heart: | javac | 2m 25s | the patch passed |
| +1 :green_heart: | mvnsite | 0m 19s | the patch passed |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
| +1 :green_heart: | shadedclient | 17m 40s | patch has no errors when building and testing our client artifacts. |
||| _ Other Tests _ |
| +1 :green_heart: | unit | 9m 16s | hadoop-hdfs-native-client in the patch passed. |
| +1 :green_heart: | asflicense | 0m 32s | The patch does not generate ASF License warnings. |
| | | 86m 36s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.40 ServerAPI=1.40 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-2151/2/artifact/out/Dockerfile |
| GITHUB PR | https://github.com/apache/hadoop/pull/2151 |
| Optional Tests | dupname asflicense compile cc mvnsite javac unit golang |
| uname | Linux b3bff816ec7e 4.15.0-101-generic #102-Ubuntu SMP Mon May 11 10:07:26 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | personality/hadoop.sh |
| git revision | trunk / 99655167f30 |
| Default Java | Private Build-1.8.0_252-8u252-b09-1~18.04-b09 |
| Multi-JDK versions | /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_252-8u252-b09-1~18.04-b09 |
| Test Results | https://builds.apache.org/job/hadoop-multibranch/job/PR-2151/2/testReport/ |
| Max. process+thread count | 335 (vs. ulimit of 5500) |
| modules | C: hadoop-hdfs-project/hadoop-hdfs-native-client U: hadoop-hdfs-project/hadoop-hdfs-native-client |
| Console output | https://builds.apache.org/job/hadoop-multibranch/job/PR-2151/2/console |
| versions | git=2.17.1 maven=3.6.0 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org
[GitHub] [hadoop] surendralilhore merged pull request #2151: HDFS-15476 Make AsyncStream executor private
Posted by GitBox <gi...@apache.org>.
surendralilhore merged pull request #2151:
URL: https://github.com/apache/hadoop/pull/2151
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org
[GitHub] [hadoop] surendralilhore commented on pull request #2151: HDFS-15476 Make AsyncStream executor private
Posted by GitBox <gi...@apache.org>.
surendralilhore commented on pull request #2151:
URL: https://github.com/apache/hadoop/pull/2151#issuecomment-660683818
Thanks @surajj-naik for contribution and @GauthamBanasandra for review
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org
[GitHub] [hadoop] surendralilhore commented on pull request #2151: HDFS-15476 Make AsyncStream executor private
Posted by GitBox <gi...@apache.org>.
surendralilhore commented on pull request #2151:
URL: https://github.com/apache/hadoop/pull/2151#issuecomment-660683236
+1
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org