You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2019/12/29 20:52:27 UTC
[GitHub] [airflow] tooptoop4 opened a new pull request #6956: [AIRFLOW-6387]
print details of success/skipped task
tooptoop4 opened a new pull request #6956: [AIRFLOW-6387] print details of success/skipped task
URL: https://github.com/apache/airflow/pull/6956
Make sure you have checked _all_ steps below.
### Jira
- [ ] My PR addresses the following [Airflow Jira](https://issues.apache.org/jira/browse/AIRFLOW/) issues and references them in the PR title. For example, "\[AIRFLOW-XXX\] My Airflow PR"
- https://issues.apache.org/jira/browse/AIRFLOW-XXX
- In case you are fixing a typo in the documentation you can prepend your commit with \[AIRFLOW-XXX\], code changes always need a Jira issue.
- In case you are proposing a fundamental code change, you need to create an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)).
- In case you are adding a dependency, check if the license complies with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
### Description
- [ ] Here are some details about my PR, including screenshots of any UI changes:
### Tests
- [ ] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason:
### Commits
- [ ] My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
### Documentation
- [ ] In case of new functionality, my PR adds documentation that describes how to use it.
- All the public functions and the classes in the PR contain docstrings that explain what it does
- If you implement backwards incompatible changes, please leave a note in the [Updating.md](https://github.com/apache/airflow/blob/master/UPDATING.md) so we can assign it to a appropriate release
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] potiuk commented on a change in pull request #6956:
[AIRFLOW-6387] print details of success/skipped task
Posted by GitBox <gi...@apache.org>.
potiuk commented on a change in pull request #6956: [AIRFLOW-6387] print details of success/skipped task
URL: https://github.com/apache/airflow/pull/6956#discussion_r363110082
##########
File path: airflow/models/taskinstance.py
##########
@@ -964,11 +964,23 @@ def signal_handler(signum, frame):
self.refresh_from_db(lock_for_update=True)
self.state = State.SUCCESS
except AirflowSkipException as e:
+ # Recording SKIP
# log only if exception has any arguments to prevent log flooding
if e.args:
self.log.info(e)
self.refresh_from_db(lock_for_update=True)
self.state = State.SKIPPED
+ try:
+ self.log.info(
+ 'Marking task as SKIPPED.'
+ 'dag_id=%s, task_id=%s, execution_date=%s, start_date=%s, end_date=%s',
+ self.dag_id,
+ self.task_id,
+ self.execution_date.strftime('%Y%m%dT%H%M%S') if self.execution_date else '',
+ self.start_date.strftime('%Y%m%dT%H%M%S') if self.start_date else '',
Review comment:
```suggestion
self.start_date.strftime('%Y%m%dT%H%M%S') if hasattr('start_date') and self.start_date else '',
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #6956:
[AIRFLOW-6387] print details of success/skipped task
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #6956: [AIRFLOW-6387] print details of success/skipped task
URL: https://github.com/apache/airflow/pull/6956#issuecomment-570083400
# [Codecov](https://codecov.io/gh/apache/airflow/pull/6956?src=pr&el=h1) Report
> Merging [#6956](https://codecov.io/gh/apache/airflow/pull/6956?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/5e100ab753635521d33f287bdffd3d9bd4c6ae0f?src=pr&el=desc) will **decrease** coverage by `<.01%`.
> The diff coverage is `100%`.
[](https://codecov.io/gh/apache/airflow/pull/6956?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6956 +/- ##
==========================================
- Coverage 84.7% 84.69% -0.01%
==========================================
Files 679 679
Lines 38488 38666 +178
==========================================
+ Hits 32600 32748 +148
- Misses 5888 5918 +30
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/6956?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/models/taskinstance.py](https://codecov.io/gh/apache/airflow/pull/6956/diff?src=pr&el=tree#diff-YWlyZmxvdy9tb2RlbHMvdGFza2luc3RhbmNlLnB5) | `94.92% <100%> (+0.01%)` | :arrow_up: |
| [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/6956/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
| [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/6956/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
| [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/6956/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: |
| [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/6956/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: |
| [...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/6956/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==) | `78.75% <0%> (-20%)` | :arrow_down: |
| [airflow/utils/file.py](https://codecov.io/gh/apache/airflow/pull/6956/diff?src=pr&el=tree#diff-YWlyZmxvdy91dGlscy9maWxlLnB5) | `86.3% <0%> (-5.17%)` | :arrow_down: |
| [airflow/configuration.py](https://codecov.io/gh/apache/airflow/pull/6956/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb25maWd1cmF0aW9uLnB5) | `91.43% <0%> (-1.22%)` | :arrow_down: |
| [airflow/utils/helpers.py](https://codecov.io/gh/apache/airflow/pull/6956/diff?src=pr&el=tree#diff-YWlyZmxvdy91dGlscy9oZWxwZXJzLnB5) | `81.69% <0%> (-1.06%)` | :arrow_down: |
| [airflow/utils/log/es\_task\_handler.py](https://codecov.io/gh/apache/airflow/pull/6956/diff?src=pr&el=tree#diff-YWlyZmxvdy91dGlscy9sb2cvZXNfdGFza19oYW5kbGVyLnB5) | `93.39% <0%> (-0.78%)` | :arrow_down: |
| ... and [80 more](https://codecov.io/gh/apache/airflow/pull/6956/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/6956?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/6956?src=pr&el=footer). Last update [5e100ab...3bdf12d](https://codecov.io/gh/apache/airflow/pull/6956?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #6956:
[AIRFLOW-6387] print details of success/skipped task
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #6956: [AIRFLOW-6387] print details of success/skipped task
URL: https://github.com/apache/airflow/pull/6956#issuecomment-570083400
# [Codecov](https://codecov.io/gh/apache/airflow/pull/6956?src=pr&el=h1) Report
> Merging [#6956](https://codecov.io/gh/apache/airflow/pull/6956?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/7d97d16c47ba181839fd583b8653d2872dc4290b?src=pr&el=desc) will **decrease** coverage by `0.01%`.
> The diff coverage is `100%`.
[](https://codecov.io/gh/apache/airflow/pull/6956?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6956 +/- ##
==========================================
- Coverage 84.7% 84.69% -0.02%
==========================================
Files 680 679 -1
Lines 38556 38666 +110
==========================================
+ Hits 32659 32748 +89
- Misses 5897 5918 +21
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/6956?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/models/taskinstance.py](https://codecov.io/gh/apache/airflow/pull/6956/diff?src=pr&el=tree#diff-YWlyZmxvdy9tb2RlbHMvdGFza2luc3RhbmNlLnB5) | `94.92% <100%> (+0.01%)` | :arrow_up: |
| [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/6956/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
| [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/6956/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
| [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/6956/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: |
| [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/6956/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: |
| [...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/6956/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==) | `78.75% <0%> (-20%)` | :arrow_down: |
| [airflow/utils/file.py](https://codecov.io/gh/apache/airflow/pull/6956/diff?src=pr&el=tree#diff-YWlyZmxvdy91dGlscy9maWxlLnB5) | `86.3% <0%> (-5.17%)` | :arrow_down: |
| [airflow/utils/cli.py](https://codecov.io/gh/apache/airflow/pull/6956/diff?src=pr&el=tree#diff-YWlyZmxvdy91dGlscy9jbGkucHk=) | `68.75% <0%> (-2.95%)` | :arrow_down: |
| [airflow/configuration.py](https://codecov.io/gh/apache/airflow/pull/6956/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb25maWd1cmF0aW9uLnB5) | `91.43% <0%> (-1.22%)` | :arrow_down: |
| [airflow/utils/helpers.py](https://codecov.io/gh/apache/airflow/pull/6956/diff?src=pr&el=tree#diff-YWlyZmxvdy91dGlscy9oZWxwZXJzLnB5) | `81.69% <0%> (-1.06%)` | :arrow_down: |
| ... and [85 more](https://codecov.io/gh/apache/airflow/pull/6956/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/6956?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/6956?src=pr&el=footer). Last update [7d97d16...3bdf12d](https://codecov.io/gh/apache/airflow/pull/6956?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #6956:
[AIRFLOW-6387] print details of success/skipped task
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #6956: [AIRFLOW-6387] print details of success/skipped task
URL: https://github.com/apache/airflow/pull/6956#issuecomment-570083400
# [Codecov](https://codecov.io/gh/apache/airflow/pull/6956?src=pr&el=h1) Report
> Merging [#6956](https://codecov.io/gh/apache/airflow/pull/6956?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/7d97d16c47ba181839fd583b8653d2872dc4290b?src=pr&el=desc) will **decrease** coverage by `0.01%`.
> The diff coverage is `100%`.
[](https://codecov.io/gh/apache/airflow/pull/6956?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6956 +/- ##
==========================================
- Coverage 84.7% 84.69% -0.02%
==========================================
Files 680 679 -1
Lines 38556 38666 +110
==========================================
+ Hits 32659 32748 +89
- Misses 5897 5918 +21
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/6956?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/models/taskinstance.py](https://codecov.io/gh/apache/airflow/pull/6956/diff?src=pr&el=tree#diff-YWlyZmxvdy9tb2RlbHMvdGFza2luc3RhbmNlLnB5) | `94.92% <100%> (+0.01%)` | :arrow_up: |
| [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/6956/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
| [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/6956/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
| [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/6956/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: |
| [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/6956/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: |
| [...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/6956/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==) | `78.75% <0%> (-20%)` | :arrow_down: |
| [airflow/utils/file.py](https://codecov.io/gh/apache/airflow/pull/6956/diff?src=pr&el=tree#diff-YWlyZmxvdy91dGlscy9maWxlLnB5) | `86.3% <0%> (-5.17%)` | :arrow_down: |
| [airflow/utils/cli.py](https://codecov.io/gh/apache/airflow/pull/6956/diff?src=pr&el=tree#diff-YWlyZmxvdy91dGlscy9jbGkucHk=) | `68.75% <0%> (-2.95%)` | :arrow_down: |
| [airflow/configuration.py](https://codecov.io/gh/apache/airflow/pull/6956/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb25maWd1cmF0aW9uLnB5) | `91.43% <0%> (-1.22%)` | :arrow_down: |
| [airflow/utils/helpers.py](https://codecov.io/gh/apache/airflow/pull/6956/diff?src=pr&el=tree#diff-YWlyZmxvdy91dGlscy9oZWxwZXJzLnB5) | `81.69% <0%> (-1.06%)` | :arrow_down: |
| ... and [85 more](https://codecov.io/gh/apache/airflow/pull/6956/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/6956?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/6956?src=pr&el=footer). Last update [7d97d16...3bdf12d](https://codecov.io/gh/apache/airflow/pull/6956?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #6956:
[AIRFLOW-6387] print details of success/skipped task
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #6956: [AIRFLOW-6387] print details of success/skipped task
URL: https://github.com/apache/airflow/pull/6956#issuecomment-570083400
# [Codecov](https://codecov.io/gh/apache/airflow/pull/6956?src=pr&el=h1) Report
> Merging [#6956](https://codecov.io/gh/apache/airflow/pull/6956?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/5e100ab753635521d33f287bdffd3d9bd4c6ae0f?src=pr&el=desc) will **decrease** coverage by `<.01%`.
> The diff coverage is `100%`.
[](https://codecov.io/gh/apache/airflow/pull/6956?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6956 +/- ##
==========================================
- Coverage 84.7% 84.69% -0.01%
==========================================
Files 679 679
Lines 38488 38666 +178
==========================================
+ Hits 32600 32748 +148
- Misses 5888 5918 +30
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/6956?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/models/taskinstance.py](https://codecov.io/gh/apache/airflow/pull/6956/diff?src=pr&el=tree#diff-YWlyZmxvdy9tb2RlbHMvdGFza2luc3RhbmNlLnB5) | `94.92% <100%> (+0.01%)` | :arrow_up: |
| [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/6956/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
| [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/6956/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
| [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/6956/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: |
| [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/6956/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: |
| [...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/6956/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==) | `78.75% <0%> (-20%)` | :arrow_down: |
| [airflow/utils/file.py](https://codecov.io/gh/apache/airflow/pull/6956/diff?src=pr&el=tree#diff-YWlyZmxvdy91dGlscy9maWxlLnB5) | `86.3% <0%> (-5.17%)` | :arrow_down: |
| [airflow/configuration.py](https://codecov.io/gh/apache/airflow/pull/6956/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb25maWd1cmF0aW9uLnB5) | `91.43% <0%> (-1.22%)` | :arrow_down: |
| [airflow/utils/helpers.py](https://codecov.io/gh/apache/airflow/pull/6956/diff?src=pr&el=tree#diff-YWlyZmxvdy91dGlscy9oZWxwZXJzLnB5) | `81.69% <0%> (-1.06%)` | :arrow_down: |
| [airflow/utils/log/es\_task\_handler.py](https://codecov.io/gh/apache/airflow/pull/6956/diff?src=pr&el=tree#diff-YWlyZmxvdy91dGlscy9sb2cvZXNfdGFza19oYW5kbGVyLnB5) | `93.39% <0%> (-0.78%)` | :arrow_down: |
| ... and [80 more](https://codecov.io/gh/apache/airflow/pull/6956/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/6956?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/6956?src=pr&el=footer). Last update [5e100ab...3bdf12d](https://codecov.io/gh/apache/airflow/pull/6956?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #6956:
[AIRFLOW-6387] print details of success/skipped task
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #6956: [AIRFLOW-6387] print details of success/skipped task
URL: https://github.com/apache/airflow/pull/6956#issuecomment-570083400
# [Codecov](https://codecov.io/gh/apache/airflow/pull/6956?src=pr&el=h1) Report
> Merging [#6956](https://codecov.io/gh/apache/airflow/pull/6956?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/7d97d16c47ba181839fd583b8653d2872dc4290b?src=pr&el=desc) will **decrease** coverage by `0.01%`.
> The diff coverage is `100%`.
[](https://codecov.io/gh/apache/airflow/pull/6956?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6956 +/- ##
==========================================
- Coverage 84.7% 84.69% -0.02%
==========================================
Files 680 679 -1
Lines 38556 38666 +110
==========================================
+ Hits 32659 32748 +89
- Misses 5897 5918 +21
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/6956?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/models/taskinstance.py](https://codecov.io/gh/apache/airflow/pull/6956/diff?src=pr&el=tree#diff-YWlyZmxvdy9tb2RlbHMvdGFza2luc3RhbmNlLnB5) | `94.92% <100%> (+0.01%)` | :arrow_up: |
| [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/6956/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
| [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/6956/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
| [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/6956/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: |
| [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/6956/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: |
| [...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/6956/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==) | `78.75% <0%> (-20%)` | :arrow_down: |
| [airflow/utils/file.py](https://codecov.io/gh/apache/airflow/pull/6956/diff?src=pr&el=tree#diff-YWlyZmxvdy91dGlscy9maWxlLnB5) | `86.3% <0%> (-5.17%)` | :arrow_down: |
| [airflow/utils/cli.py](https://codecov.io/gh/apache/airflow/pull/6956/diff?src=pr&el=tree#diff-YWlyZmxvdy91dGlscy9jbGkucHk=) | `68.75% <0%> (-2.95%)` | :arrow_down: |
| [airflow/configuration.py](https://codecov.io/gh/apache/airflow/pull/6956/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb25maWd1cmF0aW9uLnB5) | `91.43% <0%> (-1.22%)` | :arrow_down: |
| [airflow/utils/helpers.py](https://codecov.io/gh/apache/airflow/pull/6956/diff?src=pr&el=tree#diff-YWlyZmxvdy91dGlscy9oZWxwZXJzLnB5) | `81.69% <0%> (-1.06%)` | :arrow_down: |
| ... and [85 more](https://codecov.io/gh/apache/airflow/pull/6956/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/6956?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/6956?src=pr&el=footer). Last update [7d97d16...3bdf12d](https://codecov.io/gh/apache/airflow/pull/6956?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #6956:
[AIRFLOW-6387] print details of success/skipped task
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #6956: [AIRFLOW-6387] print details of success/skipped task
URL: https://github.com/apache/airflow/pull/6956#issuecomment-570083400
# [Codecov](https://codecov.io/gh/apache/airflow/pull/6956?src=pr&el=h1) Report
> Merging [#6956](https://codecov.io/gh/apache/airflow/pull/6956?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/5e100ab753635521d33f287bdffd3d9bd4c6ae0f?src=pr&el=desc) will **decrease** coverage by `<.01%`.
> The diff coverage is `100%`.
[](https://codecov.io/gh/apache/airflow/pull/6956?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6956 +/- ##
==========================================
- Coverage 84.7% 84.69% -0.01%
==========================================
Files 679 679
Lines 38488 38666 +178
==========================================
+ Hits 32600 32748 +148
- Misses 5888 5918 +30
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/6956?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/models/taskinstance.py](https://codecov.io/gh/apache/airflow/pull/6956/diff?src=pr&el=tree#diff-YWlyZmxvdy9tb2RlbHMvdGFza2luc3RhbmNlLnB5) | `94.92% <100%> (+0.01%)` | :arrow_up: |
| [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/6956/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
| [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/6956/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
| [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/6956/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: |
| [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/6956/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: |
| [...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/6956/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==) | `78.75% <0%> (-20%)` | :arrow_down: |
| [airflow/utils/file.py](https://codecov.io/gh/apache/airflow/pull/6956/diff?src=pr&el=tree#diff-YWlyZmxvdy91dGlscy9maWxlLnB5) | `86.3% <0%> (-5.17%)` | :arrow_down: |
| [airflow/configuration.py](https://codecov.io/gh/apache/airflow/pull/6956/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb25maWd1cmF0aW9uLnB5) | `91.43% <0%> (-1.22%)` | :arrow_down: |
| [airflow/utils/helpers.py](https://codecov.io/gh/apache/airflow/pull/6956/diff?src=pr&el=tree#diff-YWlyZmxvdy91dGlscy9oZWxwZXJzLnB5) | `81.69% <0%> (-1.06%)` | :arrow_down: |
| [airflow/utils/log/es\_task\_handler.py](https://codecov.io/gh/apache/airflow/pull/6956/diff?src=pr&el=tree#diff-YWlyZmxvdy91dGlscy9sb2cvZXNfdGFza19oYW5kbGVyLnB5) | `93.39% <0%> (-0.78%)` | :arrow_down: |
| ... and [80 more](https://codecov.io/gh/apache/airflow/pull/6956/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/6956?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/6956?src=pr&el=footer). Last update [5e100ab...3bdf12d](https://codecov.io/gh/apache/airflow/pull/6956?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] tooptoop4 commented on issue #6956: [AIRFLOW-6387] print
details of success/skipped task
Posted by GitBox <gi...@apache.org>.
tooptoop4 commented on issue #6956: [AIRFLOW-6387] print details of success/skipped task
URL: https://github.com/apache/airflow/pull/6956#issuecomment-571332355
@potiuk pls merge
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] potiuk commented on issue #6956: [AIRFLOW-6387] print
details of success/skipped task
Posted by GitBox <gi...@apache.org>.
potiuk commented on issue #6956: [AIRFLOW-6387] print details of success/skipped task
URL: https://github.com/apache/airflow/pull/6956#issuecomment-569541577
Love it. This is really useful to know what's going on!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] tooptoop4 removed a comment on issue #6956:
[AIRFLOW-6387] print details of success/skipped task
Posted by GitBox <gi...@apache.org>.
tooptoop4 removed a comment on issue #6956: [AIRFLOW-6387] print details of success/skipped task
URL: https://github.com/apache/airflow/pull/6956#issuecomment-570893702
@potiuk gentle ping
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #6956:
[AIRFLOW-6387] print details of success/skipped task
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #6956: [AIRFLOW-6387] print details of success/skipped task
URL: https://github.com/apache/airflow/pull/6956#issuecomment-570083400
# [Codecov](https://codecov.io/gh/apache/airflow/pull/6956?src=pr&el=h1) Report
> Merging [#6956](https://codecov.io/gh/apache/airflow/pull/6956?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/5e100ab753635521d33f287bdffd3d9bd4c6ae0f?src=pr&el=desc) will **decrease** coverage by `0.13%`.
> The diff coverage is `60%`.
[](https://codecov.io/gh/apache/airflow/pull/6956?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6956 +/- ##
==========================================
- Coverage 84.7% 84.56% -0.14%
==========================================
Files 679 679
Lines 38488 38541 +53
==========================================
- Hits 32600 32591 -9
- Misses 5888 5950 +62
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/6956?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/models/taskinstance.py](https://codecov.io/gh/apache/airflow/pull/6956/diff?src=pr&el=tree#diff-YWlyZmxvdy9tb2RlbHMvdGFza2luc3RhbmNlLnB5) | `94.66% <60%> (-0.26%)` | :arrow_down: |
| [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/6956/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
| [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/6956/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
| [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/6956/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: |
| [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/6956/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: |
| [...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/6956/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==) | `78.75% <0%> (-20%)` | :arrow_down: |
| [airflow/utils/file.py](https://codecov.io/gh/apache/airflow/pull/6956/diff?src=pr&el=tree#diff-YWlyZmxvdy91dGlscy9maWxlLnB5) | `86.3% <0%> (-5.17%)` | :arrow_down: |
| [airflow/utils/helpers.py](https://codecov.io/gh/apache/airflow/pull/6956/diff?src=pr&el=tree#diff-YWlyZmxvdy91dGlscy9oZWxwZXJzLnB5) | `81.69% <0%> (-1.06%)` | :arrow_down: |
| [airflow/contrib/sensors/bash\_sensor.py](https://codecov.io/gh/apache/airflow/pull/6956/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL3NlbnNvcnMvYmFzaF9zZW5zb3IucHk=) | `93.93% <0%> (-0.18%)` | :arrow_down: |
| [airflow/hooks/pig\_hook.py](https://codecov.io/gh/apache/airflow/pull/6956/diff?src=pr&el=tree#diff-YWlyZmxvdy9ob29rcy9waWdfaG9vay5weQ==) | `95.34% <0%> (-0.11%)` | :arrow_down: |
| ... and [24 more](https://codecov.io/gh/apache/airflow/pull/6956/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/6956?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/6956?src=pr&el=footer). Last update [5e100ab...341f976](https://codecov.io/gh/apache/airflow/pull/6956?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #6956:
[AIRFLOW-6387] print details of success/skipped task
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #6956: [AIRFLOW-6387] print details of success/skipped task
URL: https://github.com/apache/airflow/pull/6956#issuecomment-570083400
# [Codecov](https://codecov.io/gh/apache/airflow/pull/6956?src=pr&el=h1) Report
> Merging [#6956](https://codecov.io/gh/apache/airflow/pull/6956?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/5e100ab753635521d33f287bdffd3d9bd4c6ae0f?src=pr&el=desc) will **decrease** coverage by `0.13%`.
> The diff coverage is `60%`.
[](https://codecov.io/gh/apache/airflow/pull/6956?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6956 +/- ##
==========================================
- Coverage 84.7% 84.56% -0.14%
==========================================
Files 679 679
Lines 38488 38541 +53
==========================================
- Hits 32600 32591 -9
- Misses 5888 5950 +62
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/6956?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/models/taskinstance.py](https://codecov.io/gh/apache/airflow/pull/6956/diff?src=pr&el=tree#diff-YWlyZmxvdy9tb2RlbHMvdGFza2luc3RhbmNlLnB5) | `94.66% <60%> (-0.26%)` | :arrow_down: |
| [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/6956/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
| [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/6956/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
| [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/6956/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: |
| [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/6956/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: |
| [...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/6956/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==) | `78.75% <0%> (-20%)` | :arrow_down: |
| [airflow/utils/file.py](https://codecov.io/gh/apache/airflow/pull/6956/diff?src=pr&el=tree#diff-YWlyZmxvdy91dGlscy9maWxlLnB5) | `86.3% <0%> (-5.17%)` | :arrow_down: |
| [airflow/utils/helpers.py](https://codecov.io/gh/apache/airflow/pull/6956/diff?src=pr&el=tree#diff-YWlyZmxvdy91dGlscy9oZWxwZXJzLnB5) | `81.69% <0%> (-1.06%)` | :arrow_down: |
| [airflow/contrib/sensors/bash\_sensor.py](https://codecov.io/gh/apache/airflow/pull/6956/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL3NlbnNvcnMvYmFzaF9zZW5zb3IucHk=) | `93.93% <0%> (-0.18%)` | :arrow_down: |
| [airflow/hooks/pig\_hook.py](https://codecov.io/gh/apache/airflow/pull/6956/diff?src=pr&el=tree#diff-YWlyZmxvdy9ob29rcy9waWdfaG9vay5weQ==) | `95.34% <0%> (-0.11%)` | :arrow_down: |
| ... and [24 more](https://codecov.io/gh/apache/airflow/pull/6956/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/6956?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/6956?src=pr&el=footer). Last update [5e100ab...341f976](https://codecov.io/gh/apache/airflow/pull/6956?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #6956:
[AIRFLOW-6387] print details of success/skipped task
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #6956: [AIRFLOW-6387] print details of success/skipped task
URL: https://github.com/apache/airflow/pull/6956#issuecomment-570083400
# [Codecov](https://codecov.io/gh/apache/airflow/pull/6956?src=pr&el=h1) Report
> Merging [#6956](https://codecov.io/gh/apache/airflow/pull/6956?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/5e100ab753635521d33f287bdffd3d9bd4c6ae0f?src=pr&el=desc) will **decrease** coverage by `0.13%`.
> The diff coverage is `60%`.
[](https://codecov.io/gh/apache/airflow/pull/6956?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6956 +/- ##
==========================================
- Coverage 84.7% 84.56% -0.14%
==========================================
Files 679 679
Lines 38488 38541 +53
==========================================
- Hits 32600 32591 -9
- Misses 5888 5950 +62
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/6956?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/models/taskinstance.py](https://codecov.io/gh/apache/airflow/pull/6956/diff?src=pr&el=tree#diff-YWlyZmxvdy9tb2RlbHMvdGFza2luc3RhbmNlLnB5) | `94.66% <60%> (-0.26%)` | :arrow_down: |
| [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/6956/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
| [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/6956/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
| [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/6956/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: |
| [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/6956/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: |
| [...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/6956/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==) | `78.75% <0%> (-20%)` | :arrow_down: |
| [airflow/utils/file.py](https://codecov.io/gh/apache/airflow/pull/6956/diff?src=pr&el=tree#diff-YWlyZmxvdy91dGlscy9maWxlLnB5) | `86.3% <0%> (-5.17%)` | :arrow_down: |
| [airflow/utils/helpers.py](https://codecov.io/gh/apache/airflow/pull/6956/diff?src=pr&el=tree#diff-YWlyZmxvdy91dGlscy9oZWxwZXJzLnB5) | `81.69% <0%> (-1.06%)` | :arrow_down: |
| [airflow/contrib/sensors/bash\_sensor.py](https://codecov.io/gh/apache/airflow/pull/6956/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL3NlbnNvcnMvYmFzaF9zZW5zb3IucHk=) | `93.93% <0%> (-0.18%)` | :arrow_down: |
| [airflow/hooks/pig\_hook.py](https://codecov.io/gh/apache/airflow/pull/6956/diff?src=pr&el=tree#diff-YWlyZmxvdy9ob29rcy9waWdfaG9vay5weQ==) | `95.34% <0%> (-0.11%)` | :arrow_down: |
| ... and [24 more](https://codecov.io/gh/apache/airflow/pull/6956/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/6956?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/6956?src=pr&el=footer). Last update [5e100ab...341f976](https://codecov.io/gh/apache/airflow/pull/6956?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io commented on issue #6956: [AIRFLOW-6387] print
details of success/skipped task
Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #6956: [AIRFLOW-6387] print details of success/skipped task
URL: https://github.com/apache/airflow/pull/6956#issuecomment-570083400
# [Codecov](https://codecov.io/gh/apache/airflow/pull/6956?src=pr&el=h1) Report
> Merging [#6956](https://codecov.io/gh/apache/airflow/pull/6956?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/5e100ab753635521d33f287bdffd3d9bd4c6ae0f?src=pr&el=desc) will **decrease** coverage by `0.13%`.
> The diff coverage is `60%`.
[](https://codecov.io/gh/apache/airflow/pull/6956?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6956 +/- ##
==========================================
- Coverage 84.7% 84.56% -0.14%
==========================================
Files 679 679
Lines 38488 38541 +53
==========================================
- Hits 32600 32591 -9
- Misses 5888 5950 +62
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/6956?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/models/taskinstance.py](https://codecov.io/gh/apache/airflow/pull/6956/diff?src=pr&el=tree#diff-YWlyZmxvdy9tb2RlbHMvdGFza2luc3RhbmNlLnB5) | `94.66% <60%> (-0.26%)` | :arrow_down: |
| [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/6956/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
| [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/6956/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
| [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/6956/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: |
| [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/6956/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: |
| [...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/6956/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==) | `78.75% <0%> (-20%)` | :arrow_down: |
| [airflow/utils/file.py](https://codecov.io/gh/apache/airflow/pull/6956/diff?src=pr&el=tree#diff-YWlyZmxvdy91dGlscy9maWxlLnB5) | `86.3% <0%> (-5.17%)` | :arrow_down: |
| [airflow/utils/helpers.py](https://codecov.io/gh/apache/airflow/pull/6956/diff?src=pr&el=tree#diff-YWlyZmxvdy91dGlscy9oZWxwZXJzLnB5) | `81.69% <0%> (-1.06%)` | :arrow_down: |
| [airflow/contrib/sensors/bash\_sensor.py](https://codecov.io/gh/apache/airflow/pull/6956/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL3NlbnNvcnMvYmFzaF9zZW5zb3IucHk=) | `93.93% <0%> (-0.18%)` | :arrow_down: |
| [airflow/hooks/pig\_hook.py](https://codecov.io/gh/apache/airflow/pull/6956/diff?src=pr&el=tree#diff-YWlyZmxvdy9ob29rcy9waWdfaG9vay5weQ==) | `95.34% <0%> (-0.11%)` | :arrow_down: |
| ... and [24 more](https://codecov.io/gh/apache/airflow/pull/6956/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/6956?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/6956?src=pr&el=footer). Last update [5e100ab...341f976](https://codecov.io/gh/apache/airflow/pull/6956?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #6956:
[AIRFLOW-6387] print details of success/skipped task
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #6956: [AIRFLOW-6387] print details of success/skipped task
URL: https://github.com/apache/airflow/pull/6956#issuecomment-570083400
# [Codecov](https://codecov.io/gh/apache/airflow/pull/6956?src=pr&el=h1) Report
> Merging [#6956](https://codecov.io/gh/apache/airflow/pull/6956?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/5e100ab753635521d33f287bdffd3d9bd4c6ae0f?src=pr&el=desc) will **decrease** coverage by `0.13%`.
> The diff coverage is `60%`.
[](https://codecov.io/gh/apache/airflow/pull/6956?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6956 +/- ##
==========================================
- Coverage 84.7% 84.56% -0.14%
==========================================
Files 679 679
Lines 38488 38541 +53
==========================================
- Hits 32600 32591 -9
- Misses 5888 5950 +62
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/6956?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/models/taskinstance.py](https://codecov.io/gh/apache/airflow/pull/6956/diff?src=pr&el=tree#diff-YWlyZmxvdy9tb2RlbHMvdGFza2luc3RhbmNlLnB5) | `94.66% <60%> (-0.26%)` | :arrow_down: |
| [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/6956/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
| [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/6956/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
| [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/6956/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: |
| [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/6956/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: |
| [...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/6956/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==) | `78.75% <0%> (-20%)` | :arrow_down: |
| [airflow/utils/file.py](https://codecov.io/gh/apache/airflow/pull/6956/diff?src=pr&el=tree#diff-YWlyZmxvdy91dGlscy9maWxlLnB5) | `86.3% <0%> (-5.17%)` | :arrow_down: |
| [airflow/utils/helpers.py](https://codecov.io/gh/apache/airflow/pull/6956/diff?src=pr&el=tree#diff-YWlyZmxvdy91dGlscy9oZWxwZXJzLnB5) | `81.69% <0%> (-1.06%)` | :arrow_down: |
| [airflow/contrib/sensors/bash\_sensor.py](https://codecov.io/gh/apache/airflow/pull/6956/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL3NlbnNvcnMvYmFzaF9zZW5zb3IucHk=) | `93.93% <0%> (-0.18%)` | :arrow_down: |
| [airflow/hooks/pig\_hook.py](https://codecov.io/gh/apache/airflow/pull/6956/diff?src=pr&el=tree#diff-YWlyZmxvdy9ob29rcy9waWdfaG9vay5weQ==) | `95.34% <0%> (-0.11%)` | :arrow_down: |
| ... and [24 more](https://codecov.io/gh/apache/airflow/pull/6956/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/6956?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/6956?src=pr&el=footer). Last update [5e100ab...341f976](https://codecov.io/gh/apache/airflow/pull/6956?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #6956:
[AIRFLOW-6387] print details of success/skipped task
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #6956: [AIRFLOW-6387] print details of success/skipped task
URL: https://github.com/apache/airflow/pull/6956#issuecomment-570083400
# [Codecov](https://codecov.io/gh/apache/airflow/pull/6956?src=pr&el=h1) Report
> Merging [#6956](https://codecov.io/gh/apache/airflow/pull/6956?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/7d97d16c47ba181839fd583b8653d2872dc4290b?src=pr&el=desc) will **decrease** coverage by `0.01%`.
> The diff coverage is `100%`.
[](https://codecov.io/gh/apache/airflow/pull/6956?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6956 +/- ##
==========================================
- Coverage 84.7% 84.69% -0.02%
==========================================
Files 680 679 -1
Lines 38556 38666 +110
==========================================
+ Hits 32659 32748 +89
- Misses 5897 5918 +21
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/6956?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/models/taskinstance.py](https://codecov.io/gh/apache/airflow/pull/6956/diff?src=pr&el=tree#diff-YWlyZmxvdy9tb2RlbHMvdGFza2luc3RhbmNlLnB5) | `94.92% <100%> (+0.01%)` | :arrow_up: |
| [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/6956/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
| [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/6956/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
| [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/6956/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: |
| [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/6956/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: |
| [...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/6956/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==) | `78.75% <0%> (-20%)` | :arrow_down: |
| [airflow/utils/file.py](https://codecov.io/gh/apache/airflow/pull/6956/diff?src=pr&el=tree#diff-YWlyZmxvdy91dGlscy9maWxlLnB5) | `86.3% <0%> (-5.17%)` | :arrow_down: |
| [airflow/utils/cli.py](https://codecov.io/gh/apache/airflow/pull/6956/diff?src=pr&el=tree#diff-YWlyZmxvdy91dGlscy9jbGkucHk=) | `68.75% <0%> (-2.95%)` | :arrow_down: |
| [airflow/configuration.py](https://codecov.io/gh/apache/airflow/pull/6956/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb25maWd1cmF0aW9uLnB5) | `91.43% <0%> (-1.22%)` | :arrow_down: |
| [airflow/utils/helpers.py](https://codecov.io/gh/apache/airflow/pull/6956/diff?src=pr&el=tree#diff-YWlyZmxvdy91dGlscy9oZWxwZXJzLnB5) | `81.69% <0%> (-1.06%)` | :arrow_down: |
| ... and [85 more](https://codecov.io/gh/apache/airflow/pull/6956/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/6956?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/6956?src=pr&el=footer). Last update [7d97d16...3bdf12d](https://codecov.io/gh/apache/airflow/pull/6956?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #6956:
[AIRFLOW-6387] print details of success/skipped task
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #6956: [AIRFLOW-6387] print details of success/skipped task
URL: https://github.com/apache/airflow/pull/6956#issuecomment-570083400
# [Codecov](https://codecov.io/gh/apache/airflow/pull/6956?src=pr&el=h1) Report
> Merging [#6956](https://codecov.io/gh/apache/airflow/pull/6956?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/5e100ab753635521d33f287bdffd3d9bd4c6ae0f?src=pr&el=desc) will **decrease** coverage by `<.01%`.
> The diff coverage is `100%`.
[](https://codecov.io/gh/apache/airflow/pull/6956?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6956 +/- ##
==========================================
- Coverage 84.7% 84.69% -0.01%
==========================================
Files 679 679
Lines 38488 38666 +178
==========================================
+ Hits 32600 32748 +148
- Misses 5888 5918 +30
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/6956?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/models/taskinstance.py](https://codecov.io/gh/apache/airflow/pull/6956/diff?src=pr&el=tree#diff-YWlyZmxvdy9tb2RlbHMvdGFza2luc3RhbmNlLnB5) | `94.92% <100%> (+0.01%)` | :arrow_up: |
| [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/6956/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
| [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/6956/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
| [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/6956/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: |
| [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/6956/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: |
| [...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/6956/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==) | `78.75% <0%> (-20%)` | :arrow_down: |
| [airflow/utils/file.py](https://codecov.io/gh/apache/airflow/pull/6956/diff?src=pr&el=tree#diff-YWlyZmxvdy91dGlscy9maWxlLnB5) | `86.3% <0%> (-5.17%)` | :arrow_down: |
| [airflow/configuration.py](https://codecov.io/gh/apache/airflow/pull/6956/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb25maWd1cmF0aW9uLnB5) | `91.43% <0%> (-1.22%)` | :arrow_down: |
| [airflow/utils/helpers.py](https://codecov.io/gh/apache/airflow/pull/6956/diff?src=pr&el=tree#diff-YWlyZmxvdy91dGlscy9oZWxwZXJzLnB5) | `81.69% <0%> (-1.06%)` | :arrow_down: |
| [airflow/utils/log/es\_task\_handler.py](https://codecov.io/gh/apache/airflow/pull/6956/diff?src=pr&el=tree#diff-YWlyZmxvdy91dGlscy9sb2cvZXNfdGFza19oYW5kbGVyLnB5) | `93.39% <0%> (-0.78%)` | :arrow_down: |
| ... and [80 more](https://codecov.io/gh/apache/airflow/pull/6956/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/6956?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/6956?src=pr&el=footer). Last update [5e100ab...3bdf12d](https://codecov.io/gh/apache/airflow/pull/6956?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] tooptoop4 commented on a change in pull request #6956:
[AIRFLOW-6387] print details of success/skipped task
Posted by GitBox <gi...@apache.org>.
tooptoop4 commented on a change in pull request #6956: [AIRFLOW-6387] print details of success/skipped task
URL: https://github.com/apache/airflow/pull/6956#discussion_r362337203
##########
File path: airflow/models/taskinstance.py
##########
@@ -963,12 +963,31 @@ def signal_handler(signum, frame):
Stats.incr('ti_successes')
self.refresh_from_db(lock_for_update=True)
self.state = State.SUCCESS
+ self.log.info(
+ 'Marking task as SUCCESS.'
+ 'dag_id=%s, task_id=%s, execution_date=%s, start_date=%s, end_date=%s',
+ self.dag_id,
+ self.task_id,
+ self.execution_date.strftime('%Y%m%dT%H%M%S'),
+ self.start_date.strftime('%Y%m%dT%H%M%S'),
+ self.end_date.strftime('%Y%m%dT%H%M%S'))
except AirflowSkipException as e:
# log only if exception has any arguments to prevent log flooding
if e.args:
self.log.info(e)
self.refresh_from_db(lock_for_update=True)
self.state = State.SKIPPED
+ try:
+ self.log.info(
+ 'Marking task as SKIPPED.'
+ 'dag_id=%s, task_id=%s, execution_date=%s, start_date=%s, end_date=%s',
+ self.dag_id,
+ self.task_id,
+ self.execution_date.strftime('%Y%m%dT%H%M%S'),
+ self.start_date.strftime('%Y%m%dT%H%M%S'),
+ self.end_date.strftime('%Y%m%dT%H%M%S'))
+ except NameError:
Review comment:
wasn't sure where skip exception could be thrown so just a railguard
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #6956:
[AIRFLOW-6387] print details of success/skipped task
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #6956: [AIRFLOW-6387] print details of success/skipped task
URL: https://github.com/apache/airflow/pull/6956#issuecomment-570083400
# [Codecov](https://codecov.io/gh/apache/airflow/pull/6956?src=pr&el=h1) Report
> Merging [#6956](https://codecov.io/gh/apache/airflow/pull/6956?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/5e100ab753635521d33f287bdffd3d9bd4c6ae0f?src=pr&el=desc) will **decrease** coverage by `<.01%`.
> The diff coverage is `100%`.
[](https://codecov.io/gh/apache/airflow/pull/6956?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6956 +/- ##
==========================================
- Coverage 84.7% 84.69% -0.01%
==========================================
Files 679 679
Lines 38488 38666 +178
==========================================
+ Hits 32600 32748 +148
- Misses 5888 5918 +30
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/6956?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/models/taskinstance.py](https://codecov.io/gh/apache/airflow/pull/6956/diff?src=pr&el=tree#diff-YWlyZmxvdy9tb2RlbHMvdGFza2luc3RhbmNlLnB5) | `94.92% <100%> (+0.01%)` | :arrow_up: |
| [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/6956/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
| [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/6956/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
| [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/6956/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: |
| [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/6956/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: |
| [...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/6956/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==) | `78.75% <0%> (-20%)` | :arrow_down: |
| [airflow/utils/file.py](https://codecov.io/gh/apache/airflow/pull/6956/diff?src=pr&el=tree#diff-YWlyZmxvdy91dGlscy9maWxlLnB5) | `86.3% <0%> (-5.17%)` | :arrow_down: |
| [airflow/configuration.py](https://codecov.io/gh/apache/airflow/pull/6956/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb25maWd1cmF0aW9uLnB5) | `91.43% <0%> (-1.22%)` | :arrow_down: |
| [airflow/utils/helpers.py](https://codecov.io/gh/apache/airflow/pull/6956/diff?src=pr&el=tree#diff-YWlyZmxvdy91dGlscy9oZWxwZXJzLnB5) | `81.69% <0%> (-1.06%)` | :arrow_down: |
| [airflow/utils/log/es\_task\_handler.py](https://codecov.io/gh/apache/airflow/pull/6956/diff?src=pr&el=tree#diff-YWlyZmxvdy91dGlscy9sb2cvZXNfdGFza19oYW5kbGVyLnB5) | `93.39% <0%> (-0.78%)` | :arrow_down: |
| ... and [80 more](https://codecov.io/gh/apache/airflow/pull/6956/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/6956?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/6956?src=pr&el=footer). Last update [5e100ab...3bdf12d](https://codecov.io/gh/apache/airflow/pull/6956?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #6956:
[AIRFLOW-6387] print details of success/skipped task
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #6956: [AIRFLOW-6387] print details of success/skipped task
URL: https://github.com/apache/airflow/pull/6956#issuecomment-570083400
# [Codecov](https://codecov.io/gh/apache/airflow/pull/6956?src=pr&el=h1) Report
> Merging [#6956](https://codecov.io/gh/apache/airflow/pull/6956?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/5e100ab753635521d33f287bdffd3d9bd4c6ae0f?src=pr&el=desc) will **decrease** coverage by `0.13%`.
> The diff coverage is `60%`.
[](https://codecov.io/gh/apache/airflow/pull/6956?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6956 +/- ##
==========================================
- Coverage 84.7% 84.56% -0.14%
==========================================
Files 679 679
Lines 38488 38541 +53
==========================================
- Hits 32600 32591 -9
- Misses 5888 5950 +62
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/6956?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/models/taskinstance.py](https://codecov.io/gh/apache/airflow/pull/6956/diff?src=pr&el=tree#diff-YWlyZmxvdy9tb2RlbHMvdGFza2luc3RhbmNlLnB5) | `94.66% <60%> (-0.26%)` | :arrow_down: |
| [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/6956/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
| [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/6956/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
| [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/6956/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: |
| [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/6956/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: |
| [...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/6956/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==) | `78.75% <0%> (-20%)` | :arrow_down: |
| [airflow/utils/file.py](https://codecov.io/gh/apache/airflow/pull/6956/diff?src=pr&el=tree#diff-YWlyZmxvdy91dGlscy9maWxlLnB5) | `86.3% <0%> (-5.17%)` | :arrow_down: |
| [airflow/utils/helpers.py](https://codecov.io/gh/apache/airflow/pull/6956/diff?src=pr&el=tree#diff-YWlyZmxvdy91dGlscy9oZWxwZXJzLnB5) | `81.69% <0%> (-1.06%)` | :arrow_down: |
| [airflow/contrib/sensors/bash\_sensor.py](https://codecov.io/gh/apache/airflow/pull/6956/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL3NlbnNvcnMvYmFzaF9zZW5zb3IucHk=) | `93.93% <0%> (-0.18%)` | :arrow_down: |
| [airflow/hooks/pig\_hook.py](https://codecov.io/gh/apache/airflow/pull/6956/diff?src=pr&el=tree#diff-YWlyZmxvdy9ob29rcy9waWdfaG9vay5weQ==) | `95.34% <0%> (-0.11%)` | :arrow_down: |
| ... and [24 more](https://codecov.io/gh/apache/airflow/pull/6956/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/6956?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/6956?src=pr&el=footer). Last update [5e100ab...341f976](https://codecov.io/gh/apache/airflow/pull/6956?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #6956:
[AIRFLOW-6387] print details of success/skipped task
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #6956: [AIRFLOW-6387] print details of success/skipped task
URL: https://github.com/apache/airflow/pull/6956#issuecomment-570083400
# [Codecov](https://codecov.io/gh/apache/airflow/pull/6956?src=pr&el=h1) Report
> Merging [#6956](https://codecov.io/gh/apache/airflow/pull/6956?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/5e100ab753635521d33f287bdffd3d9bd4c6ae0f?src=pr&el=desc) will **decrease** coverage by `0.13%`.
> The diff coverage is `60%`.
[](https://codecov.io/gh/apache/airflow/pull/6956?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6956 +/- ##
==========================================
- Coverage 84.7% 84.56% -0.14%
==========================================
Files 679 679
Lines 38488 38541 +53
==========================================
- Hits 32600 32591 -9
- Misses 5888 5950 +62
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/6956?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/models/taskinstance.py](https://codecov.io/gh/apache/airflow/pull/6956/diff?src=pr&el=tree#diff-YWlyZmxvdy9tb2RlbHMvdGFza2luc3RhbmNlLnB5) | `94.66% <60%> (-0.26%)` | :arrow_down: |
| [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/6956/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
| [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/6956/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
| [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/6956/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: |
| [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/6956/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: |
| [...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/6956/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==) | `78.75% <0%> (-20%)` | :arrow_down: |
| [airflow/utils/file.py](https://codecov.io/gh/apache/airflow/pull/6956/diff?src=pr&el=tree#diff-YWlyZmxvdy91dGlscy9maWxlLnB5) | `86.3% <0%> (-5.17%)` | :arrow_down: |
| [airflow/utils/helpers.py](https://codecov.io/gh/apache/airflow/pull/6956/diff?src=pr&el=tree#diff-YWlyZmxvdy91dGlscy9oZWxwZXJzLnB5) | `81.69% <0%> (-1.06%)` | :arrow_down: |
| [airflow/contrib/sensors/bash\_sensor.py](https://codecov.io/gh/apache/airflow/pull/6956/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL3NlbnNvcnMvYmFzaF9zZW5zb3IucHk=) | `93.93% <0%> (-0.18%)` | :arrow_down: |
| [airflow/hooks/pig\_hook.py](https://codecov.io/gh/apache/airflow/pull/6956/diff?src=pr&el=tree#diff-YWlyZmxvdy9ob29rcy9waWdfaG9vay5weQ==) | `95.34% <0%> (-0.11%)` | :arrow_down: |
| ... and [24 more](https://codecov.io/gh/apache/airflow/pull/6956/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/6956?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/6956?src=pr&el=footer). Last update [5e100ab...341f976](https://codecov.io/gh/apache/airflow/pull/6956?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] potiuk commented on issue #6956: [AIRFLOW-6387] print
details of success/skipped task
Posted by GitBox <gi...@apache.org>.
potiuk commented on issue #6956: [AIRFLOW-6387] print details of success/skipped task
URL: https://github.com/apache/airflow/pull/6956#issuecomment-570945495
Cool!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #6956:
[AIRFLOW-6387] print details of success/skipped task
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #6956: [AIRFLOW-6387] print details of success/skipped task
URL: https://github.com/apache/airflow/pull/6956#issuecomment-570083400
# [Codecov](https://codecov.io/gh/apache/airflow/pull/6956?src=pr&el=h1) Report
> Merging [#6956](https://codecov.io/gh/apache/airflow/pull/6956?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/7d97d16c47ba181839fd583b8653d2872dc4290b?src=pr&el=desc) will **decrease** coverage by `0.01%`.
> The diff coverage is `100%`.
[](https://codecov.io/gh/apache/airflow/pull/6956?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6956 +/- ##
==========================================
- Coverage 84.7% 84.69% -0.02%
==========================================
Files 680 679 -1
Lines 38556 38666 +110
==========================================
+ Hits 32659 32748 +89
- Misses 5897 5918 +21
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/6956?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/models/taskinstance.py](https://codecov.io/gh/apache/airflow/pull/6956/diff?src=pr&el=tree#diff-YWlyZmxvdy9tb2RlbHMvdGFza2luc3RhbmNlLnB5) | `94.92% <100%> (+0.01%)` | :arrow_up: |
| [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/6956/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
| [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/6956/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
| [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/6956/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: |
| [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/6956/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: |
| [...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/6956/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==) | `78.75% <0%> (-20%)` | :arrow_down: |
| [airflow/utils/file.py](https://codecov.io/gh/apache/airflow/pull/6956/diff?src=pr&el=tree#diff-YWlyZmxvdy91dGlscy9maWxlLnB5) | `86.3% <0%> (-5.17%)` | :arrow_down: |
| [airflow/utils/cli.py](https://codecov.io/gh/apache/airflow/pull/6956/diff?src=pr&el=tree#diff-YWlyZmxvdy91dGlscy9jbGkucHk=) | `68.75% <0%> (-2.95%)` | :arrow_down: |
| [airflow/configuration.py](https://codecov.io/gh/apache/airflow/pull/6956/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb25maWd1cmF0aW9uLnB5) | `91.43% <0%> (-1.22%)` | :arrow_down: |
| [airflow/utils/helpers.py](https://codecov.io/gh/apache/airflow/pull/6956/diff?src=pr&el=tree#diff-YWlyZmxvdy91dGlscy9oZWxwZXJzLnB5) | `81.69% <0%> (-1.06%)` | :arrow_down: |
| ... and [85 more](https://codecov.io/gh/apache/airflow/pull/6956/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/6956?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/6956?src=pr&el=footer). Last update [7d97d16...3bdf12d](https://codecov.io/gh/apache/airflow/pull/6956?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #6956:
[AIRFLOW-6387] print details of success/skipped task
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #6956: [AIRFLOW-6387] print details of success/skipped task
URL: https://github.com/apache/airflow/pull/6956#issuecomment-570083400
# [Codecov](https://codecov.io/gh/apache/airflow/pull/6956?src=pr&el=h1) Report
> Merging [#6956](https://codecov.io/gh/apache/airflow/pull/6956?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/5e100ab753635521d33f287bdffd3d9bd4c6ae0f?src=pr&el=desc) will **decrease** coverage by `<.01%`.
> The diff coverage is `100%`.
[](https://codecov.io/gh/apache/airflow/pull/6956?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6956 +/- ##
==========================================
- Coverage 84.7% 84.69% -0.01%
==========================================
Files 679 679
Lines 38488 38666 +178
==========================================
+ Hits 32600 32748 +148
- Misses 5888 5918 +30
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/6956?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/models/taskinstance.py](https://codecov.io/gh/apache/airflow/pull/6956/diff?src=pr&el=tree#diff-YWlyZmxvdy9tb2RlbHMvdGFza2luc3RhbmNlLnB5) | `94.92% <100%> (+0.01%)` | :arrow_up: |
| [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/6956/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
| [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/6956/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
| [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/6956/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: |
| [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/6956/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: |
| [...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/6956/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==) | `78.75% <0%> (-20%)` | :arrow_down: |
| [airflow/utils/file.py](https://codecov.io/gh/apache/airflow/pull/6956/diff?src=pr&el=tree#diff-YWlyZmxvdy91dGlscy9maWxlLnB5) | `86.3% <0%> (-5.17%)` | :arrow_down: |
| [airflow/configuration.py](https://codecov.io/gh/apache/airflow/pull/6956/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb25maWd1cmF0aW9uLnB5) | `91.43% <0%> (-1.22%)` | :arrow_down: |
| [airflow/utils/helpers.py](https://codecov.io/gh/apache/airflow/pull/6956/diff?src=pr&el=tree#diff-YWlyZmxvdy91dGlscy9oZWxwZXJzLnB5) | `81.69% <0%> (-1.06%)` | :arrow_down: |
| [airflow/utils/log/es\_task\_handler.py](https://codecov.io/gh/apache/airflow/pull/6956/diff?src=pr&el=tree#diff-YWlyZmxvdy91dGlscy9sb2cvZXNfdGFza19oYW5kbGVyLnB5) | `93.39% <0%> (-0.78%)` | :arrow_down: |
| ... and [80 more](https://codecov.io/gh/apache/airflow/pull/6956/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/6956?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/6956?src=pr&el=footer). Last update [5e100ab...3bdf12d](https://codecov.io/gh/apache/airflow/pull/6956?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #6956:
[AIRFLOW-6387] print details of success/skipped task
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #6956: [AIRFLOW-6387] print details of success/skipped task
URL: https://github.com/apache/airflow/pull/6956#issuecomment-570083400
# [Codecov](https://codecov.io/gh/apache/airflow/pull/6956?src=pr&el=h1) Report
> Merging [#6956](https://codecov.io/gh/apache/airflow/pull/6956?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/7d97d16c47ba181839fd583b8653d2872dc4290b?src=pr&el=desc) will **decrease** coverage by `0.01%`.
> The diff coverage is `100%`.
[](https://codecov.io/gh/apache/airflow/pull/6956?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6956 +/- ##
==========================================
- Coverage 84.7% 84.69% -0.02%
==========================================
Files 680 679 -1
Lines 38556 38666 +110
==========================================
+ Hits 32659 32748 +89
- Misses 5897 5918 +21
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/6956?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/models/taskinstance.py](https://codecov.io/gh/apache/airflow/pull/6956/diff?src=pr&el=tree#diff-YWlyZmxvdy9tb2RlbHMvdGFza2luc3RhbmNlLnB5) | `94.92% <100%> (+0.01%)` | :arrow_up: |
| [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/6956/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
| [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/6956/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
| [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/6956/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: |
| [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/6956/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: |
| [...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/6956/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==) | `78.75% <0%> (-20%)` | :arrow_down: |
| [airflow/utils/file.py](https://codecov.io/gh/apache/airflow/pull/6956/diff?src=pr&el=tree#diff-YWlyZmxvdy91dGlscy9maWxlLnB5) | `86.3% <0%> (-5.17%)` | :arrow_down: |
| [airflow/utils/cli.py](https://codecov.io/gh/apache/airflow/pull/6956/diff?src=pr&el=tree#diff-YWlyZmxvdy91dGlscy9jbGkucHk=) | `68.75% <0%> (-2.95%)` | :arrow_down: |
| [airflow/configuration.py](https://codecov.io/gh/apache/airflow/pull/6956/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb25maWd1cmF0aW9uLnB5) | `91.43% <0%> (-1.22%)` | :arrow_down: |
| [airflow/utils/helpers.py](https://codecov.io/gh/apache/airflow/pull/6956/diff?src=pr&el=tree#diff-YWlyZmxvdy91dGlscy9oZWxwZXJzLnB5) | `81.69% <0%> (-1.06%)` | :arrow_down: |
| ... and [85 more](https://codecov.io/gh/apache/airflow/pull/6956/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/6956?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/6956?src=pr&el=footer). Last update [7d97d16...3bdf12d](https://codecov.io/gh/apache/airflow/pull/6956?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #6956:
[AIRFLOW-6387] print details of success/skipped task
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #6956: [AIRFLOW-6387] print details of success/skipped task
URL: https://github.com/apache/airflow/pull/6956#issuecomment-570083400
# [Codecov](https://codecov.io/gh/apache/airflow/pull/6956?src=pr&el=h1) Report
> Merging [#6956](https://codecov.io/gh/apache/airflow/pull/6956?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/5e100ab753635521d33f287bdffd3d9bd4c6ae0f?src=pr&el=desc) will **decrease** coverage by `0.13%`.
> The diff coverage is `60%`.
[](https://codecov.io/gh/apache/airflow/pull/6956?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6956 +/- ##
==========================================
- Coverage 84.7% 84.56% -0.14%
==========================================
Files 679 679
Lines 38488 38541 +53
==========================================
- Hits 32600 32591 -9
- Misses 5888 5950 +62
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/6956?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/models/taskinstance.py](https://codecov.io/gh/apache/airflow/pull/6956/diff?src=pr&el=tree#diff-YWlyZmxvdy9tb2RlbHMvdGFza2luc3RhbmNlLnB5) | `94.66% <60%> (-0.26%)` | :arrow_down: |
| [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/6956/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
| [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/6956/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
| [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/6956/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: |
| [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/6956/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: |
| [...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/6956/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==) | `78.75% <0%> (-20%)` | :arrow_down: |
| [airflow/utils/file.py](https://codecov.io/gh/apache/airflow/pull/6956/diff?src=pr&el=tree#diff-YWlyZmxvdy91dGlscy9maWxlLnB5) | `86.3% <0%> (-5.17%)` | :arrow_down: |
| [airflow/utils/helpers.py](https://codecov.io/gh/apache/airflow/pull/6956/diff?src=pr&el=tree#diff-YWlyZmxvdy91dGlscy9oZWxwZXJzLnB5) | `81.69% <0%> (-1.06%)` | :arrow_down: |
| [airflow/contrib/sensors/bash\_sensor.py](https://codecov.io/gh/apache/airflow/pull/6956/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL3NlbnNvcnMvYmFzaF9zZW5zb3IucHk=) | `93.93% <0%> (-0.18%)` | :arrow_down: |
| [airflow/hooks/pig\_hook.py](https://codecov.io/gh/apache/airflow/pull/6956/diff?src=pr&el=tree#diff-YWlyZmxvdy9ob29rcy9waWdfaG9vay5weQ==) | `95.34% <0%> (-0.11%)` | :arrow_down: |
| ... and [24 more](https://codecov.io/gh/apache/airflow/pull/6956/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/6956?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/6956?src=pr&el=footer). Last update [5e100ab...341f976](https://codecov.io/gh/apache/airflow/pull/6956?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #6956:
[AIRFLOW-6387] print details of success/skipped task
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #6956: [AIRFLOW-6387] print details of success/skipped task
URL: https://github.com/apache/airflow/pull/6956#issuecomment-570083400
# [Codecov](https://codecov.io/gh/apache/airflow/pull/6956?src=pr&el=h1) Report
> Merging [#6956](https://codecov.io/gh/apache/airflow/pull/6956?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/5e100ab753635521d33f287bdffd3d9bd4c6ae0f?src=pr&el=desc) will **decrease** coverage by `<.01%`.
> The diff coverage is `100%`.
[](https://codecov.io/gh/apache/airflow/pull/6956?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6956 +/- ##
==========================================
- Coverage 84.7% 84.69% -0.01%
==========================================
Files 679 679
Lines 38488 38666 +178
==========================================
+ Hits 32600 32748 +148
- Misses 5888 5918 +30
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/6956?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/models/taskinstance.py](https://codecov.io/gh/apache/airflow/pull/6956/diff?src=pr&el=tree#diff-YWlyZmxvdy9tb2RlbHMvdGFza2luc3RhbmNlLnB5) | `94.92% <100%> (+0.01%)` | :arrow_up: |
| [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/6956/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
| [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/6956/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
| [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/6956/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: |
| [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/6956/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: |
| [...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/6956/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==) | `78.75% <0%> (-20%)` | :arrow_down: |
| [airflow/utils/file.py](https://codecov.io/gh/apache/airflow/pull/6956/diff?src=pr&el=tree#diff-YWlyZmxvdy91dGlscy9maWxlLnB5) | `86.3% <0%> (-5.17%)` | :arrow_down: |
| [airflow/configuration.py](https://codecov.io/gh/apache/airflow/pull/6956/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb25maWd1cmF0aW9uLnB5) | `91.43% <0%> (-1.22%)` | :arrow_down: |
| [airflow/utils/helpers.py](https://codecov.io/gh/apache/airflow/pull/6956/diff?src=pr&el=tree#diff-YWlyZmxvdy91dGlscy9oZWxwZXJzLnB5) | `81.69% <0%> (-1.06%)` | :arrow_down: |
| [airflow/utils/log/es\_task\_handler.py](https://codecov.io/gh/apache/airflow/pull/6956/diff?src=pr&el=tree#diff-YWlyZmxvdy91dGlscy9sb2cvZXNfdGFza19oYW5kbGVyLnB5) | `93.39% <0%> (-0.78%)` | :arrow_down: |
| ... and [80 more](https://codecov.io/gh/apache/airflow/pull/6956/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/6956?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/6956?src=pr&el=footer). Last update [5e100ab...3bdf12d](https://codecov.io/gh/apache/airflow/pull/6956?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] potiuk commented on a change in pull request #6956:
[AIRFLOW-6387] print details of success/skipped task
Posted by GitBox <gi...@apache.org>.
potiuk commented on a change in pull request #6956: [AIRFLOW-6387] print details of success/skipped task
URL: https://github.com/apache/airflow/pull/6956#discussion_r363110108
##########
File path: airflow/models/taskinstance.py
##########
@@ -964,11 +964,23 @@ def signal_handler(signum, frame):
self.refresh_from_db(lock_for_update=True)
self.state = State.SUCCESS
except AirflowSkipException as e:
+ # Recording SKIP
# log only if exception has any arguments to prevent log flooding
if e.args:
self.log.info(e)
self.refresh_from_db(lock_for_update=True)
self.state = State.SKIPPED
+ try:
+ self.log.info(
+ 'Marking task as SKIPPED.'
+ 'dag_id=%s, task_id=%s, execution_date=%s, start_date=%s, end_date=%s',
+ self.dag_id,
+ self.task_id,
+ self.execution_date.strftime('%Y%m%dT%H%M%S') if self.execution_date else '',
+ self.start_date.strftime('%Y%m%dT%H%M%S') if self.start_date else '',
+ self.end_date.strftime('%Y%m%dT%H%M%S') if self.end_date else '')
+ except NameError:
Review comment:
If you use hasattr, you can remove try/except and you will get log in this case.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #6956:
[AIRFLOW-6387] print details of success/skipped task
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #6956: [AIRFLOW-6387] print details of success/skipped task
URL: https://github.com/apache/airflow/pull/6956#issuecomment-570083400
# [Codecov](https://codecov.io/gh/apache/airflow/pull/6956?src=pr&el=h1) Report
> Merging [#6956](https://codecov.io/gh/apache/airflow/pull/6956?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/5e100ab753635521d33f287bdffd3d9bd4c6ae0f?src=pr&el=desc) will **decrease** coverage by `<.01%`.
> The diff coverage is `100%`.
[](https://codecov.io/gh/apache/airflow/pull/6956?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6956 +/- ##
==========================================
- Coverage 84.7% 84.69% -0.01%
==========================================
Files 679 679
Lines 38488 38666 +178
==========================================
+ Hits 32600 32748 +148
- Misses 5888 5918 +30
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/6956?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/models/taskinstance.py](https://codecov.io/gh/apache/airflow/pull/6956/diff?src=pr&el=tree#diff-YWlyZmxvdy9tb2RlbHMvdGFza2luc3RhbmNlLnB5) | `94.92% <100%> (+0.01%)` | :arrow_up: |
| [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/6956/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
| [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/6956/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
| [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/6956/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: |
| [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/6956/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: |
| [...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/6956/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==) | `78.75% <0%> (-20%)` | :arrow_down: |
| [airflow/utils/file.py](https://codecov.io/gh/apache/airflow/pull/6956/diff?src=pr&el=tree#diff-YWlyZmxvdy91dGlscy9maWxlLnB5) | `86.3% <0%> (-5.17%)` | :arrow_down: |
| [airflow/configuration.py](https://codecov.io/gh/apache/airflow/pull/6956/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb25maWd1cmF0aW9uLnB5) | `91.43% <0%> (-1.22%)` | :arrow_down: |
| [airflow/utils/helpers.py](https://codecov.io/gh/apache/airflow/pull/6956/diff?src=pr&el=tree#diff-YWlyZmxvdy91dGlscy9oZWxwZXJzLnB5) | `81.69% <0%> (-1.06%)` | :arrow_down: |
| [airflow/utils/log/es\_task\_handler.py](https://codecov.io/gh/apache/airflow/pull/6956/diff?src=pr&el=tree#diff-YWlyZmxvdy91dGlscy9sb2cvZXNfdGFza19oYW5kbGVyLnB5) | `93.39% <0%> (-0.78%)` | :arrow_down: |
| ... and [80 more](https://codecov.io/gh/apache/airflow/pull/6956/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/6956?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/6956?src=pr&el=footer). Last update [5e100ab...3bdf12d](https://codecov.io/gh/apache/airflow/pull/6956?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] feluelle commented on a change in pull request #6956:
[AIRFLOW-6387] print details of success/skipped task
Posted by GitBox <gi...@apache.org>.
feluelle commented on a change in pull request #6956: [AIRFLOW-6387] print details of success/skipped task
URL: https://github.com/apache/airflow/pull/6956#discussion_r362480278
##########
File path: airflow/models/taskinstance.py
##########
@@ -963,12 +963,31 @@ def signal_handler(signum, frame):
Stats.incr('ti_successes')
self.refresh_from_db(lock_for_update=True)
self.state = State.SUCCESS
+ self.log.info(
+ 'Marking task as SUCCESS.'
+ 'dag_id=%s, task_id=%s, execution_date=%s, start_date=%s, end_date=%s',
+ self.dag_id,
+ self.task_id,
+ self.execution_date.strftime('%Y%m%dT%H%M%S'),
+ self.start_date.strftime('%Y%m%dT%H%M%S'),
+ self.end_date.strftime('%Y%m%dT%H%M%S'))
except AirflowSkipException as e:
# log only if exception has any arguments to prevent log flooding
if e.args:
self.log.info(e)
self.refresh_from_db(lock_for_update=True)
self.state = State.SKIPPED
+ try:
+ self.log.info(
+ 'Marking task as SKIPPED.'
+ 'dag_id=%s, task_id=%s, execution_date=%s, start_date=%s, end_date=%s',
+ self.dag_id,
+ self.task_id,
+ self.execution_date.strftime('%Y%m%dT%H%M%S'),
+ self.start_date.strftime('%Y%m%dT%H%M%S'),
+ self.end_date.strftime('%Y%m%dT%H%M%S'))
+ except NameError:
Review comment:
No I mean why do you check for `NameError` ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] tooptoop4 commented on a change in pull request #6956:
[AIRFLOW-6387] print details of success/skipped task
Posted by GitBox <gi...@apache.org>.
tooptoop4 commented on a change in pull request #6956: [AIRFLOW-6387] print details of success/skipped task
URL: https://github.com/apache/airflow/pull/6956#discussion_r362337203
##########
File path: airflow/models/taskinstance.py
##########
@@ -963,12 +963,31 @@ def signal_handler(signum, frame):
Stats.incr('ti_successes')
self.refresh_from_db(lock_for_update=True)
self.state = State.SUCCESS
+ self.log.info(
+ 'Marking task as SUCCESS.'
+ 'dag_id=%s, task_id=%s, execution_date=%s, start_date=%s, end_date=%s',
+ self.dag_id,
+ self.task_id,
+ self.execution_date.strftime('%Y%m%dT%H%M%S'),
+ self.start_date.strftime('%Y%m%dT%H%M%S'),
+ self.end_date.strftime('%Y%m%dT%H%M%S'))
except AirflowSkipException as e:
# log only if exception has any arguments to prevent log flooding
if e.args:
self.log.info(e)
self.refresh_from_db(lock_for_update=True)
self.state = State.SKIPPED
+ try:
+ self.log.info(
+ 'Marking task as SKIPPED.'
+ 'dag_id=%s, task_id=%s, execution_date=%s, start_date=%s, end_date=%s',
+ self.dag_id,
+ self.task_id,
+ self.execution_date.strftime('%Y%m%dT%H%M%S'),
+ self.start_date.strftime('%Y%m%dT%H%M%S'),
+ self.end_date.strftime('%Y%m%dT%H%M%S'))
+ except NameError:
Review comment:
wasn't sure where skip exception could be thrown so just a railcard
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] potiuk commented on issue #6956: [AIRFLOW-6387] print
details of success/skipped task
Posted by GitBox <gi...@apache.org>.
potiuk commented on issue #6956: [AIRFLOW-6387] print details of success/skipped task
URL: https://github.com/apache/airflow/pull/6956#issuecomment-571355060
Thanks!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] tooptoop4 commented on a change in pull request #6956:
[AIRFLOW-6387] print details of success/skipped task
Posted by GitBox <gi...@apache.org>.
tooptoop4 commented on a change in pull request #6956: [AIRFLOW-6387] print details of success/skipped task
URL: https://github.com/apache/airflow/pull/6956#discussion_r363114125
##########
File path: airflow/models/taskinstance.py
##########
@@ -964,11 +964,23 @@ def signal_handler(signum, frame):
self.refresh_from_db(lock_for_update=True)
self.state = State.SUCCESS
except AirflowSkipException as e:
+ # Recording SKIP
# log only if exception has any arguments to prevent log flooding
if e.args:
self.log.info(e)
self.refresh_from_db(lock_for_update=True)
self.state = State.SKIPPED
+ try:
+ self.log.info(
+ 'Marking task as SKIPPED.'
+ 'dag_id=%s, task_id=%s, execution_date=%s, start_date=%s, end_date=%s',
+ self.dag_id,
+ self.task_id,
+ self.execution_date.strftime('%Y%m%dT%H%M%S') if self.execution_date else '',
+ self.start_date.strftime('%Y%m%dT%H%M%S') if self.start_date else '',
+ self.end_date.strftime('%Y%m%dT%H%M%S') if self.end_date else '')
+ except NameError:
Review comment:
fixed
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #6956:
[AIRFLOW-6387] print details of success/skipped task
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #6956: [AIRFLOW-6387] print details of success/skipped task
URL: https://github.com/apache/airflow/pull/6956#issuecomment-570083400
# [Codecov](https://codecov.io/gh/apache/airflow/pull/6956?src=pr&el=h1) Report
> Merging [#6956](https://codecov.io/gh/apache/airflow/pull/6956?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/7d97d16c47ba181839fd583b8653d2872dc4290b?src=pr&el=desc) will **decrease** coverage by `0.01%`.
> The diff coverage is `100%`.
[](https://codecov.io/gh/apache/airflow/pull/6956?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6956 +/- ##
==========================================
- Coverage 84.7% 84.69% -0.02%
==========================================
Files 680 679 -1
Lines 38556 38666 +110
==========================================
+ Hits 32659 32748 +89
- Misses 5897 5918 +21
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/6956?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/models/taskinstance.py](https://codecov.io/gh/apache/airflow/pull/6956/diff?src=pr&el=tree#diff-YWlyZmxvdy9tb2RlbHMvdGFza2luc3RhbmNlLnB5) | `94.92% <100%> (+0.01%)` | :arrow_up: |
| [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/6956/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
| [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/6956/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
| [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/6956/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: |
| [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/6956/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: |
| [...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/6956/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==) | `78.75% <0%> (-20%)` | :arrow_down: |
| [airflow/utils/file.py](https://codecov.io/gh/apache/airflow/pull/6956/diff?src=pr&el=tree#diff-YWlyZmxvdy91dGlscy9maWxlLnB5) | `86.3% <0%> (-5.17%)` | :arrow_down: |
| [airflow/utils/cli.py](https://codecov.io/gh/apache/airflow/pull/6956/diff?src=pr&el=tree#diff-YWlyZmxvdy91dGlscy9jbGkucHk=) | `68.75% <0%> (-2.95%)` | :arrow_down: |
| [airflow/configuration.py](https://codecov.io/gh/apache/airflow/pull/6956/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb25maWd1cmF0aW9uLnB5) | `91.43% <0%> (-1.22%)` | :arrow_down: |
| [airflow/utils/helpers.py](https://codecov.io/gh/apache/airflow/pull/6956/diff?src=pr&el=tree#diff-YWlyZmxvdy91dGlscy9oZWxwZXJzLnB5) | `81.69% <0%> (-1.06%)` | :arrow_down: |
| ... and [85 more](https://codecov.io/gh/apache/airflow/pull/6956/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/6956?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/6956?src=pr&el=footer). Last update [7d97d16...3bdf12d](https://codecov.io/gh/apache/airflow/pull/6956?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] tooptoop4 commented on a change in pull request #6956:
[AIRFLOW-6387] print details of success/skipped task
Posted by GitBox <gi...@apache.org>.
tooptoop4 commented on a change in pull request #6956: [AIRFLOW-6387] print details of success/skipped task
URL: https://github.com/apache/airflow/pull/6956#discussion_r362584557
##########
File path: airflow/models/taskinstance.py
##########
@@ -963,12 +963,31 @@ def signal_handler(signum, frame):
Stats.incr('ti_successes')
self.refresh_from_db(lock_for_update=True)
self.state = State.SUCCESS
+ self.log.info(
+ 'Marking task as SUCCESS.'
+ 'dag_id=%s, task_id=%s, execution_date=%s, start_date=%s, end_date=%s',
+ self.dag_id,
+ self.task_id,
+ self.execution_date.strftime('%Y%m%dT%H%M%S'),
+ self.start_date.strftime('%Y%m%dT%H%M%S'),
+ self.end_date.strftime('%Y%m%dT%H%M%S'))
except AirflowSkipException as e:
# log only if exception has any arguments to prevent log flooding
if e.args:
self.log.info(e)
self.refresh_from_db(lock_for_update=True)
self.state = State.SKIPPED
+ try:
+ self.log.info(
+ 'Marking task as SKIPPED.'
+ 'dag_id=%s, task_id=%s, execution_date=%s, start_date=%s, end_date=%s',
+ self.dag_id,
+ self.task_id,
+ self.execution_date.strftime('%Y%m%dT%H%M%S'),
+ self.start_date.strftime('%Y%m%dT%H%M%S'),
+ self.end_date.strftime('%Y%m%dT%H%M%S'))
+ except NameError:
Review comment:
not sure if start_date existed yet
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] tooptoop4 commented on issue #6956: [AIRFLOW-6387] print
details of success/skipped task
Posted by GitBox <gi...@apache.org>.
tooptoop4 commented on issue #6956: [AIRFLOW-6387] print details of success/skipped task
URL: https://github.com/apache/airflow/pull/6956#issuecomment-570083577
@potiuk pls merge
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #6956:
[AIRFLOW-6387] print details of success/skipped task
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #6956: [AIRFLOW-6387] print details of success/skipped task
URL: https://github.com/apache/airflow/pull/6956#issuecomment-570083400
# [Codecov](https://codecov.io/gh/apache/airflow/pull/6956?src=pr&el=h1) Report
> Merging [#6956](https://codecov.io/gh/apache/airflow/pull/6956?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/5e100ab753635521d33f287bdffd3d9bd4c6ae0f?src=pr&el=desc) will **decrease** coverage by `<.01%`.
> The diff coverage is `100%`.
[](https://codecov.io/gh/apache/airflow/pull/6956?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6956 +/- ##
==========================================
- Coverage 84.7% 84.69% -0.01%
==========================================
Files 679 679
Lines 38488 38666 +178
==========================================
+ Hits 32600 32748 +148
- Misses 5888 5918 +30
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/6956?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/models/taskinstance.py](https://codecov.io/gh/apache/airflow/pull/6956/diff?src=pr&el=tree#diff-YWlyZmxvdy9tb2RlbHMvdGFza2luc3RhbmNlLnB5) | `94.92% <100%> (+0.01%)` | :arrow_up: |
| [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/6956/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
| [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/6956/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
| [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/6956/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: |
| [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/6956/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: |
| [...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/6956/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==) | `78.75% <0%> (-20%)` | :arrow_down: |
| [airflow/utils/file.py](https://codecov.io/gh/apache/airflow/pull/6956/diff?src=pr&el=tree#diff-YWlyZmxvdy91dGlscy9maWxlLnB5) | `86.3% <0%> (-5.17%)` | :arrow_down: |
| [airflow/configuration.py](https://codecov.io/gh/apache/airflow/pull/6956/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb25maWd1cmF0aW9uLnB5) | `91.43% <0%> (-1.22%)` | :arrow_down: |
| [airflow/utils/helpers.py](https://codecov.io/gh/apache/airflow/pull/6956/diff?src=pr&el=tree#diff-YWlyZmxvdy91dGlscy9oZWxwZXJzLnB5) | `81.69% <0%> (-1.06%)` | :arrow_down: |
| [airflow/utils/log/es\_task\_handler.py](https://codecov.io/gh/apache/airflow/pull/6956/diff?src=pr&el=tree#diff-YWlyZmxvdy91dGlscy9sb2cvZXNfdGFza19oYW5kbGVyLnB5) | `93.39% <0%> (-0.78%)` | :arrow_down: |
| ... and [80 more](https://codecov.io/gh/apache/airflow/pull/6956/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/6956?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/6956?src=pr&el=footer). Last update [5e100ab...3bdf12d](https://codecov.io/gh/apache/airflow/pull/6956?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #6956:
[AIRFLOW-6387] print details of success/skipped task
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #6956: [AIRFLOW-6387] print details of success/skipped task
URL: https://github.com/apache/airflow/pull/6956#issuecomment-570083400
# [Codecov](https://codecov.io/gh/apache/airflow/pull/6956?src=pr&el=h1) Report
> Merging [#6956](https://codecov.io/gh/apache/airflow/pull/6956?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/5e100ab753635521d33f287bdffd3d9bd4c6ae0f?src=pr&el=desc) will **decrease** coverage by `<.01%`.
> The diff coverage is `100%`.
[](https://codecov.io/gh/apache/airflow/pull/6956?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6956 +/- ##
==========================================
- Coverage 84.7% 84.69% -0.01%
==========================================
Files 679 679
Lines 38488 38666 +178
==========================================
+ Hits 32600 32748 +148
- Misses 5888 5918 +30
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/6956?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/models/taskinstance.py](https://codecov.io/gh/apache/airflow/pull/6956/diff?src=pr&el=tree#diff-YWlyZmxvdy9tb2RlbHMvdGFza2luc3RhbmNlLnB5) | `94.92% <100%> (+0.01%)` | :arrow_up: |
| [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/6956/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
| [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/6956/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
| [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/6956/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: |
| [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/6956/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: |
| [...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/6956/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==) | `78.75% <0%> (-20%)` | :arrow_down: |
| [airflow/utils/file.py](https://codecov.io/gh/apache/airflow/pull/6956/diff?src=pr&el=tree#diff-YWlyZmxvdy91dGlscy9maWxlLnB5) | `86.3% <0%> (-5.17%)` | :arrow_down: |
| [airflow/configuration.py](https://codecov.io/gh/apache/airflow/pull/6956/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb25maWd1cmF0aW9uLnB5) | `91.43% <0%> (-1.22%)` | :arrow_down: |
| [airflow/utils/helpers.py](https://codecov.io/gh/apache/airflow/pull/6956/diff?src=pr&el=tree#diff-YWlyZmxvdy91dGlscy9oZWxwZXJzLnB5) | `81.69% <0%> (-1.06%)` | :arrow_down: |
| [airflow/utils/log/es\_task\_handler.py](https://codecov.io/gh/apache/airflow/pull/6956/diff?src=pr&el=tree#diff-YWlyZmxvdy91dGlscy9sb2cvZXNfdGFza19oYW5kbGVyLnB5) | `93.39% <0%> (-0.78%)` | :arrow_down: |
| ... and [80 more](https://codecov.io/gh/apache/airflow/pull/6956/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/6956?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/6956?src=pr&el=footer). Last update [5e100ab...3bdf12d](https://codecov.io/gh/apache/airflow/pull/6956?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #6956:
[AIRFLOW-6387] print details of success/skipped task
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #6956: [AIRFLOW-6387] print details of success/skipped task
URL: https://github.com/apache/airflow/pull/6956#issuecomment-570083400
# [Codecov](https://codecov.io/gh/apache/airflow/pull/6956?src=pr&el=h1) Report
> Merging [#6956](https://codecov.io/gh/apache/airflow/pull/6956?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/7d97d16c47ba181839fd583b8653d2872dc4290b?src=pr&el=desc) will **decrease** coverage by `0.01%`.
> The diff coverage is `100%`.
[](https://codecov.io/gh/apache/airflow/pull/6956?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6956 +/- ##
==========================================
- Coverage 84.7% 84.69% -0.02%
==========================================
Files 680 679 -1
Lines 38556 38666 +110
==========================================
+ Hits 32659 32748 +89
- Misses 5897 5918 +21
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/6956?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/models/taskinstance.py](https://codecov.io/gh/apache/airflow/pull/6956/diff?src=pr&el=tree#diff-YWlyZmxvdy9tb2RlbHMvdGFza2luc3RhbmNlLnB5) | `94.92% <100%> (+0.01%)` | :arrow_up: |
| [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/6956/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
| [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/6956/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
| [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/6956/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: |
| [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/6956/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: |
| [...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/6956/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==) | `78.75% <0%> (-20%)` | :arrow_down: |
| [airflow/utils/file.py](https://codecov.io/gh/apache/airflow/pull/6956/diff?src=pr&el=tree#diff-YWlyZmxvdy91dGlscy9maWxlLnB5) | `86.3% <0%> (-5.17%)` | :arrow_down: |
| [airflow/utils/cli.py](https://codecov.io/gh/apache/airflow/pull/6956/diff?src=pr&el=tree#diff-YWlyZmxvdy91dGlscy9jbGkucHk=) | `68.75% <0%> (-2.95%)` | :arrow_down: |
| [airflow/configuration.py](https://codecov.io/gh/apache/airflow/pull/6956/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb25maWd1cmF0aW9uLnB5) | `91.43% <0%> (-1.22%)` | :arrow_down: |
| [airflow/utils/helpers.py](https://codecov.io/gh/apache/airflow/pull/6956/diff?src=pr&el=tree#diff-YWlyZmxvdy91dGlscy9oZWxwZXJzLnB5) | `81.69% <0%> (-1.06%)` | :arrow_down: |
| ... and [85 more](https://codecov.io/gh/apache/airflow/pull/6956/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/6956?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/6956?src=pr&el=footer). Last update [7d97d16...3bdf12d](https://codecov.io/gh/apache/airflow/pull/6956?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] feluelle commented on a change in pull request #6956:
[AIRFLOW-6387] print details of success/skipped task
Posted by GitBox <gi...@apache.org>.
feluelle commented on a change in pull request #6956: [AIRFLOW-6387] print details of success/skipped task
URL: https://github.com/apache/airflow/pull/6956#discussion_r362171481
##########
File path: airflow/models/taskinstance.py
##########
@@ -963,12 +963,31 @@ def signal_handler(signum, frame):
Stats.incr('ti_successes')
self.refresh_from_db(lock_for_update=True)
self.state = State.SUCCESS
+ self.log.info(
+ 'Marking task as SUCCESS.'
+ 'dag_id=%s, task_id=%s, execution_date=%s, start_date=%s, end_date=%s',
+ self.dag_id,
+ self.task_id,
+ self.execution_date.strftime('%Y%m%dT%H%M%S'),
+ self.start_date.strftime('%Y%m%dT%H%M%S'),
+ self.end_date.strftime('%Y%m%dT%H%M%S'))
except AirflowSkipException as e:
# log only if exception has any arguments to prevent log flooding
if e.args:
self.log.info(e)
self.refresh_from_db(lock_for_update=True)
self.state = State.SKIPPED
+ try:
+ self.log.info(
+ 'Marking task as SKIPPED.'
+ 'dag_id=%s, task_id=%s, execution_date=%s, start_date=%s, end_date=%s',
+ self.dag_id,
+ self.task_id,
+ self.execution_date.strftime('%Y%m%dT%H%M%S'),
+ self.start_date.strftime('%Y%m%dT%H%M%S'),
+ self.end_date.strftime('%Y%m%dT%H%M%S'))
+ except NameError:
Review comment:
Is the `try-except` really necessary?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #6956:
[AIRFLOW-6387] print details of success/skipped task
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #6956: [AIRFLOW-6387] print details of success/skipped task
URL: https://github.com/apache/airflow/pull/6956#issuecomment-570083400
# [Codecov](https://codecov.io/gh/apache/airflow/pull/6956?src=pr&el=h1) Report
> Merging [#6956](https://codecov.io/gh/apache/airflow/pull/6956?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/5e100ab753635521d33f287bdffd3d9bd4c6ae0f?src=pr&el=desc) will **decrease** coverage by `<.01%`.
> The diff coverage is `100%`.
[](https://codecov.io/gh/apache/airflow/pull/6956?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6956 +/- ##
==========================================
- Coverage 84.7% 84.69% -0.01%
==========================================
Files 679 679
Lines 38488 38666 +178
==========================================
+ Hits 32600 32748 +148
- Misses 5888 5918 +30
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/6956?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/models/taskinstance.py](https://codecov.io/gh/apache/airflow/pull/6956/diff?src=pr&el=tree#diff-YWlyZmxvdy9tb2RlbHMvdGFza2luc3RhbmNlLnB5) | `94.92% <100%> (+0.01%)` | :arrow_up: |
| [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/6956/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
| [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/6956/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
| [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/6956/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: |
| [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/6956/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: |
| [...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/6956/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==) | `78.75% <0%> (-20%)` | :arrow_down: |
| [airflow/utils/file.py](https://codecov.io/gh/apache/airflow/pull/6956/diff?src=pr&el=tree#diff-YWlyZmxvdy91dGlscy9maWxlLnB5) | `86.3% <0%> (-5.17%)` | :arrow_down: |
| [airflow/configuration.py](https://codecov.io/gh/apache/airflow/pull/6956/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb25maWd1cmF0aW9uLnB5) | `91.43% <0%> (-1.22%)` | :arrow_down: |
| [airflow/utils/helpers.py](https://codecov.io/gh/apache/airflow/pull/6956/diff?src=pr&el=tree#diff-YWlyZmxvdy91dGlscy9oZWxwZXJzLnB5) | `81.69% <0%> (-1.06%)` | :arrow_down: |
| [airflow/utils/log/es\_task\_handler.py](https://codecov.io/gh/apache/airflow/pull/6956/diff?src=pr&el=tree#diff-YWlyZmxvdy91dGlscy9sb2cvZXNfdGFza19oYW5kbGVyLnB5) | `93.39% <0%> (-0.78%)` | :arrow_down: |
| ... and [80 more](https://codecov.io/gh/apache/airflow/pull/6956/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/6956?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/6956?src=pr&el=footer). Last update [5e100ab...3bdf12d](https://codecov.io/gh/apache/airflow/pull/6956?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #6956:
[AIRFLOW-6387] print details of success/skipped task
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #6956: [AIRFLOW-6387] print details of success/skipped task
URL: https://github.com/apache/airflow/pull/6956#issuecomment-570083400
# [Codecov](https://codecov.io/gh/apache/airflow/pull/6956?src=pr&el=h1) Report
> Merging [#6956](https://codecov.io/gh/apache/airflow/pull/6956?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/5e100ab753635521d33f287bdffd3d9bd4c6ae0f?src=pr&el=desc) will **decrease** coverage by `<.01%`.
> The diff coverage is `100%`.
[](https://codecov.io/gh/apache/airflow/pull/6956?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6956 +/- ##
==========================================
- Coverage 84.7% 84.69% -0.01%
==========================================
Files 679 679
Lines 38488 38666 +178
==========================================
+ Hits 32600 32748 +148
- Misses 5888 5918 +30
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/6956?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/models/taskinstance.py](https://codecov.io/gh/apache/airflow/pull/6956/diff?src=pr&el=tree#diff-YWlyZmxvdy9tb2RlbHMvdGFza2luc3RhbmNlLnB5) | `94.92% <100%> (+0.01%)` | :arrow_up: |
| [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/6956/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
| [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/6956/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
| [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/6956/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: |
| [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/6956/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: |
| [...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/6956/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==) | `78.75% <0%> (-20%)` | :arrow_down: |
| [airflow/utils/file.py](https://codecov.io/gh/apache/airflow/pull/6956/diff?src=pr&el=tree#diff-YWlyZmxvdy91dGlscy9maWxlLnB5) | `86.3% <0%> (-5.17%)` | :arrow_down: |
| [airflow/configuration.py](https://codecov.io/gh/apache/airflow/pull/6956/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb25maWd1cmF0aW9uLnB5) | `91.43% <0%> (-1.22%)` | :arrow_down: |
| [airflow/utils/helpers.py](https://codecov.io/gh/apache/airflow/pull/6956/diff?src=pr&el=tree#diff-YWlyZmxvdy91dGlscy9oZWxwZXJzLnB5) | `81.69% <0%> (-1.06%)` | :arrow_down: |
| [airflow/utils/log/es\_task\_handler.py](https://codecov.io/gh/apache/airflow/pull/6956/diff?src=pr&el=tree#diff-YWlyZmxvdy91dGlscy9sb2cvZXNfdGFza19oYW5kbGVyLnB5) | `93.39% <0%> (-0.78%)` | :arrow_down: |
| ... and [80 more](https://codecov.io/gh/apache/airflow/pull/6956/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/6956?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/6956?src=pr&el=footer). Last update [5e100ab...3bdf12d](https://codecov.io/gh/apache/airflow/pull/6956?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] potiuk merged pull request #6956: [AIRFLOW-6387] print
details of success/skipped task
Posted by GitBox <gi...@apache.org>.
potiuk merged pull request #6956: [AIRFLOW-6387] print details of success/skipped task
URL: https://github.com/apache/airflow/pull/6956
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #6956:
[AIRFLOW-6387] print details of success/skipped task
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #6956: [AIRFLOW-6387] print details of success/skipped task
URL: https://github.com/apache/airflow/pull/6956#issuecomment-570083400
# [Codecov](https://codecov.io/gh/apache/airflow/pull/6956?src=pr&el=h1) Report
> Merging [#6956](https://codecov.io/gh/apache/airflow/pull/6956?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/7d97d16c47ba181839fd583b8653d2872dc4290b?src=pr&el=desc) will **decrease** coverage by `0.01%`.
> The diff coverage is `100%`.
[](https://codecov.io/gh/apache/airflow/pull/6956?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6956 +/- ##
==========================================
- Coverage 84.7% 84.69% -0.02%
==========================================
Files 680 679 -1
Lines 38556 38666 +110
==========================================
+ Hits 32659 32748 +89
- Misses 5897 5918 +21
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/6956?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/models/taskinstance.py](https://codecov.io/gh/apache/airflow/pull/6956/diff?src=pr&el=tree#diff-YWlyZmxvdy9tb2RlbHMvdGFza2luc3RhbmNlLnB5) | `94.92% <100%> (+0.01%)` | :arrow_up: |
| [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/6956/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
| [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/6956/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
| [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/6956/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: |
| [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/6956/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: |
| [...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/6956/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==) | `78.75% <0%> (-20%)` | :arrow_down: |
| [airflow/utils/file.py](https://codecov.io/gh/apache/airflow/pull/6956/diff?src=pr&el=tree#diff-YWlyZmxvdy91dGlscy9maWxlLnB5) | `86.3% <0%> (-5.17%)` | :arrow_down: |
| [airflow/utils/cli.py](https://codecov.io/gh/apache/airflow/pull/6956/diff?src=pr&el=tree#diff-YWlyZmxvdy91dGlscy9jbGkucHk=) | `68.75% <0%> (-2.95%)` | :arrow_down: |
| [airflow/configuration.py](https://codecov.io/gh/apache/airflow/pull/6956/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb25maWd1cmF0aW9uLnB5) | `91.43% <0%> (-1.22%)` | :arrow_down: |
| [airflow/utils/helpers.py](https://codecov.io/gh/apache/airflow/pull/6956/diff?src=pr&el=tree#diff-YWlyZmxvdy91dGlscy9oZWxwZXJzLnB5) | `81.69% <0%> (-1.06%)` | :arrow_down: |
| ... and [85 more](https://codecov.io/gh/apache/airflow/pull/6956/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/6956?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/6956?src=pr&el=footer). Last update [7d97d16...3bdf12d](https://codecov.io/gh/apache/airflow/pull/6956?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] tooptoop4 commented on issue #6956: [AIRFLOW-6387] print
details of success/skipped task
Posted by GitBox <gi...@apache.org>.
tooptoop4 commented on issue #6956: [AIRFLOW-6387] print details of success/skipped task
URL: https://github.com/apache/airflow/pull/6956#issuecomment-570893702
@potiuk gentle ping
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services