[GitHub] [dolphinscheduler] WangJPLeo commented on a diff in pull request #10910: [Fix-10909] Returns executionStatus for each process instance status.

[GitBox <gi...@apache.org>]

WangJPLeo commented on code in PR #10910:
URL: https://github.com/apache/dolphinscheduler/pull/10910#discussion_r919595439


##########
dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/runner/WorkflowExecuteRunnable.java:
##########
@@ -1813,7 +1814,7 @@ protected List<TaskInstance> getRecoverTaskInstanceList(String cmdParam) {
         if (paramMap != null && paramMap.containsKey(CMD_PARAM_RECOVERY_START_NODE_STRING)) {
             String[] idList = paramMap.get(CMD_PARAM_RECOVERY_START_NODE_STRING).split(Constants.COMMA);
             if (ArrayUtils.isNotEmpty(idList)) {
-                List<Integer> taskInstanceIds = Arrays.stream(idList).map(Integer::valueOf).collect(Collectors.toList());
+                List<Integer> taskInstanceIds = Arrays.stream(idList).filter(StringUtils::isNotEmpty).map(Integer::valueOf).collect(Collectors.toList());

Review Comment:
   It's nice, ok.



##########
dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/impl/AccessTokenServiceImpl.java:
##########
@@ -17,33 +17,40 @@
 
 package org.apache.dolphinscheduler.api.service.impl;
 
-import com.baomidou.mybatisplus.core.metadata.IPage;
-import com.baomidou.mybatisplus.extension.plugins.pagination.Page;
-import org.apache.commons.lang3.StringUtils;
+
+import static org.apache.dolphinscheduler.api.constants.ApiFuncIdentificationConstant.ACCESS_TOKEN_CREATE;

Review Comment:
   ok.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org