You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@servicecomb.apache.org by GitBox <gi...@apache.org> on 2018/09/27 12:24:10 UTC
[GitHub] codecov-io commented on issue #451: SCB-941 Support multiple
datacenter deployment
codecov-io commented on issue #451: SCB-941 Support multiple datacenter deployment
URL: https://github.com/apache/incubator-servicecomb-service-center/pull/451#issuecomment-425070687
# [Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/451?src=pr&el=h1) Report
> Merging [#451](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/451?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-servicecomb-service-center/commit/204d35cc4a02b447fcbb55f83d824fa1bcddba27?src=pr&el=desc) will **increase** coverage by `0.07%`.
> The diff coverage is `45.88%`.
[](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/451?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #451 +/- ##
==========================================
+ Coverage 59.95% 60.03% +0.07%
==========================================
Files 149 156 +7
Lines 13183 13388 +205
==========================================
+ Hits 7904 8037 +133
- Misses 4703 4776 +73
+ Partials 576 575 -1
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/451?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [server/service/tag\_validator.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/451/diff?src=pr&el=tree#diff-c2VydmVyL3NlcnZpY2UvdGFnX3ZhbGlkYXRvci5nbw==) | `100% <ø> (ø)` | :arrow_up: |
| [server/service/rule\_validator.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/451/diff?src=pr&el=tree#diff-c2VydmVyL3NlcnZpY2UvcnVsZV92YWxpZGF0b3IuZ28=) | `100% <ø> (ø)` | :arrow_up: |
| [server/plugin/pkg/discovery/types.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/451/diff?src=pr&el=tree#diff-c2VydmVyL3BsdWdpbi9wa2cvZGlzY292ZXJ5L3R5cGVzLmdv) | `77.77% <ø> (ø)` | |
| [server/plugin/pkg/registry/etcd/logger.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/451/diff?src=pr&el=tree#diff-c2VydmVyL3BsdWdpbi9wa2cvcmVnaXN0cnkvZXRjZC9sb2dnZXIuZ28=) | `80.76% <ø> (ø)` | |
| [server/plugin/pkg/registry/etcd/metrics.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/451/diff?src=pr&el=tree#diff-c2VydmVyL3BsdWdpbi9wa2cvcmVnaXN0cnkvZXRjZC9tZXRyaWNzLmdv) | `100% <ø> (ø)` | |
| [server/service/schema\_validator.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/451/diff?src=pr&el=tree#diff-c2VydmVyL3NlcnZpY2Uvc2NoZW1hX3ZhbGlkYXRvci5nbw==) | `100% <ø> (ø)` | :arrow_up: |
| [server/plugin/pkg/tls/buildin/tls.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/451/diff?src=pr&el=tree#diff-c2VydmVyL3BsdWdpbi9wa2cvdGxzL2J1aWxkaW4vdGxzLmdv) | `82.08% <ø> (ø)` | |
| [server/plugin/pkg/discovery/etcd/watcher\_inner.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/451/diff?src=pr&el=tree#diff-c2VydmVyL3BsdWdpbi9wa2cvZGlzY292ZXJ5L2V0Y2Qvd2F0Y2hlcl9pbm5lci5nbw==) | `100% <ø> (ø)` | |
| [server/plugin/pkg/registry/etcd/tracing.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/451/diff?src=pr&el=tree#diff-c2VydmVyL3BsdWdpbi9wa2cvcmVnaXN0cnkvZXRjZC90cmFjaW5nLmdv) | `81.81% <ø> (ø)` | |
| [server/plugin/pkg/tracing/buildin/common.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/451/diff?src=pr&el=tree#diff-c2VydmVyL3BsdWdpbi9wa2cvdHJhY2luZy9idWlsZGluL2NvbW1vbi5nbw==) | `80% <ø> (ø)` | |
| ... and [84 more](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/451/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/451?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/451?src=pr&el=footer). Last update [204d35c...10c8d39](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/451?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services