You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shenyu.apache.org by "Aias00 (via GitHub)" <gi...@apache.org> on 2026/08/03 01:11:25 UTC
[I] [BUG] TarsMetaDataHandler dedup comparison is semantically wrong (host vs appName) [shenyu]
Aias00 opened a new issue, #6738:
URL: https://github.com/apache/shenyu/issues/6738
- severity: Medium
- files: `shenyu-plugin/shenyu-plugin-proxy/shenyu-plugin-rpc/shenyu-plugin-tars/src/main/java/org/apache/shenyu/plugin/tars/handler/TarsMetaDataHandler.java:44-49`
- description: `handle` decides whether to (re)initialize by `prxList.stream().anyMatch(prx -> prx.getHost().equals(metaData.getAppName()))`. But `TarsInvokePrx.host` is set to `upstream.getUpstreamUrl()` (e.g. `1.2.3.4:1080`), while the compared value is `metaData.getAppName()` (e.g. `HelloApp`). These never match, so `exist` is always false and `initPrx` is invoked on every metadata handle event.
- impact: Every tars metadata sync triggers a redundant `initPrx` → `refreshTarsInvokePrxList`, amplifying TARS-02's race window.
- suggested_fix: Compare against a field that actually holds the app name, or store the app name on `TarsInvokePrx`.
- confidence: Medium
- related_existing: none
---
_Identified during the 2026-08-02 deep re-scan; full list in [`docs/scan2-2026-08-02/06-medium-tiers.md`](docs/scan2-2026-08-02/06-medium-tiers.md)._
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [BUG] TarsMetaDataHandler dedup comparison is semantically wrong (host vs appName) [shenyu]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on issue #6738:
URL: https://github.com/apache/shenyu/issues/6738#issuecomment-5161310968
👋 Hello @yuluo-yx
A new issue has been opened by @Aias00:
- **Title**: [BUG] TarsMetaDataHandler dedup comparison is semantically wrong (host vs appName)
- **Link**: https://github.com/apache/shenyu/issues/6738
Please review when you have time. Thank you! 🙏
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [BUG] TarsMetaDataHandler dedup comparison is semantically wrong (host vs appName) [shenyu]
Posted by "yangjj-iso (via GitHub)" <gi...@apache.org>.
yangjj-iso commented on issue #6738:
URL: https://github.com/apache/shenyu/issues/6738#issuecomment-6215766537
/assign
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org