You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2020/08/26 08:37:56 UTC
[GitHub] [beam] TobKed opened a new pull request #12685: [BEAM-10807] Add scheduled mail with metrics report
TobKed opened a new pull request #12685:
URL: https://github.com/apache/beam/pull/12685
Example of generated html is available here (used historical data, not the production):
https://storage.googleapis.com/beam-wheel-test-bucket-uscentral1/metrics-report/beam-metrics_report.html
------------------------
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] [**Choose reviewer(s)**](https://beam.apache.org/contribute/#make-your-change) and mention them in a comment (`R: @username`).
- [ ] Format the pull request title like `[BEAM-XXX] Fixes bug in ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/#make-reviewers-job-easier).
Post-Commit Tests Status (on master branch)
------------------------------------------------------------------------------------------------
Lang | SDK | Dataflow | Flink | Samza | Spark | Twister2
--- | --- | --- | --- | --- | --- | ---
Go | [](https://ci-beam.apache.org/job/beam_PostCommit_Go/lastCompletedBuild/) | --- | [](https://ci-beam.apache.org/job/beam_PostCommit_Go_VR_Flink/lastCompletedBuild/) | --- | [](https://ci-beam.apache.org/job/beam_PostCommit_Go_VR_Spark/lastCompletedBuild/) | ---
Java | [](https://ci-beam.apache.org/job/beam_PostCommit_Java/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow_Java11/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink_Java11/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Java_PVR_Flink_Batch/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Java_PVR_Flink_Streaming/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Samza/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Spark/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Java_PVR_Spark_Batch/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_SparkStructuredStreaming/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Twister2/lastCompletedBuild/)
Python | [](https://ci-beam.apache.org/job/beam_PostCommit_Python2/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Python35/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Python36/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Python37/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Python38/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PostCommit_Py_VR_Dataflow/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Py_VR_Dataflow_V2/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Py_ValCont/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PreCommit_Python2_PVR_Flink_Cron/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Python35_VR_Flink/lastCompletedBuild/) | --- | [](https://ci-beam.apache.org/job/beam_PostCommit_Python_VR_Spark/lastCompletedBuild/) | ---
XLang | [](https://ci-beam.apache.org/job/beam_PostCommit_XVR_Direct/lastCompletedBuild/) | --- | [](https://ci-beam.apache.org/job/beam_PostCommit_XVR_Flink/lastCompletedBuild/) | --- | [](https://ci-beam.apache.org/job/beam_PostCommit_XVR_Spark/lastCompletedBuild/) | ---
Pre-Commit Tests Status (on master branch)
------------------------------------------------------------------------------------------------
--- |Java | Python | Go | Website | Whitespace
--- | --- | --- | --- | --- | ---
Non-portable | [](https://ci-beam.apache.org/job/beam_PreCommit_Java_Cron/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PreCommit_Python_Cron/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PreCommit_PythonLint_Cron/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PreCommit_PythonDocker_Cron/lastCompletedBuild/) <br>[](https://ci-beam.apache.org/job/beam_PreCommit_PythonDocs_Cron/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PreCommit_Go_Cron/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PreCommit_Website_Cron/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PreCommit_Whitespace_Cron/lastCompletedBuild/)
Portable | --- | [](https://ci-beam.apache.org/job/beam_PreCommit_Portable_Python_Cron/lastCompletedBuild/) | --- | --- | ---
See [.test-infra/jenkins/README](https://github.com/apache/beam/blob/master/.test-infra/jenkins/README.md) for trigger phrase, status and link of all Jenkins jobs.
GitHub Actions Tests Status (on master branch)
------------------------------------------------------------------------------------------------
See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] TobKed commented on pull request #12685: [BEAM-10807] Add scheduled mail with metrics report
Posted by GitBox <gi...@apache.org>.
TobKed commented on pull request #12685:
URL: https://github.com/apache/beam/pull/12685#issuecomment-682465639
R: @aaltay @robertwb @mxm @robertwb @kamilwu @mwalenia
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] kamilwu merged pull request #12685: [BEAM-10807] Add scheduled mail with metrics report
Posted by GitBox <gi...@apache.org>.
kamilwu merged pull request #12685:
URL: https://github.com/apache/beam/pull/12685
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] TobKed commented on a change in pull request #12685: [BEAM-10807] Add scheduled mail with metrics report
Posted by GitBox <gi...@apache.org>.
TobKed commented on a change in pull request #12685:
URL: https://github.com/apache/beam/pull/12685#discussion_r481401465
##########
File path: .test-infra/jenkins/build.gradle
##########
@@ -20,3 +20,32 @@ plugins {
id 'org.apache.beam.module'
}
applyGroovyNature()
+applyPythonNature()
+
+pythonVersion = '3.8'
+
+task generateMetricsReport {
+ dependsOn setupVirtualenv
+ def metricsReportFilename = "beam-metrics_report.html"
+ def generateMetricsReportDir = "${rootDir}/.test-infra/jenkins/metrics_report"
+ def generateMetricsReportPath = "${generateMetricsReportDir}/${metricsReportFilename}"
+ def toxConfigFilePath = "${rootDir}/.test-infra/jenkins/metrics_report/tox.ini"
+
+ def influxDb = project.findProperty('influxDb')
+ def influxHost = project.findProperty('influxHost')
+ def influxPort = project.findProperty('influxPort')
+
+ doLast {
+ exec {
+ executable 'sh'
+ args '-c', ". ${envdir}/bin/activate && tox -e py38-test -c ${toxConfigFilePath}"
+ }
+ exec {
+ executable 'sh'
+ args '-c', ". ${envdir}/bin/activate && tox -e py38-generate-report -c ${toxConfigFilePath} -- --influx-db=${influxDb} --influx-host=${influxHost} --influx-port=${influxPort} --output-file=${generateMetricsReportPath}"
+ }
+ logger.info('Create metrics report file {}', generateMetricsReportPath)
+ }
+ outputs.file "${generateMetricsReportPath}"
+}
+build.dependsOn generateMetricsReport
Review comment:
Sure. It is removed. Thank you for pointing this out.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] TobKed commented on a change in pull request #12685: [BEAM-10807] Add scheduled mail with metrics report
Posted by GitBox <gi...@apache.org>.
TobKed commented on a change in pull request #12685:
URL: https://github.com/apache/beam/pull/12685#discussion_r481072065
##########
File path: .test-infra/jenkins/metrics_report/templates/Metrics_Report.template
##########
@@ -0,0 +1,141 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+<html>
+<body>
+
+<h1>Beam Metrics Report</h1>
+
+Color legend:
+<table>
+ <tr>
+ <td style="background-color:Red;padding:9px;text-align:center;">>= 20</td>
+ <td style="background-color:Yellow;padding:9px;text-align:center;">>= 10</td>
+ <td style="background-color:YellowGreen;padding:9px;text-align:center;"><= -10</td>
+ <td style="background-color:Green;padding:9px;text-align:center;"><= -20</td>
+ </tr>
+</table>
+
+
+<h2>Possible regression</h2>
+
+<table>
+<tr>
+ {% for header in headers -%}
+ <td style="border-bottom:1px solid #ddd"><b>{{ header }}</b></td>
+ {% endfor %}
+</tr>
+
+{% for row in metrics_data -%}
+ {% if row[5] >= 10 %}
Review comment:
Yes. It is related to difference of mean metric values from the last and previous week. Usually it is runtime but it can be read_time or write_time as well.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] mxm commented on a change in pull request #12685: [BEAM-10807] Add scheduled mail with metrics report
Posted by GitBox <gi...@apache.org>.
mxm commented on a change in pull request #12685:
URL: https://github.com/apache/beam/pull/12685#discussion_r481056943
##########
File path: .test-infra/jenkins/metrics_report/templates/Metrics_Report.template
##########
@@ -0,0 +1,141 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+<html>
+<body>
+
+<h1>Beam Metrics Report</h1>
+
+Color legend:
+<table>
+ <tr>
+ <td style="background-color:Red;padding:9px;text-align:center;">>= 20</td>
+ <td style="background-color:Yellow;padding:9px;text-align:center;">>= 10</td>
+ <td style="background-color:YellowGreen;padding:9px;text-align:center;"><= -10</td>
+ <td style="background-color:Green;padding:9px;text-align:center;"><= -20</td>
+ </tr>
+</table>
+
+
+<h2>Possible regression</h2>
+
+<table>
+<tr>
+ {% for header in headers -%}
+ <td style="border-bottom:1px solid #ddd"><b>{{ header }}</b></td>
+ {% endfor %}
+</tr>
+
+{% for row in metrics_data -%}
+ {% if row[5] >= 10 %}
Review comment:
A regressions is defined as >=10 % increase in runtime?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] kamilwu commented on a change in pull request #12685: [BEAM-10807] Add scheduled mail with metrics report
Posted by GitBox <gi...@apache.org>.
kamilwu commented on a change in pull request #12685:
URL: https://github.com/apache/beam/pull/12685#discussion_r481134344
##########
File path: .test-infra/jenkins/build.gradle
##########
@@ -20,3 +20,32 @@ plugins {
id 'org.apache.beam.module'
}
applyGroovyNature()
+applyPythonNature()
+
+pythonVersion = '3.8'
+
+task generateMetricsReport {
+ dependsOn setupVirtualenv
+ def metricsReportFilename = "beam-metrics_report.html"
+ def generateMetricsReportDir = "${rootDir}/.test-infra/jenkins/metrics_report"
+ def generateMetricsReportPath = "${generateMetricsReportDir}/${metricsReportFilename}"
+ def toxConfigFilePath = "${rootDir}/.test-infra/jenkins/metrics_report/tox.ini"
+
+ def influxDb = project.findProperty('influxDb')
+ def influxHost = project.findProperty('influxHost')
+ def influxPort = project.findProperty('influxPort')
+
+ doLast {
+ exec {
+ executable 'sh'
+ args '-c', ". ${envdir}/bin/activate && tox -e py38-test -c ${toxConfigFilePath}"
+ }
+ exec {
+ executable 'sh'
+ args '-c', ". ${envdir}/bin/activate && tox -e py38-generate-report -c ${toxConfigFilePath} -- --influx-db=${influxDb} --influx-host=${influxHost} --influx-port=${influxPort} --output-file=${generateMetricsReportPath}"
+ }
+ logger.info('Create metrics report file {}', generateMetricsReportPath)
+ }
+ outputs.file "${generateMetricsReportPath}"
+}
+build.dependsOn generateMetricsReport
Review comment:
Your report would be generated every time someone builds the whole project (by executing `./gradlew build`). I think this is not what we wanted. Could you remove this line?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] aaltay commented on pull request #12685: [BEAM-10807] Add scheduled mail with metrics report
Posted by GitBox <gi...@apache.org>.
aaltay commented on pull request #12685:
URL: https://github.com/apache/beam/pull/12685#issuecomment-685921037
Nice, thank you for doing this.
/cc FYI - Relevant folks - @tweise @alanmyrvold @tysonjh
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org